From: Christoph Hellwig <hch@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
martin.petersen@oracle.com, ebiggers@google.com,
p.raghav@samsung.com, hare@suse.de, kbusch@kernel.org,
david@fromorbit.com, neilb@suse.de, gost.dev@samsung.com,
linux-block@vger.kernel.org, linux-mm@kvack.org,
patches@lists.linux.dev
Subject: Re: [RFC] bdev: use bdev_io_min() for statx DIO min IO
Date: Sat, 29 Jun 2024 22:54:19 -0700 [thread overview]
Message-ID: <ZoDzC1qlEYTBkLPA@infradead.org> (raw)
In-Reply-To: <ZoDP0LgeLV3H1JbB@bombadil.infradead.org>
On Sat, Jun 29, 2024 at 08:24:00PM -0700, Luis Chamberlain wrote:
> > The minimum_io_size clearly is the minimum I/O size, not the minimal
> > nice to have one.
>
> I may have misread the below documentation then, because it seems to
> suggest this is a performance parameter, not a real minimum. Do we need
> to update it?
queue_limits.min_io is corretly described and a performance hint.
The statx dio_offset_align is actual minimum I/O size and alignment and
not in any way related to the performance hint in minimum_io_size.
next prev parent reply other threads:[~2024-06-30 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 21:23 Luis Chamberlain
2024-06-29 6:25 ` Christoph Hellwig
2024-06-30 3:24 ` Luis Chamberlain
2024-06-30 5:54 ` Christoph Hellwig [this message]
2024-06-30 20:42 ` Luis Chamberlain
2024-06-30 22:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoDzC1qlEYTBkLPA@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=ebiggers@google.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=neilb@suse.de \
--cc=p.raghav@samsung.com \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox