From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76717C3DA41 for ; Wed, 10 Jul 2024 18:41:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC72B6B009D; Wed, 10 Jul 2024 14:41:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E777E6B009E; Wed, 10 Jul 2024 14:41:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D17C56B009F; Wed, 10 Jul 2024 14:41:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B22EF6B009D for ; Wed, 10 Jul 2024 14:41:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2EFFF140210 for ; Wed, 10 Jul 2024 18:41:29 +0000 (UTC) X-FDA: 82324711098.16.03B765C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id E6A5B4000D for ; Wed, 10 Jul 2024 18:41:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BaOlvia2; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720636854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+eIVX3Nh3vYBEeF7J3Cswb85HDhmhS0B4NjP2O37xgE=; b=cTZXlDUHtqYOvzc2NW9J6wpfAgHygUi6RAHpjMH8+bgs0mQY9wkGDs2w2w7HNqGoQCI7ql YmapqVaAAnW7/0QnyGy0fnecP0kNDlSSjAtPdxxszQc3fkYr2GJY3InMoGqCQghzlEJag6 NjjEwhX+loFNGYrA3PmOEWXrJCR6aXg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720636854; a=rsa-sha256; cv=none; b=yQK39JZ9mEAlEU+r0LCMBRbeTB2DJH3GoDD/PXNfYmSbOTpHV0OX+3/i3kad9j9PuUh4Eo KIk6U7vRjMH7gdH/yUQNB2+CAKnCOdTVXmWSfjhlZPey8GTjplC0inNvhScJ53CHJLuhOx XCQXjmYbYaBnb2uGzrSA+gO0Ze84h90= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BaOlvia2; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720636886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+eIVX3Nh3vYBEeF7J3Cswb85HDhmhS0B4NjP2O37xgE=; b=BaOlvia2NwWVRbTDVWmHqqRVIVQ7zgL0WEu4LLr7edU1+mzktcjhmIH1iMPJQMXtEUDm9Q 7+5NR0dvgKxrP3o0OWLpP6+WrMkZID5fp7RBtVgq7hvXD4D1GB+BjVyTwcQfuYDrYQJTRx 1Js4d+rpZ72LNdP2I1SMSVsuILJSINo= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-ht2M3Bv4Oiq9rJtP3IVaiQ-1; Wed, 10 Jul 2024 14:41:22 -0400 X-MC-Unique: ht2M3Bv4Oiq9rJtP3IVaiQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7a05b6bfb8aso1548985a.3 for ; Wed, 10 Jul 2024 11:41:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720636882; x=1721241682; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+eIVX3Nh3vYBEeF7J3Cswb85HDhmhS0B4NjP2O37xgE=; b=nSPzONoiax7O7mCFbI1AqbqFeu1WY6j9ZbML06whA4g87aAKFL9IzIPB49ZundCV/n CeKKvfio3aBm9DTlxhFcjlW+1N8zYZ0WeGIaL+rOYaVUJkJy8dRyJrX1szrWMjRRFNUu DOpjAhc8ZZvmTHOUdMVgbjBGuB7bgtlspsO6e/+sUVnpSpUCinzqyK3V8PmR03/0Qv4U ZJ863/e6WOoJSpOiA/j6+mmfx1sUJHuff39A8T6enBq5ojKHb7qNeuZ2T5w3ByoFlZ+c 8beq9Dqo3b4E5ZnSGWMY2CD525WvnMz4UMmIaeBGzE50es9HU0UJdhZxmPHvMNoGUP7z TfPg== X-Forwarded-Encrypted: i=1; AJvYcCWb9M2dSN/s9FE0pDUBUxGQrgdcuvOE5w/jk1vDn2cEOs2zDwUT2d5Jq1qKKjawF9QIrRK2iKDGy48DLou/UFOU7us= X-Gm-Message-State: AOJu0YxLSVh1FBC2/DgeK8BWMo6zAgqzrmvw2//C2JUQiHGxuS5/IVfs dkSM9bo1KUhvQ7Jy+oElnhkp2TehvziniE1TNDkEDSWy/DKajUR0VB6e1sqrsp1mAAfKcbW6GUq zfmb0nXiXvNie+jH+xkTSqDoBXfTqXy5dEg8nDsRxe35VIKYI X-Received: by 2002:ac8:4c82:0:b0:447:f0c4:8298 with SMTP id d75a77b69052e-44cfc3fa56amr3702461cf.2.1720636882416; Wed, 10 Jul 2024 11:41:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETdUfrXNqDgbDS7Z1BhFJRvI4WQSOwSqIDdD+5+bC0SwiVZqBADzNnXqHzy4Zdi40FUQ/PVQ== X-Received: by 2002:ac8:4c82:0:b0:447:f0c4:8298 with SMTP id d75a77b69052e-44cfc3fa56amr3702401cf.2.1720636882087; Wed, 10 Jul 2024 11:41:22 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9b26c83sm22681111cf.2.2024.07.10.11.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 11:41:21 -0700 (PDT) Date: Wed, 10 Jul 2024 14:41:19 -0400 From: Peter Xu To: LEROY Christophe Cc: Christophe Leroy , Andrew Morton , Arnd Bergmann , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "x86@kernel.org" , "linux-riscv@lists.infradead.org" , Oscar Salvador Subject: Re: [PATCH v2 3/3] mm: Add p{g/4}d_leaf() in asm-generic/pgtable-nop{4/u}d.h Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Stat-Signature: wnh6oa1oswn199zucj5sbyifu7d3osjm X-Rspamd-Queue-Id: E6A5B4000D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720636886-577088 X-HE-Meta: U2FsdGVkX18huNuNNUO+9vkOTiONwrEwjwUTLJ1krGZy6tP2BgF7oW6gL+lxORELuPTc8gziDXaZs91b5M+gY1w8TnFRz9bZ6+dD/0nTxIURX5XCekl1YxTdbjmJdbmLxXbc7fmM4V6boyktRV+Aly5Q1i98s452Ec68zx1d5Iy80mUZujtcyt7/pq/G89c0SXEPLaOnrMuOz4hBfGYrrZkkGAJyii+7ODYhP/0pCnWXGXS4rM1r6QWUMt0vyow++sLJlihxTJ4Dms/I467T0Syq1rizi3tdbdB/wq1hQU87OPa/IZWzg6fvXd5y6HEQZ1Ko3pOhVZ39z/UrAxS/z/CmjWZWQMS5AcIcRS04FaokxlDG++0W+M5ca8K/MdWMb0SNaM62Y7oG6xj4/71NhIrFr7ZqtzNDdMJHIOVUlhuWrr0OgrvO/GYnB1urDP9sfVjkbknOVzNb+OwwwpYzyqMLhvISy0fllesdEdsU+NmFBieUp+bwV8+/vEI/LFeG8dqyFU8jXaXnf42GnZRIu8Um2cwLcfGyiVclvvxfgbIyC1dS730AJDbkQkTKh4+td4KhNBReW+qxzlg3LVPJCcfRF107H5ndSMSQ6fH3PjuPcDTLiernLOGipstxyKc7/cDMDWL3jn4OwaFF6/tFc9d8MiVeiJWGabw8LaG0lyPQuz3DGjKQrSZurX7zKdUF10KX1d8Pqgf299tkeU0MfWfadvWLuzxlk9K2oa3PB/f/F6dkbgeiSmG1qZPf8G1y636LHtw2o8pXhVtWO4aRe5ZJUTOEf3l43N3ZolrgnZc8OZnL5TIRwgow9NXf7nPQH1lzPQTIS8HIP+9bqVBVGGZTEXm18Xk4qBBQi/RBXiPlX+TXFPYmQXhEpRzYg63+kDj37F8lutyORXUCyrzGE9i/DViBaQFSV6w3QaoC1QmyDafPcwUDztra6BHMLfEymoXUcik9vwkCPYn78Fy 6TyV0VbO ey3FT91Ff8Q5aTvUCIHM6+AeLwbbptSUDXP7LPyC8nL55q1hdVMopQCyZhF3sy3H/h8tW+Qu5AgJSborTQIdQ+Kr56EQNXtUNSWgT+IwREBRolXkc+zVtUGNxkDWrUA369owTe935QSMWremNv55wL0DhzvbjYdsQ1zUOASfKehvJjVrIaN6uoDDqhfx+ROj7qMiStNndQBOHII8utp37umFgR83GeVx7zaBGkJpYMvdzVcD67gv5/G8ZdASmLB51vhQvpen+cO33z6XceLREpMnA8gZCfAaHbi9xGXQG6uGK/w3seTFAAIhY+wchO36HqQnJE8/ThXA7YxtQJcOoRJn2XUUlZFFaro9qWQpLs91U4nf0kJB1CuYjpgmMWrDHn6/xZPFtP7AHOi/iR3B66EOkSKWj/1reIjNI+8ZxHt509XiT0XkFfbdFZNTFNN9DLpc9+MMVLECwORdVn/XHI8iz7gzTt1l3Odz2Mcesx+zDYD6AhUau1n9RjOCZ9QfHp+rmwTxl2dDd/HU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001646, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 10, 2024 at 02:54:36PM +0000, LEROY Christophe wrote: > > > Le 10/07/2024 à 16:46, Peter Xu a écrit : > > On Wed, Jul 10, 2024 at 09:51:22AM +0200, Christophe Leroy wrote: > >> Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related > >> issues") added pud_leaf() in include/asm-generic/pgtable-nopmd.h > >> > >> Do the same for p4d_leaf() and pgd_leaf() to avoid getting them > >> erroneously defined by architectures that do not implement the > >> related page level. > >> > >> Signed-off-by: Christophe Leroy > >> --- > >> v2: Added pXd_leaf macro as well in asm-generic/pgtable-nopXd.h to cohabit with the fallback > >> --- > > > > Thanks. I'd drop the inline functions, but no strong opinions. > > Inline functions enable type checking. > > With a macro you would be able to write pud_leaf(pgd) without the > compiler noticing the mistake. > > All other helpers in asm-generic/pgtable-nopXd.h are functions so from > my point of view it makes sense to keep them as functions not macros. Whoever fallbacks to the pgtable.h pxx_leaf() will still use macros and lose the type check again. I'd rather rely on cross-arch builds and most of real *_leaf() users will always detect a type mismatch. Totally no big deal, and I agree keeping them match nopxd.h rules makes sense. Thanks, -- Peter Xu