From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FDAC3DA42 for ; Wed, 10 Jul 2024 14:45:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89B7A6B009D; Wed, 10 Jul 2024 10:45:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84B666B009E; Wed, 10 Jul 2024 10:45:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 712B16B009F; Wed, 10 Jul 2024 10:45:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 535B96B009D for ; Wed, 10 Jul 2024 10:45:56 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BCF25140110 for ; Wed, 10 Jul 2024 14:45:55 +0000 (UTC) X-FDA: 82324117470.09.BA4336B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id A4702140015 for ; Wed, 10 Jul 2024 14:45:53 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QATPHmBg; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720622721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vuZByBoQ1AErbnDxFMqwKYDz5/nj+PfxoenuXb+QI3g=; b=k3XJ5IvWSijz+bX2wmvFArnL9h295Q4qGGC9TORH3KeX0DYvOURN9j3XfW3COzjmYnhxaO IDRsMdUczC1yngYejOQ66aHp58lHJdZ7iFTGSdxNjSGuS8dMTogfST9IvMfZsYDH5+2m8h 1HGVGbJTA38Cd8AzjcxPzTNB7tkA6wk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720622721; a=rsa-sha256; cv=none; b=wZoCxa1vNnrFSnLhQi7LT2jHRz9aME7OjsPlq9r5JvHm9zAZPQPEXLv1B3FXSMFkGSC0bg ifCRs/hYwgrS5Hz8SAT+CLJ2HkmF/wn0139AxmvaUrk+T/xrLmkLcL3ZBSWzEIB7/5Tu0M 8T/H10mpTmSf/ePq9fFXEV+lda3abeg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QATPHmBg; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720622753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vuZByBoQ1AErbnDxFMqwKYDz5/nj+PfxoenuXb+QI3g=; b=QATPHmBgVNiz6upotSvwdSVS9ZSWl+JNZjcs0tsrAis0l2bcca1oXynXalw3ZsjazLJRxf jJJkFr02oPJoICUG7DODBDJplHlmSH6o7m4bzEG04NeI7FaR2GwJS1SWb4V/o+TDHVu0K+ fI4yGfW4LMAmPnWfbyd1Cyjzh3VaxjA= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-ez0x03RrMgS9vyr9_m5dSA-1; Wed, 10 Jul 2024 10:45:51 -0400 X-MC-Unique: ez0x03RrMgS9vyr9_m5dSA-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3d6301f6c13so951096b6e.1 for ; Wed, 10 Jul 2024 07:45:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720622751; x=1721227551; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vuZByBoQ1AErbnDxFMqwKYDz5/nj+PfxoenuXb+QI3g=; b=E3a2s23h0SHznwaQKCNYSSPvcC/+6pS8161Pf6VZdBlMq1Ho43NkYR/ixrrdIe0fT0 VcA/wl7zTREnCNKSD+xXbHY7yHMdxhoiGWsYa+whzKv14+0wFPqEjtrsPpecvSVKuR6/ M6ZLNCKBDjxg3UyvGLSmaLypUzWkspyiOGoW1+F2WhpBPZY/CGdviZ6TFomIyZCQaI7+ 4C1EGevi6lc0a1UafORbEfkiT1rTbKnJsj6qFGklITso+H+DMBAQOHHPa6Yo6tnXjoSd 607aM9foPJDXvzhiW8nWr6q8MOTpv08TEGEuIHaVDN3lwllibLvf4vLJonCeGAx5Vet1 Gp7g== X-Forwarded-Encrypted: i=1; AJvYcCWj8gop2U1SUWa/v7pykY14BGDS/EwxYCTfA2YyPw7Mi8pOtMrGctMWJT+nulWOz4NwWgY6hCNH6vx/wuwmqdOkgPg= X-Gm-Message-State: AOJu0YyP/AegWKYjRnieO8aKToKehNqlb41SESASd1IX5lJtPJ13AKt0 ueAShwfDEXudsJsY7/i9wVTTqSvlX/inSJp/Y3Nwg9mVsWdfCfbmEW6hOgfAwL5J/F8SUrE5DnE FyPWf2ZlKEy7rqm5zKkJWOaO+J17mIUABGu8oXln07BSKSuzC X-Received: by 2002:a05:6808:2386:b0:3d9:33c1:29ef with SMTP id 5614622812f47-3d93c07c3e8mr5459840b6e.3.1720622750842; Wed, 10 Jul 2024 07:45:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYFNo60WHX386FdDYkulq2RlUHLqK6H506/igBHtgzdpVY0R4HJ/zDzB+r5Z2zD/uJfYuagA== X-Received: by 2002:a05:6808:2386:b0:3d9:33c1:29ef with SMTP id 5614622812f47-3d93c07c3e8mr5459824b6e.3.1720622750528; Wed, 10 Jul 2024 07:45:50 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9b5a662sm20972631cf.54.2024.07.10.07.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 07:45:50 -0700 (PDT) Date: Wed, 10 Jul 2024 10:45:48 -0400 From: Peter Xu To: Christophe Leroy Cc: Andrew Morton , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-riscv@lists.infradead.org, Oscar Salvador Subject: Re: [PATCH v2 2/3] mm: Remove pud_user() from asm-generic/pgtable-nopmd.h Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A4702140015 X-Stat-Signature: bza7ho9atujm77y3c5acdgzpwr5s6aa7 X-HE-Tag: 1720622753-284727 X-HE-Meta: U2FsdGVkX1/MQVp2hnLiDnQOjP8xKy0aAG7PUdy8VUBmb+r+5daZFjP6OuZT8GG6GaXQyUzXqYpxMcHPvT+FSXrOYhLODuzJLnLJPj4LKY8XmcFlFSUz/g6GkUT+jRL+/zUGtCBfajRh2nKiddIpuNF3rmELDapPGqnJHn3y5CnJnSsOqQLFW6CrKuEyq4vSRz+gOLxKmZ+gcvcIAezOPaEgAA0XsQbObT+pkGeuXqEaikSwl9BwB1qvE7hwyT72pIvMZ6zhe084mYtFTlZd5AqGSOFIDkwn8Hb0RP709TL58mcTcSeSy+Pq2WrVJ62wynlaVAia23eYV0jVBsHKPv6rTxVdfG43SOTzZpuYxekqAzufDJQA2Z0wuA1i3CKv8Myeo+1A13nN3OZaWfJ2fkG5gZxad3o9nUL4r7VADgy5Y3rRJynp+Ae2l8bNmlGYkwKd4iMNT2wTiAoa2/TRRMF4BBqTmD1UgPTWAfsfQotePGyHgsmU3m0BdgAY3xmfV6O+qPFIpJxbWeVSEYMCgURIWNv33vrZWyn+w1oxxyuUX3rMVjQ2Cl7SwuAn1v6xpc/Cb+NjNwEeyD1NxZSkbXWpnL1If+9G8zCUdewDoC2bnTxFGZ7cM2UwIbi40nxVSzQvCj1m/wGwDHP1kkSg0ibQH0+g9LeoeAuuuLWmC5BZiVpc9rmui3E2AV3nHJjebqo7n4N9fmkbXVHa83ZLBYL1ZJPzRJ33vkrMew4U+828Zd60T6hlsK9ylKlqoBoxqOQZJdkoLwTU+LgCswOUBpy+GQskw4JKO+d3kW4pJ4oJnsgtUULZSosS9b5ZabfDlO9XVDfJgtENIoGnd4VR6YnF7F8NsZmJhkDUQ7yelRig9xLJYq3p6ycTfeJHBbdq0bbpsXXBplVhyegCNOwHvVQ7rbhS57El5zZWe+0HE08yLozpMK7SCwG1Qb7NVda597kTEOOi3ZK4IZ7xs1T /gRm6mRZ PWvAc4ozWuuuQ+2c7+UPQFUTzpt4rwxjxHA4y5azxGZiaIBAy6tfPcmkZ4Yqzmi/773FEPZfwPbz6v0Eo7GdRHYHFvh5dIRyrpCsU0ItnGB2l5qLMNKx24GzAgVHDn7L9y5yS7w1EEXD5hazFRZFN3yzUHD03EF17PjlXXnJVYA6owEIMiC4dcVWjIQmZnxjN4NyaS9Z3bhX9aispWL5wiiFuq9MVWgdtY+N2tDZLNWinQbbb0oE3vPj5wkkLFnEcmxuVvKoWlUuGvx2BHqPvOTs8lxV9e60Ahp3koKRTsazwN2OBvyDX8d+CyNsMvDW8ev7vWvxiWjNmRCiSXg9RLAjq4lpLvDZaQdzrtpmLhS9a8RzmRNWbxq9iVm5CDb7VwqRxkw/WRVL1UntQahtaMYxh7JVKg4lf4NiG7aD5GbeXGpOYDW438Bt30kQH/FHtpi/7ck6kFnvCLPmafmzqUwBihnqIA4vwngV1tYwslACVU9d2WIjLoMR1w21TCIWFkuPyUHryb9WwuKV0jmSvR0pBj3Qkp8mPSOr3wilGOiv5QLVZcZvnGAK+xN4hxRKe0SA+ObfldRMr63mYQAwpbIQOjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 10, 2024 at 09:51:21AM +0200, Christophe Leroy wrote: > Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related > issues") added pud_user() in include/asm-generic/pgtable-nopmd.h > > But pud_user() only exists on ARM64 and RISCV and is not expected > by any part of MM. > > Add the missing definition in arch/riscv/include/asm/pgtable-32.h > and remove it from asm-generic/pgtable-nopmd.h > > Signed-off-by: Christophe Leroy I assume you double checked the riscv cross-builds on both 32/64. It looks correct: Reviewed-by: Peter Xu -- Peter Xu