From: Peter Xu <peterx@redhat.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
linux-riscv@lists.infradead.org,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v2 2/3] mm: Remove pud_user() from asm-generic/pgtable-nopmd.h
Date: Wed, 10 Jul 2024 10:45:48 -0400 [thread overview]
Message-ID: <Zo6enCwreppncIel@x1n> (raw)
In-Reply-To: <c31a39463929daba6c91917598ec05cf47103af5.1720597744.git.christophe.leroy@csgroup.eu>
On Wed, Jul 10, 2024 at 09:51:21AM +0200, Christophe Leroy wrote:
> Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related
> issues") added pud_user() in include/asm-generic/pgtable-nopmd.h
>
> But pud_user() only exists on ARM64 and RISCV and is not expected
> by any part of MM.
>
> Add the missing definition in arch/riscv/include/asm/pgtable-32.h
> and remove it from asm-generic/pgtable-nopmd.h
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
I assume you double checked the riscv cross-builds on both 32/64. It looks
correct:
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2024-07-10 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 7:51 [PATCH v2 1/3] arch/x86: Drop own definition of pgd,p4d_leaf Christophe Leroy
2024-07-10 7:51 ` [PATCH v2 2/3] mm: Remove pud_user() from asm-generic/pgtable-nopmd.h Christophe Leroy
2024-07-10 14:45 ` Peter Xu [this message]
2024-07-11 4:41 ` Oscar Salvador
2024-07-10 7:51 ` [PATCH v2 3/3] mm: Add p{g/4}d_leaf() in asm-generic/pgtable-nop{4/u}d.h Christophe Leroy
2024-07-10 14:46 ` Peter Xu
2024-07-10 14:54 ` LEROY Christophe
2024-07-10 18:41 ` Peter Xu
2024-07-11 13:40 ` LEROY Christophe
2024-07-11 15:08 ` Peter Xu
2024-07-10 14:43 ` [PATCH v2 1/3] arch/x86: Drop own definition of pgd,p4d_leaf Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo6enCwreppncIel@x1n \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=osalvador@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox