From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB2FC3DA42 for ; Wed, 10 Jul 2024 14:46:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42F286B009F; Wed, 10 Jul 2024 10:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DF996B00A0; Wed, 10 Jul 2024 10:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A7806B00A1; Wed, 10 Jul 2024 10:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07AE16B009F for ; Wed, 10 Jul 2024 10:46:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A1DA2A50FF for ; Wed, 10 Jul 2024 14:46:53 +0000 (UTC) X-FDA: 82324119906.10.BC69D9D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 91273140013 for ; Wed, 10 Jul 2024 14:46:51 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BPLa9Qtt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720622776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0B/GOXyDiDPobMKu9T39XhvhD9Emiwu5J8K0qpzzRbA=; b=4qtkFE6HM+q9ZHZ4ddzfyyIgAWTESMebkQhl+p3qhcGZpri6h1pMbqjLxnhFG7OIFWepO/ xjznGH0wAEklNib64kS1ilaCpb22O/Rnl3eL6pGa4u+AcZ81oxIA/gRLprxJEiylKykmu7 ikOiIGdxqcIBjQ3qaVWLWUqMW8ORwbI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720622776; a=rsa-sha256; cv=none; b=Wvw66r2mMucncb2UhGhbqwYr6Wc0G3QPWKvZ1K84F/kpQcuhZYPtzuBjWRqURw+Nc3C4WW mra/gNvBID2heJOY7AaeMT2W8sLuHUV+HPRiwQFs2CA5TpH4oEwwgI5/ij//H0D0MCn1U1 plsafhnE4/yOWLjmaD5rK5rVh3bt//A= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BPLa9Qtt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720622810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0B/GOXyDiDPobMKu9T39XhvhD9Emiwu5J8K0qpzzRbA=; b=BPLa9QttuFtqMsriqqOpskLynFVQKlGWVcDvIGOdOSYPW4ZKdWvIXDGf5iXvWZaZ/sg/q2 oHIrTU29nhPms6uBgMrTOsNsZf1EoGhCH+oMwWHlqnuL0r9sGyC/bPmGU6/U2T5S1idtYH nrH4umaurnGmIhxs3fZkZQk14Dpq2Gw= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-TdIviTlVMYC6E4RmRbN1mw-1; Wed, 10 Jul 2024 10:46:47 -0400 X-MC-Unique: TdIviTlVMYC6E4RmRbN1mw-1 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-2502a80477bso1376501fac.1 for ; Wed, 10 Jul 2024 07:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720622806; x=1721227606; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0B/GOXyDiDPobMKu9T39XhvhD9Emiwu5J8K0qpzzRbA=; b=n/cHr9rY0t7TsJevjDOMhHMVKoArgF8/LhnzJBwcyNHNgPB9qyoITHoexMvuwxJPTp g7iFLG5UuLbrKC6Vad9wLP6MD96ozPDBAsy2kjifd9Mw2XXGtlmTLmpSNNMkw2yx2S5v iYp5KJmf3xD+8flWA+p2lVLGsoj8SyXDtQiswfglLMl05XUx5LUghSlXA241PBiNqWvg VMUa8pgAcPHODq8VyQAvgOEXujtFFrJ/WBGpPTOA1ilxIjb1RixDpUU8OeiPEoixsJsc DKRzO0sdpcbYSLkZTibDKuG7tcObGnrGAt5Rr73yywdnQxSDYLDnEK9GBTyKCePWzrlM 2sAQ== X-Forwarded-Encrypted: i=1; AJvYcCUdhra4TTvrSPqIsJHALDduVk/vS2g1JBEqQOAalE0UOFW8rI8UjTEEZdygf7nG6lNWCN70+bX5+fjx8hUNN18Zod0= X-Gm-Message-State: AOJu0YxqLPxHgvs0opuzLxCM5K5M/q9H3XmzfFvtTTPFFDfRJhdIHLr6 EHQo2qv++YqFU7lOVv8hcvA02fubGgfuFYEx5ihbzy09vV1zBclZ5NieVZ53lQfVY//5LrltHRq zxHmoURLdbFPIVOfxdTAsFrappOcEiAG1u3rtW8vXjVaEK/vK X-Received: by 2002:a05:6358:7e14:b0:1aa:b631:bb2b with SMTP id e5c5f4694b2df-1aade07845emr713969255d.1.1720622806517; Wed, 10 Jul 2024 07:46:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0y9zwD/aGVYQuTTBcTiddjmn7jGBDMebvGdtIe8mQ9GpJ1Q6oiwz8/EvOQSuu1JQaMwDGBQ== X-Received: by 2002:a05:6358:7e14:b0:1aa:b631:bb2b with SMTP id e5c5f4694b2df-1aade07845emr713966455d.1.1720622806155; Wed, 10 Jul 2024 07:46:46 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b61baa257esm17481816d6.146.2024.07.10.07.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 07:46:45 -0700 (PDT) Date: Wed, 10 Jul 2024 10:46:44 -0400 From: Peter Xu To: Christophe Leroy Cc: Andrew Morton , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-riscv@lists.infradead.org, Oscar Salvador Subject: Re: [PATCH v2 3/3] mm: Add p{g/4}d_leaf() in asm-generic/pgtable-nop{4/u}d.h Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 91273140013 X-Stat-Signature: 4995xca19qr767sgj3y5tnr87wkbfk6o X-Rspam-User: X-HE-Tag: 1720622811-141579 X-HE-Meta: U2FsdGVkX1/zrYE5QghjQ4eL+5twsZNztb+l+8y8hCTKiYr9d6s4RkOdOEfqZfMeiou0ZugynPsJbmywpqH+KW/gW0D81birOJeuOCh7mF7MhRpOWv8i9XW9V75zNSf/EvLv2JYgRRv9KQHjdsuWFOz6kd8EYKAItQkqAD6FuGbjH4/lGhHfd4aqvkTv11GWy6/vNirINsuqfYRBhlbBq5vn0MFKzhYf9z6cIXtlKzuOosoShyGLgybg8iqmb2Xo8NfModO47e+/UI2rSKy4ba2krkEJp09ylIq2RNiGmBF5hagCj4gnizWLZ8DYaT+ZK+loZU9HtUBMDyMzaIa5CnK9CCgOffG2aYzvBB4rqyK1l3uBU5o2ImKo0+JruLm+QDcVDkNqgWJz4LiqmeMAJnC1Kdzvn3wgiXyZK2jW2OI+sCcx8mgloasQI4mrCYbYIm+ftlE8KLlKw+P/YaFJTy6EdSXTmwlyufpA+F1OukmVLAsBTMJHwvZyNMxeIEimsTsjNQdF+hrRuAruPnRmPRSZ+VbHurCoUXewutcMsHZtXvmMrF681lS7Y1Lt20Iu/TCQd5nTxEG/8izkVYgtQyoR2F3SxW6wn6wXpOXMyH5mhwgOPG3VoRaBl/+FXxCDZbV9GkGYxwIUxqIDlT/u9ob5xPqXH6OTxONCJ65iAmjGnYseCAwcI1/Z81Nae9pbP1SgqmOqWIvBBoXelsKJMzKHilrmdrdFozjr/iTCWAKhOPs/3sswl+BemovoPI4Sb43BMY73mq4hFsDlM16bXFR1Onz5aQWZXPVB66vBznuue6jEcQzqT613mxAzxB0zP6jz5dXTbAO4/1HpIUd4zHyr/I5CPsjWm47Xvzk5yREj5y7e9wFSsnZXwH+Mufbn+6U7vxr2Syy31850rwQQr9Rs8J12okqFNZOlg3Of64UfMPlYkBQMX5HgfO/y34Wh3ghqaz+nUJrvD7pesjI d+ZVDgbf SY/4/fiWFXZ94E1KMNRXpfTvCECb+Aa54cndo6CMLMO1xiV4N1FWsRuMBSlabqsz+YkkeyuWa08pdIHeosWBWJOOHMhrMDjsE5eGYhohjAH7GgvPFL/sXVvESmVgHStZhzkzbRp2RB6PWFkngcEdwa3/CiIIANgql9UWuKXaRw9oKsYIVihmuHmua3UXtN3MDyLIdd6Uc9fKDzQK5ROs2hktgp6GJrd82KmM42RmbaE6HHdUxIMlyArrdeYNDaaytpnpoNfxF/mJid0d2a41cFoH5SUkg1iLULx7DPke7Akaw6ZF3BmAQ3pX56wIv6IE/vPFmA9UzsSug/NOBtiSARE+bOzL7LAsJidza1YwmQ1/BU9pirakseaEj71DeOuUrN+pEj4+oZq3AEGgC0pPz5avDae+XdHiTgom9SMG2JlExGr2kdIXIJ5zqB0npLGotQH0JGHpN1ajExPj0n79IWQ106TZu5uw0F2J7uEP4jtIdxqCFY6F2tctSaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 10, 2024 at 09:51:22AM +0200, Christophe Leroy wrote: > Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related > issues") added pud_leaf() in include/asm-generic/pgtable-nopmd.h > > Do the same for p4d_leaf() and pgd_leaf() to avoid getting them > erroneously defined by architectures that do not implement the > related page level. > > Signed-off-by: Christophe Leroy > --- > v2: Added pXd_leaf macro as well in asm-generic/pgtable-nopXd.h to cohabit with the fallback > --- Thanks. I'd drop the inline functions, but no strong opinions. Reviewed-by: Peter Xu -- Peter Xu