From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457E9C3DA41 for ; Wed, 10 Jul 2024 03:03:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D40C86B009E; Tue, 9 Jul 2024 23:03:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEFFF6B009F; Tue, 9 Jul 2024 23:03:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B919C6B00A0; Tue, 9 Jul 2024 23:03:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 984C66B009E for ; Tue, 9 Jul 2024 23:03:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1B9BC81AA0 for ; Wed, 10 Jul 2024 03:03:50 +0000 (UTC) X-FDA: 82322348220.30.EBE3BE1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 0211712000C for ; Wed, 10 Jul 2024 03:03:47 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Nc9HF4+F; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720580593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4QCXCz0zQ+WlrfEgvyLBZrRzTFdgqTlxMzUM+AKRzos=; b=lgooWj0OmAFraSLk+K62yrsr7fWcXddEd2KS/KQf7xPE7f4UiHG4/d4TWGptWfD+RcD89K Hoyvl6VFOSui38/mdmZL3tRbw1QQWae9vY3nb79Il0d+UGyrI5F1s4VUk4APbglZ6+npuy 4NqT1TeuLP159yi97h989jzL7XesNY8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720580593; a=rsa-sha256; cv=none; b=D7GWc2/ovczJBZSn/uxtqDn70McN1//mTeALvg7Y62rQTjuQYfaNT3r259qJeCZk7jgcww M6zZF+CKZmR0be3wSSdXkkHCjyAzrWttI+z+UsCnf1c0MLRkC9smd6gHv5O8yhawm22R2C +bq5ag9ijcn8y/LutNXaGIjbRywVDQE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Nc9HF4+F; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4QCXCz0zQ+WlrfEgvyLBZrRzTFdgqTlxMzUM+AKRzos=; b=Nc9HF4+FeXLRBKeWwJ8dE4sC+4 pTatc1wxGhT87C4gpQ7rzONyvrF+NJLuI382zUE0PHOO5RBDRaAeI7+NUbheXCZ8/MNI/pFVbwoLC +5+GT4rp1r6a8iZzRQ3H+eghUm9KMaiBhWgJRJ6yJKgTJUjNruYHo2AVqbjbqxL0V31YOjrQn9GXV 5DlqZL5vh8X+C1i2jykhPQCpyHWd8OzfSbIuItSotjcqN3Z+ARVkw19rMZLNTb6DxatIe6cCel1Ux qOpwXAF7Tt2VvE6XEb+YeuvfJfGS4Q8NIMh+lkcaBEpQcN5z3RlVKZohWehUTb8qgXB8tVeUubGSc ajXN6tCw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRNcD-00000008drV-0f3I; Wed, 10 Jul 2024 03:03:33 +0000 Date: Wed, 10 Jul 2024 04:03:33 +0100 From: Matthew Wilcox To: sxwjean@me.com Cc: vbabka@suse.cz, surenb@google.com, cl@linux.co, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, xiongwei.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot , Nathan Chancellor , llvm@lists.linux.dev, Nick Desaulniers Subject: Re: [PATCH] mm/slub: quiet the clang warning with -Wunused-function enabled Message-ID: References: <20240710025418.394321-1-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240710025418.394321-1-sxwjean@me.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0211712000C X-Stat-Signature: xcgh3aux7epkni5to3j9kaehm6rxjjcs X-Rspam-User: X-HE-Tag: 1720580627-337677 X-HE-Meta: U2FsdGVkX1+FjBEOok6nOQ292bim09hj8/Hc4hfpg/HkiFAF6xYxf3EXNpx/e93jWQhNxL8jSLPj6gQIcA5lCqLhRqi52bE6XxM6565lkLWsq7//06N16BYTIc3E5PRz8y403aBZKTS8/wsMXKj5i6uezzuWCvdpsGdVDhSjDvxf99OIO0GtrV0B3gNuuD/xu0XLtSdBKkuggGXV+6e0q30akulG7ybm2u/bQ0pfmSyw4R1Xf05sD3E78f+OHqcf74p/hCaL3D+c235N/jgNwrYVv9ixsRpl/XRkM6U+uYzRbTWzb6nfNSgrCkMvDFdMnJDY27thGeg/Vem7m417JaDFjx7SHcxtrqTmfIH5Op9hfToWOhsc/iO3+tK24eLfY3zJRpX3ebzzFKf83RpirKC/BKOKl/s7nA73zyudncg5cXu9kb7t3QadrgXTK3R2JIa/0RWMGuvmaAltqEC/GRd5KzRxX3vWqrjyH3WKI0nRF3Jhpu4bDFpasS7KOW4eY6URfr8fVxFUAs3P1Ll6+QYoQJJ9ekKY0ljqFYTqXzMDJc6D9R+FpOk8UMGgxPK0Ov4BBZk5FrbqcvOeJCOBcERbITRLDCYiH5Pb765P/UU1RnTRt6dVHx/CEm51yBPdkG7nvmgElR3rkQvsMmM5ZFENNT/ZAOaWcu7iQTUWcEZkgG2X1ESI0RE95GusdGjdMhRKG2VA/4GEah5Du9g4na1YM6pwA9nIt1uTc0HBCcBd8XQmRP5E4W0lq58ifj9P3/KdyO9MF+IviswezU7e3B1QQxE4VI6rS/6wVaDIDIJIGqU6pK/cC3rt3Yx9zrFr16wbPAssaW/tPWaOhP3P/v29CqSIOFOt4LT+DQuJo8gntsDpM1lPv3DjpKgEKucss3HxVb4DjlzLVUdkFjh24zJGOUtQCyyJ/PohXJ83o96K5LwG1RRYYlaptFlZKeigkBWU1SahXaKV5n/zly+ jGRBDMLF NxLMSK/UA9j/NUxeZFlsJmCPYmWeZ/VtYrGwns2QNT38KufU56wIj8hVd+qwQjY3edMVn9EZRA+K4jUzHTEzuhuIABuU+wcAPVkXAXl+9P6jSGh5VFAnyZD4Vzc5GJvWoP0ynmsJV+O5uCQ2g4wpt2j9TC8jKI6RyBeaCclLtOHCTCo23Eumfp28/oFZQbxI0NKZZUJHWyDVMBQ35CXUPPqV3wDRc4ivA7Zgpq4i6q1YR7db9vDzGvfON43qkYH9aGB1yxEnUxuUnHDFqStW7bispQR5A1dNZ+zYFKn6mDG40+VnqPVewAZs5NqwCWLeh/mqxEcktaODGGYH4kvJztmmId1U7ue1oTT89RBZFfOeb5Ohi/7XFImWZbP6O5J+1dYL8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 10, 2024 at 10:54:18AM +0800, sxwjean@me.com wrote: > From: Xiongwei Song > > The only user of prepare_slab_obj_exts_hook() is > alloc_tagging_slab_alloc_hook(), which can build with > CONFIG_MEM_ALLOC_PROFILING enabled. So, the warning was triggerred > when disabling CONFIG_MEM_ALLOC_PROFILING. Let's add "__maybe_unused" > for prepare_slab_obj_exts_hook(). Perhaps instead clang can be fixed to match gcc's behaviour? > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202407050845.zNONqauD-lkp@intel.com/ > Signed-off-by: Xiongwei Song > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index ce39544acf7c..2e26f20759c0 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2027,7 +2027,7 @@ static inline bool need_slab_obj_ext(void) > return false; > } > > -static inline struct slabobj_ext * > +static inline struct slabobj_ext * __maybe_unused > prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > { > struct slab *slab; > @@ -2068,7 +2068,7 @@ static inline bool need_slab_obj_ext(void) > return false; > } > > -static inline struct slabobj_ext * > +static inline struct slabobj_ext * __maybe_unused > prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > { > return NULL; > -- > 2.34.1 > >