From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A150C2BD09 for ; Tue, 9 Jul 2024 14:34:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14EA16B00A6; Tue, 9 Jul 2024 10:34:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FF696B00B0; Tue, 9 Jul 2024 10:34:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F30086B00B1; Tue, 9 Jul 2024 10:34:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5CE06B00A6 for ; Tue, 9 Jul 2024 10:34:58 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 467AA41990 for ; Tue, 9 Jul 2024 14:34:58 +0000 (UTC) X-FDA: 82320461076.03.9B8F887 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 09C028003A for ; Tue, 9 Jul 2024 14:34:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PNUrmg7m; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720535662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ixPgUW2T4tXOs4aEeHspyZiL/y/SECkwdKfsz5YppK4=; b=7Rx2QlJXNUhe0EdPKZWisGNQp8nroTUbi46s6dUhm4j6LGqPeUQWY6uCTM2G3HZQJDwoBo 1J3HvKa1xyn8CL3BAGbkftqsYJ1eHVKlkeL0/ELxpxRxsn+drcTrWWXn7dgqOKQY+vuKz+ yxWqfGiqGhyP21K0KH6UWQh4pK9iIp4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720535662; a=rsa-sha256; cv=none; b=MahvTrgkZSGe6ceeFnTX8lCzibKh6cxF4q2jG7e8qK5yGAFTd6LtPdvzjoJvZjpemH5zBM Tn5lpJj5jhSIJGdgEs/Iyib/ZGn5xioGXqjShrIaS/5t0kXpEG52IyexZ1MYORjl24WUoc 8hYceMWtwzSJW0b6crsMri2jpj6wtTU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PNUrmg7m; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ixPgUW2T4tXOs4aEeHspyZiL/y/SECkwdKfsz5YppK4=; b=PNUrmg7mTfVTPtsWmgtYB0RtCI +0LDV8xLaeQqGA+Onn0WbeqUWiGg7uGpTH/ImPKzJTsINKGRYlZIx9HD0o44/VxeTB0j4Rs+orUbP cB1qDdU2/yQXaeWbbAU38nphaqTuvUAKvbWg280ejLpZTi7CNmuJq3VzJJTYk3gUxkdjnvHe2Nhnh tiVmqeesgVndidkl4CeZB3DCsIJhmZEJ8MjdO2fHos4KZOKsNEnf1sfJ1yMpsttUwZYrO+q+jK1RS iVd1vzsx26M49iVtGAxosJFOR5k1iLNuQYOMUfO1lz//PqchV/ohqFWZQ+zi5qMow2ILOxaeV0OFJ nfOWqBNA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRBve-00000007yWA-0o2O; Tue, 09 Jul 2024 14:34:50 +0000 Date: Tue, 9 Jul 2024 15:34:50 +0100 From: Matthew Wilcox To: Martin Oliveira Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org, Andrew Morton , Artemy Kovalyov , Greg Kroah-Hartman , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: Re: [PATCH v4 1/3] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: References: <20240708165714.3401377-1-martin.oliveira@eideticom.com> <20240708165714.3401377-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240708165714.3401377-2-martin.oliveira@eideticom.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 09C028003A X-Stat-Signature: q45ikxshh4m198doacwwskgxxjy4nj63 X-Rspam-User: X-HE-Tag: 1720535695-912393 X-HE-Meta: U2FsdGVkX1+gC5GLLdSLVT5lS4FUKKwVWcrgwHsj5mN7C1yMqn7PAwtuwlR9TPxzEy+M2nlojnpTBUxmh71W96KijxW/GSsPmkEhx1SaX0RO3IzPqu1JgyDpbC361Nfs7Zhq81jp3g3DKNUj+oc4eFVNIjfevd99d4dYq8+YzxhBd6HqAIZYjxDBE34tGBGWbNviCzL6rDzGWsSgM1qt+E5IMmi2KceY5572Jy271Udfi0i3g+81HpP9CW+bjH/JfBete/mrM40qQsS29gem70lp0lsi/w4FPeV+4tOGocGQAmNulO54nvwRr5IPKUFe/G5ASti6lil8bA13lwO6s2Ps020Ev2yNX04ztkpl15294xswZAAoNgTRzvfMMxB57AQI4VDJDDSKWsvfnpZsmjICwkm3EWqq8gTlui9xjf3sRcG/aPrdCa7FxavG9M7HARYPXeteI2NDCQXek+/slIWy5ia2JE03XfNHbUbQ4sFaKKx9mhq2YL+WMRvn3wyj9KCNkhc/F2056zjKPZK9eStEzzjM9+47PLbNTzrPf0A4HOBGL1edFJc/XtzAskW9H9gMgpEu0V8ihmNvdl2LkDt+qPldBrzvLLLBsm+DA15mY1y3AvHs6dNQogalcJ1IiuJ43qKUbhdMiumeP1FyRDUFb55ri4FJPAlM0VO74javqsZXGLOEuC88yJQox+G9yXkR08lZH3yuNkJgm+jJMOVUf2yFem9B1J9DJY2N3cQ4cofGLqTq4YUDmj6gtHzCYLgxC8atvk63d7aBGBGRQzlgyH21g4iPUbx2CzCRFqI8ooqMQ/qPwQLSgz4u/w07cAWSzfsMxMepk1Y0VC4tCyy/dlxziz4J5bCW+t+irr+3mvPrfWaVTUKSvBIJ0MblFgLkXhxqT8zb2z5oGVuNXYCIUdgmmH4F9YVyE3OMDTDpU345C4SSL0Fcc9J97B3KCIlRkZDL/Ix1I9lm5kd ri8bENHU V72Y3RLt8lL8y5Pb1c8qtDhcnXYT4V/OdoriYfzPOuD1ce35bKCHb34DEgLXWzGbl1keeRiuf+6ViaO5hRJpRG62bIqYYlCTXbWvjn5u/GfPL0+l6koLRCFcMz8zemfnQ3oHyzXnhdS9ipQZejvxvSQGYy+Gdn65MGH9e193zJo+cDR4pufxBh5YB/YQbNRpny6xGKKvjbWtQTQUuO1P/wKWwUAv7NDs4zxBW56UuLiRyT6qni+uKsgcb5bSW1/RzJcwx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 10:57:12AM -0600, Martin Oliveira wrote: > - /* > - * It is not possible to successfully wrap close. > - * So error if someone is trying to use close. > - */ > - if (vma->vm_ops && vma->vm_ops->close) > - goto out_put; > + if (vma->vm_ops) { > + /* > + * It is not possible to successfully wrap close. > + * So error if someone is trying to use close. > + */ > + if (vma->vm_ops->close) > + goto out_put; > + > + if (WARN_ON_ONCE(vma->vm_ops->page_mkwrite)) > + goto out_put; > + } This is stupid. Warn for both or neither.