From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F129CC2BD09 for ; Tue, 9 Jul 2024 11:56:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E22E6B009A; Tue, 9 Jul 2024 07:56:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 591606B009E; Tue, 9 Jul 2024 07:56:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4801F6B00A2; Tue, 9 Jul 2024 07:56:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2A9846B009A for ; Tue, 9 Jul 2024 07:56:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 87D3B140681 for ; Tue, 9 Jul 2024 11:56:31 +0000 (UTC) X-FDA: 82320061782.22.19DCAC3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id E8B4E40017 for ; Tue, 9 Jul 2024 11:56:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O+qQlcWk; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720526155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DM2BJZhMwpSGyN9OWrMu8sRkPGKjHUKKFKcsWq3B1IM=; b=SidoZmIsIpk6NyDt8NhGgV6rVFtaVKdhTEpE+UC4It9nmdHMQzqtqmhQP8BecAWaQ9c2VQ EB0mnRSJpGKtZNchiL6rFFbTgCERTRlQEOf+zI0SgyWgan7IkNXE9IJVWymJsC4Em2C9Fl fgGQtS8ckTctohCQNBMOmrXQPqZWgnM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720526155; a=rsa-sha256; cv=none; b=lvQfVCXksfBAGJNBsi9Yi97+qMxtRlhTzNsGG1GItkbwmG6dMI3aeF9I2WWDOqHyBzRbw+ I96NKN3p49I81MKMzsfRqaNCcYY8pTMnvuSGc51DGpL+FxkDoHcfiUXDiyIZs+sDS0sxYg QHfy1i/PiOZn0wwImEJi06RsDpynGmc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O+qQlcWk; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DM2BJZhMwpSGyN9OWrMu8sRkPGKjHUKKFKcsWq3B1IM=; b=O+qQlcWkHhpdiCu28MICATUe9d bQ6RT7qME0tQ4icGRjZFmadItFADo2d3G2To8jmyU/GZaKopzm4Lyq9zjrI2zNxacc8tIC66ezz8e 9Mmn2VQw18elmoAbXO+Mpp+4tt5IY9yS64WBWv5FbsGLLQXkGoYuogi8mYipFkpOEpSHBDZiKnTHL jjUkHzFsSsgDUBTJfFxZZa4rIv4wmJeA6ZQPIVE/Ki/DGsR1Gucmr1bPuS5fscCcD9T4CWuf8FsHt OENGz0EH2qi56BjWNnAJ1Toh7s07y2Cz4J7UBdsGnZypUju9GaFTE6hU5mCmseM8i6wzXOPLAxXwR K0f4GYbQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR9SK-00000007rBZ-2Ipo; Tue, 09 Jul 2024 11:56:24 +0000 Date: Tue, 9 Jul 2024 12:56:24 +0100 From: Matthew Wilcox To: zhangchun Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jiaoxupo@h3c.com, zhang.zhengming@h3c.com, zhang.zhansheng@h3c.com, shaohaojize@126.com Subject: Re: [PATCH] mm: Give kmap_lock =?utf-8?Q?b?= =?utf-8?Q?efore_call_flush=5Ftlb=5Fkernel=5Frang=EF=BC=8Cavoi?= =?utf-8?Q?d?= kmap_high deadlock. Message-ID: References: <1720516658-50434-1-git-send-email-zhang.chuna@h3c.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1720516658-50434-1-git-send-email-zhang.chuna@h3c.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E8B4E40017 X-Stat-Signature: x8utpayp3pzb4zf5sqiimqkmj831j64p X-Rspam-User: X-HE-Tag: 1720526189-437942 X-HE-Meta: U2FsdGVkX1/Qho85xvD2pDDqoRCVmdTrrDtRtc67ki7aGazyeB9Gwe+XRhszNC041ZvPa4MRg8mt75x2IFveP6ywqtytrtljsIXE810CwY7ae/6BBB440yZJ0MK1qTwgXGgvEj2EcbVrhEO66VTYZx50I4iZYVTaKqT0defhJYd51z4KWwXHa72SX1yJeSt1rcbdv+BV/7M8BmPwW+zpv8DWQwpx4QZXbR6DAtTFiO5OSurMBLY119DI0+yZXWBw+o6F8XYQ7tg2S3NAt8eKIU+HeXmPbYLdAmT5g0Z5Fl8VWYzCTErzAK1T1CHHvKW1AHzi0SG6H74H+Y8WSnyCQ1uRYb/2NU8snBqDMb7P8BI1xnZHhuWrWFNl+XuhxMvGR+L05wLMqY2nSuwFB7y8XwbWxRUV6BI/IAlbA480KFtC8/thCXYttaipWT6Kqa/3z/5CGtHigrgCOuZzMaqvGtbYO/KWWqCMWOIsh0u6WNnoTswzw60MnhxwoVpni3l6JTjIV3xLlDvAZgd5z8kMZgOzxlapYJA44VWjyZEly7rQe7ZiFuYnw+oF5kKZXwjx7pwDc4aAOVeocIzivfX27OdQ+NaOuayY5HMsZ4YnZQ1Q9fyq5TFAK/LIdyubSuslBsEWNpiplM3iDmBDLmXyPB8vLDtePhIIxZWe9bXBSHYVVbN2vI7csx6Le5ozxbkf7b0E//Cva98fkmVg745sd0cCbEX9DQo6FRI0aKGQY2aXgy5y02222Hp/wZ33yRq1WSxRpYgdrObG7RONwObNvy+4CDZXG3rQ+ASx1j5bFd6/SwBopw2PYZkTVvTR4+22oh3tGA8XaFCJB/r5zdVGPXVewFZpN/DD4hrdi370bqmZYB9bXm2r5Deie7faWutHUk0n3Xbd9I7QfF6b6d84yPz4b34iS/9n+wDHax5YDyFpeBsb/DINR8+912uMTx4Iw8YFzoLNojazcAQefqU NZltwGNy OamWkZvpK81JNqzCt9BxG+JAoIncuvkMmkCDcFUz941+6sG21q4mjSVaJccFMqBpGtXemK6Chvl+8VyhSfaWsqxmR3rpuAtMcV6JhCoCTahaxEwJSWyvSQWNgB3fONP5QImQ1z2Q1PgWi5OA8ktyyULhGSY66oI74w4FxWx4aavvET202I0AI3OJio05R4cTs6ilD8MafVJuIKm/ub5zrq5mJuNNPj593OwdAWiKHS6Jh5gCHpfDZYljxwBnywgh0Ddp8Zf8oYXg0puKm55yuiuh4JA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 05:17:38PM +0800, zhangchun wrote: > +++ b/mm/highmem.c > @@ -220,8 +220,11 @@ static void flush_all_zero_pkmaps(void) > set_page_address(page, NULL); > need_flush = 1; > } > - if (need_flush) > + if (need_flush) { > + spin_unlock(&kmap_lock); should this be a raw spin_unlock(), or should it be unlock_kmap()? ie when ARCH_NEEDS_KMAP_HIGH_GET is set, do we also need to re-enable interrupts here? > flush_tlb_kernel_range(PKMAP_ADDR(0), PKMAP_ADDR(LAST_PKMAP)); > + spin_lock(&kmap_lock); > + } > } > > void __kmap_flush_unused(void) > -- > 1.8.3.1 > >