From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F45C2BD09 for ; Tue, 9 Jul 2024 11:49:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0BF86B00A2; Tue, 9 Jul 2024 07:49:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A94986B00A4; Tue, 9 Jul 2024 07:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 935666B00A5; Tue, 9 Jul 2024 07:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7110D6B00A2 for ; Tue, 9 Jul 2024 07:49:22 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF33F41864 for ; Tue, 9 Jul 2024 11:49:21 +0000 (UTC) X-FDA: 82320043722.09.ADBC086 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 89EDFA0028 for ; Tue, 9 Jul 2024 11:49:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZGnHNt5h; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720525730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ftO62zkTRGepQ472ogpI/abRci0PI4RVGd3poJ2gXkE=; b=D2kGajf+hjDweVkoSZ3UP0LxFPm7VSYjOASNhVz5boBjKxQoexd7vj/gw3Ihs8B2gobIxF um4p3O2eWu4AF2fy9r5k9yC/E7zrrRMbT8mEp8VcnA0fwR+k0uLWSKgVQfd3Z2dysQ9/F7 EXMjNPMufJnm+xB+LvSWj+PH9CnfYzo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720525730; a=rsa-sha256; cv=none; b=AVRD3jXKZB3LziTIF+qDqVb9Q468iLw8DnAY5KL6fu4wwuqrZqgSmAd78t1MxhvYOKmGpD gnCnEkDO+GxtlLNA86TjannjG3u+nfEQfomWPhmFPbHndDpAmSvTvKh3SqOTb/exwr0E4U f7+tpW0T+pAH1ukv5opjbZx5WYuUI3Q= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZGnHNt5h; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ftO62zkTRGepQ472ogpI/abRci0PI4RVGd3poJ2gXkE=; b=ZGnHNt5hWtIFNrgI8eAaxLFxhf 0j/Ra0y2N3IFAfURpRGuJn+AS7sT0PaW0+xzZ7kwr/V6q79ICWmugmncQmVPuSjsIJGma7XE9Hmlx rTWV9Mk9Md70olJCxliyeCb/KGuklBuIPjrI01Wl+o+F1hVlA+GcbHQYeqURZhOdwEljW0wUwqMQD h2uwCcQuHs1riHx7A/8uF7kLJymGKbyhdTIAZS3VRyeedbERb29LPKyBZmPr8KroHx5fR4B8305HV rLykTaSouoPhCsMHFf8KD8FafSkedkgRtCm+AWixaMiVpljfErZ2+FG/7dBm9B8Hn4ZjHlQJxARg4 dCY42w0A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR9LP-00000007qvl-2c3Y; Tue, 09 Jul 2024 11:49:15 +0000 Date: Tue, 9 Jul 2024 12:49:15 +0100 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , David Hildenbrand , opensource.kernel@vivo.com Subject: Re: [PATCH v6] mm: shrink skip folio mapped by an exiting process Message-ID: References: <20240709041050.619-1-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240709041050.619-1-justinjiang@vivo.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 89EDFA0028 X-Stat-Signature: n65zzkqkztwgrpc19zghigsbqyi76g4r X-HE-Tag: 1720525759-2166 X-HE-Meta: U2FsdGVkX1/+ZU0Hc0c43EY7FMo+XxJOECHPY2tzUkAtBOKhgHANOhimHYRCSLgL44bZagEEFXs9ORghtE4xRzTsIxGAhe4spe9ZOBbBgP+u8v3NE6f7oTXTs7CMOOVJVh5+MTTmOCMBJAaPaMILYhOUEbP6O6aOnoq2i2rB2SjWGUW2OebYpfxeo48iGx1zs0posYPRCNw3QUGWHVCkvfNxhunuZajHrE0Iftp/euM42M3Skr1UgXx3NBct8PoBTzhSLcg0H/zU+nM7PaDi8ggpn/7WCOKdEZ/blSJKUtZUq/5Xemj10vMk9gBsBJdaHvV6iSqTv5xHc3bfmQkGBQ6T+FC8/aKeOI7YA3Wq4e5Vbrv9/u6qpyM21wuvH9+FloXTb3+7kfwP0MOTX+pU5MLvi55zYmb3cH2fmkDgqTdqmDZkD9L/h+MK96j4L4DBxRXg/qyFCECM8ln6dMIeYmAEGMoWJ3ge0MmcdepojN5cVOSBu7HotpHEb8OjVUN9DYtXlnAeSYJJOrxMZZiQSEDMXwH5QYCXQ7QX7aKCiVERDkSAIJkU9o6oJerZZ4NJXcLFuQ11Lka4JcWUQBI+5DJAkap48fsp3olPXFuM2t11Qh+kGiaA7VwVrNZM82vpXhrAihgAfs7OtIXLzCnB6kcRXYlE/+5TKS2CXbQHowq60pZsYJCFa/scNOct6ojr+++lv465rbxjkeVuv9UIyjlydid6gAATAQzhnlzpM/Cx/qWHgWYgpvlma97pnCIaejVRXk+ymIgcXThhpzHnQBbQQGo4a5ANv3oZmq47GLyb09AjxgeyDAokblSprZOmIt8H4VCSvkmzzQASQi5PZUZP2nq0BTQPlPUSh+97AIUOrjw1N/3i6U8b+PZsNtUKwjwn784VrWBvOijoicualBVWfgTH/jl6peS/ihoVyWAtS7viXTxbge7MeT6ZrHInuKLndj4tCGe2tjnqnPI k6V8FTdF JcIQxVxZFHkw9HURyLbIlt9iKlPBqqGCmf2i4YQ8TpYp1kz50lSKIgEmcNTxXs2GIwXTD9yQf3BZfiS0JdYKbdrPXVpCWuqGjAA/chDiNW+CJVXKG1YqwpxVVxZgtyvwiEahh98eoO8BTPQzo4IHuRk0O9oHjau9Rry4o387Bd1Amod0c9MSOwfZEXdRSS/jhdwBk71sM9y0lyF4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 12:10:50PM +0800, Zhiguo Jiang wrote: > + if ((!atomic_read(&vma->vm_mm->mm_users) || > + check_stable_address_space(vma->vm_mm)) && > + folio_test_swapbacked(folio) && > + !folio_likely_mapped_shared(folio)) { > + pra->referenced = -1; > + page_vma_mapped_walk_done(&pvmw); > + return false; > + } You told me you'd fix the indentation. You cannot indent both the continuation lines of the condition and the body of the if by one tab each!