From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FCDC2BD09 for ; Tue, 9 Jul 2024 09:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E10496B0096; Tue, 9 Jul 2024 05:56:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBFC26B0098; Tue, 9 Jul 2024 05:56:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C61646B0099; Tue, 9 Jul 2024 05:56:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A52726B0096 for ; Tue, 9 Jul 2024 05:56:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 479881417BA for ; Tue, 9 Jul 2024 09:56:34 +0000 (UTC) X-FDA: 82319759508.27.9BD2990 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id AD20340012 for ; Tue, 9 Jul 2024 09:56:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="rhcEp/Mb"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="UvwW/JJB"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="rhcEp/Mb"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="UvwW/JJB"; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720518950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iMSXnQRaWruPl/Jbb8f0ExTGnX8AkZHFyonp0Yv7F64=; b=Q1dtJPsOFHZUrNLtl8bq1/N8l//HDJqKuLj1h7iNTvQuDGAKmxD1O0SJ+KSubQ9Wq2R7t+ pHW4WxFZh7jbwpU/4kYntiBEygVjWgH10zdZjCaHn70bbXv/ZmxKQqU+vpvxoQ/E70nwwD bXFSwtHKrME+ADaHxvHhCUniqE+odwA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="rhcEp/Mb"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="UvwW/JJB"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="rhcEp/Mb"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="UvwW/JJB"; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720518950; a=rsa-sha256; cv=none; b=VVqIH6Vnoqg1yjP8lNtJq7i4QxCFqBvJAeUAKZzsSL7WwFWjbHELX7K5UlHf3UUhrpbaue I+CrzbtQBt9Y5HS0no4Uwvudv5NB+aB23FdJTiOgj1v3ZFcmqH04ndQODKO9tZ26+yJ8AJ YyRrvKrapLovR1ThNpXRNE36Fbx+bKs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BE1FE21B9A; Tue, 9 Jul 2024 09:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720518988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iMSXnQRaWruPl/Jbb8f0ExTGnX8AkZHFyonp0Yv7F64=; b=rhcEp/MblB7slK79Gre2oegMwS/bbMPzwJ1pYSaX3mVru25zl3eaVgt0W+x6qEELEZDbBj 6887xhDXW1abZVl6yltZ5QTahrWl5C3WrfmRv+xEDi0SSM4/lt5uBvU+x603YVlz6MEJrG A4laRCzIxwnMFmAeY0Kf6P924JoxLq0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720518988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iMSXnQRaWruPl/Jbb8f0ExTGnX8AkZHFyonp0Yv7F64=; b=UvwW/JJB9rtc1rsYQ+n8cvw6k+IeFGqA1qb52uDZ+UT3jYp/LNGKCU5XaCJpOafdlC1oer e0tORqQf2ntIrkCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720518988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iMSXnQRaWruPl/Jbb8f0ExTGnX8AkZHFyonp0Yv7F64=; b=rhcEp/MblB7slK79Gre2oegMwS/bbMPzwJ1pYSaX3mVru25zl3eaVgt0W+x6qEELEZDbBj 6887xhDXW1abZVl6yltZ5QTahrWl5C3WrfmRv+xEDi0SSM4/lt5uBvU+x603YVlz6MEJrG A4laRCzIxwnMFmAeY0Kf6P924JoxLq0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720518988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iMSXnQRaWruPl/Jbb8f0ExTGnX8AkZHFyonp0Yv7F64=; b=UvwW/JJB9rtc1rsYQ+n8cvw6k+IeFGqA1qb52uDZ+UT3jYp/LNGKCU5XaCJpOafdlC1oer e0tORqQf2ntIrkCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5CF6B1396E; Tue, 9 Jul 2024 09:56:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VjDOEUsJjWYqRAAAD6G6ig (envelope-from ); Tue, 09 Jul 2024 09:56:27 +0000 Date: Tue, 9 Jul 2024 11:56:25 +0200 From: Oscar Salvador To: Donet Tom Cc: Andrew Morton , Muchun Song , "Kirill A . Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , David Hildenbrand , Matthew Wilcox , Tony Battersby , "Aneesh Kumar K . V" , Nicholas Piggin , Alexei Starovoitov , Andy Lutomirski Subject: Re: [PATCH v2] fs/hugetlbfs/inode.c: Ensure generic_hugetlb_get_unmapped_area() returns higher address than mmap_min_addr Message-ID: References: <20240709092122.41232-1-donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240709092122.41232-1-donettom@linux.ibm.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AD20340012 X-Stat-Signature: c4gtxd1cnemsdtr9eichqr1zy48agua1 X-Rspam-User: X-HE-Tag: 1720518990-119546 X-HE-Meta: U2FsdGVkX18g0MJ+QCD2zyWy8tQdzPIeCCs4GwEYBFrvZ26NgD7tUaV6QNGbNU47iu7JKZTdSqd+SsJiUfEdwjfFQbAjlreQHbm1wQyAALJq/eRiuA5Qctl4vrLp8tSzO6PwDl0sZuystlh8etYE2gga1H8URA9whd/ngBIGuemxGl4KYQzAkFRUgl5bfNPAmIBuRv31ykFBC80q4pmbcUQaYYsfp9XizB9qT+ewWIoxdUygo+gPfdl2NsC4EDAgyZXho+6KDh/s6qdS6+EpjR+ozbkaPjrwi2oVxcSesrsyY3NoHDyi5mSSF4ALeDkV/OI42hkmMW6Gn1BJrD2CzSrGadIekOePqCmNuL5uqK58SQrKifiHFiYv1bKBPa/U2KQ45BxljbnnTj0PHRQ/1QpRVDSDn+kRBr4e6DtbHkqxKYFWudvnZNVL80MPJHVkSufer5qZSkCfrpe6w0CIJ93VBK9zXypY/6Y/XVTLN4rdi6G5CUfk05Jr5tW8ZwUuyD+tceB8cfUAz0W/kPaL7nZJKjgg/WVy/qkdD6tV1L8RM8NOHlVKeCNeHrNTGDiDZj++2Sbvq8dwNJe/7l9qoShoivU6yy3qHqNwPuUv1MS9lOZtdJLX9BarwnT+kqscEhecS1QcScTK2LG1Bg/lg7co7WPYsbNjNR+rFFyonmDOXntBM+QJg7jPo0F+Iwnv9ReVoE8M0UiObfzF88zt/9df6ZcEI6NsyptcIBGpx900sqXRxbonVNdCtSDyW/Ndd7ZZMNz7jqBlt9WfyKrl+9woBtKrgTjtmJzZy/np2ll9tC9oYfLA2JHQuUbb5N6+9qWPlbQX4wlVkfdsFmYm4cw/Z2lrmx50Um1nlMl5ucxFf3JHIleJGZ8MDnaKIt7vHlkIEcEUB1u4Z+yovT9P8VMoBIhr7D/Il1dJ/Q+/GKiKacnuJ5Mze1L+WO4XGErG2XnFHCu/0Ov3sUZMOiH sVsJDwLI P4eP+Cz5LwD3SXux/okvQ23OXEJ5h9LtyhXQavWZiLS7JcJjpPNx9qUCesGt/lBnbD602TsCn0O+2MzkZ8os0Y6soIrM8UBJpXKRhE+crq97nZb+WaUqOQ2BdA7VGtv3ckwQHdcDln21o0pawr4Utt/+c0x683+XFb7q2JMSMISfmPKkwkaQQhTPyOW0bnU0OfgKf2O2sycLT4H7oKJ7mdFrVR4z1PrATK4ht+kdrvYSNezBV20rG67G5qD5lgnWaGfQvle44p9GHgi+50Xt284EJl5dtZl4NOGlEaSdMvh2woSkoIVihoBiWntqQfQvbeLEFJrrNRUFSwtysmxZDNatMn4OyrAY/46Ntld1HiMubH0Y80qAIcPO1bitC5hqtYqc9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 04:21:22AM -0500, Donet Tom wrote: > generic_hugetlb_get_unmapped_area() was returning an address less > than mmap_min_addr if the mmap argument addr, after alignment, was > less than mmap_min_addr, causing mmap to fail. > > This is because current generic_hugetlb_get_unmapped_area() code does > not take into account mmap_min_addr. > > This patch ensures that generic_hugetlb_get_unmapped_area() always returns > an address that is greater than mmap_min_addr. Additionally, similar to > generic_get_unmapped_area(), vm_end_gap() checks are included to ensure > that the address is within the limit. Hi Donet, jfyi: I am already working on other parts of the kernel to avoid hugetlb code duplication vs mm core. I am also working on getting rid of hugetlb-unmapped_area specific code [1]. I still need to perform some more tests but looks promising code-deletion-wise: arch/parisc/mm/hugetlbpage.c | 23 ------- arch/powerpc/mm/book3s64/slice.c | 49 ++++++++------ arch/s390/mm/hugetlbpage.c | 84 ------------------------ arch/s390/mm/mmap.c | 14 +++- arch/sparc/kernel/sys_sparc_32.c | 16 +++-- arch/sparc/kernel/sys_sparc_64.c | 36 ++++++++--- arch/sparc/mm/hugetlbpage.c | 108 ------------------------------- arch/x86/kernel/sys_x86_64.c | 27 +++++--- arch/x86/mm/hugetlbpage.c | 100 ---------------------------- fs/hugetlbfs/inode.c | 97 ++------------------------- include/linux/hugetlb.h | 10 +++ mm/mmap.c | 25 ++++++- 12 files changed, 139 insertions(+), 450 deletions(-) I plan to post it in a day or two. [1] https://github.com/leberus/linux/tree/hugetlb-unmapped-area -- Oscar Salvador SUSE Labs