From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A6F4C27C4F for ; Wed, 26 Jun 2024 18:06:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05DA26B0082; Wed, 26 Jun 2024 14:06:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00DEC6B0089; Wed, 26 Jun 2024 14:06:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3F006B0092; Wed, 26 Jun 2024 14:06:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C66E46B0082 for ; Wed, 26 Jun 2024 14:06:37 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2C809161574 for ; Wed, 26 Jun 2024 18:06:37 +0000 (UTC) X-FDA: 82273820034.22.344566A Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf20.hostedemail.com (Postfix) with ESMTP id 29BE41C0029 for ; Wed, 26 Jun 2024 18:06:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pX8aWjRr; spf=pass (imf20.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719425172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9oYN+ptDdc+VW/Y5Ad3Dz7fG7XoJpsThVWCIN2IxS+Q=; b=2dclbmfFtF9njl8OLu0I1dKcOCjRW+tQoBnzcn0YpEFPA1HQAmYTo41l0jNe+mI4gM+NBc nFWjBwwGmmYveaotbrh4uZfm1tEe8mx7+DaQIA5nJGtNkZwErF/ln7ijXgszl9YeUq1Ksb xG7729nVxe+q/BYdZlTtA/YWGKdfKOc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pX8aWjRr; spf=pass (imf20.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719425172; a=rsa-sha256; cv=none; b=T5+t5aKQm44lDhzL3bCkaAoAUgwARTN+5L5eNNtdpHABXAGR6b+xtjUQvnT+4kuJyQSQml dthMtItPErqyOGEuKd8bma18jMLLiRdRRZuJ79w3c+j/iLQrhI2hO8ZXZ8uJsBqv2liDLD EHOQjUsauDHdAQPuf5W89QFsjGIXxQw= X-Envelope-To: mhocko@suse.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719425190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9oYN+ptDdc+VW/Y5Ad3Dz7fG7XoJpsThVWCIN2IxS+Q=; b=pX8aWjRrsrjIIymjQqgcTmn4feMUhQRVVjTfxS4mQjNR7ePsCf6zG2cxRsCaDkhfkQJsci mKT873AIt4ySayv/kNdz6V3XIeaFvilvUtMKbinwwqBbmjfEmERv68zsDdqPAhMriN3Gfk vqTzqgeOyvDEdVlBbHPxp4Qoqx5InXg= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: muchun.song@linux.dev X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: linux-mm@kvack.org Date: Wed, 26 Jun 2024 18:06:27 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 13/14] mm: memcg: put cgroup v1-related members of task_struct under config option Message-ID: References: <20240625005906.106920-1-roman.gushchin@linux.dev> <20240625005906.106920-14-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 29BE41C0029 X-Stat-Signature: 63aw5dg8ju3qf6urqiqb6nkpx88hxn4g X-Rspam-User: X-HE-Tag: 1719425192-784954 X-HE-Meta: U2FsdGVkX19trjekW6BRPEFXQv8MBVdYxRi2UMcZfToVmEqzETyH1GfHvBp27XrpCvpYCu9JFht1vOsGWQj9O8jYPOvJIWcDgkUvNGQqIdG0P2m3EQgbSMNts3wIWnSf7zR+nQ9FKd9tAm3F1LeRe0arW7HA/MK6xTmj6NVY7IKqiQ43JDaBZ/Wgjy45xofuvF/KxaEV/7Dbl8AGZhmdL2LY/qMaGC88YPi4b6uoXg9HwxeSvz2oyPM4GogbwXuXhi5CtzyIBGSdyp8wLW+oSeUVPNcNMVCohbkhcKhkf85DJ6izazFUdOomByou6/ws2QCp5sV+z72EhrqMuvUkyce1a7g2lJ+focDuyr7w7S/YtGeFUEWuKomhIxt75Ke4qKsT75HIjhYfnsuR8TS/pO35Be4CMCRfzF9S3NNOJ3EzzUx99HoQlGD9KGE2EZ8X5aFXRw97c1KUA4yCNHJM2s/cRJc9jMVH3eCbpuZepxPIl+hjQe02mH5ktGxYe7MHmc7py1/vbnd2gGdpqxXoRYnvacI4sIsCQ8e01j2qnBRL58GdRt6uyPPAwW6rHzGvWhM1X9B05Yr6x2f83sz3dsLEOxdjnYZTAtbJF1PVqaUNj+tk3c2P9zIJ1+c4yKphKhMsyRUD7PG3+twGL2c5tc269IayYpl+fNdtRbOYbuQxmxpXTCQRLJkgjhmGJUiNIm8M72IbdKfmBbz+NtWeH0t++q+7IH3TSlz2OaVaMm/53cAIt6rgv5E5OTOU6C3IrA6EhW2mP7bowNfkwKr6cbLJdsfB9m1tXt/DZYk6IjnMFPBBcmigFhsmY+K98JE90JkZfak0dfa+cWYp6fhuJOJ0o3m+dDalyY65iHf6zq+ySz8+sMjvalPkCkS/F9wWwuf6OC0toLo8K69JhZjXiNMoLFiJacm6DPrVwjpp5s1QQRyv1j7/YCXPzeakNfM5lMQKKma6U9g14Y1Thgi RNWH9Zx6 pggCPYMAnjbPqIofSvQD94VpaZrOX4kCi3eUfpEWK/DZP/BBmsy7Hz0JqRBEYhQgXyxd4ziJBwnl1mWNvzFSv8QI0CU+AgWLpQOW3k/luhdLh7NWTUg9m4TYLmbHmuj9I4UVPI99o4ZE9EjP3oIQH/rvF7JXDSmw8O3FcurCt1lZ5sy9DRSkfgA/63va9xfwMdG6YITdI5x2+5C62aYYk3m+2zRX/6eAmBixujRRGjhVA0xI9Ptm3i6eMF4k0qgVQRIT6WNOVOC8P9Sk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 09:19:04AM +0200, Michal Hocko wrote: > On Mon 24-06-24 17:59:05, Roman Gushchin wrote: > > Guard cgroup v1-related members of task_struct under the CONFIG_MEMCG_V1 > > config option, so that users who adopted cgroup v2 don't have to waste > > the memory for fields which are never accessed. > > This patch does more than that, right? It is essentially making the > whole v1 code conditional. Please change the wording accordingly. More than that, it doesn't do this at all. This commit message was taken from another patch in v1 of this series by a mistake. > > I also think we should make it more clear when to enable the option. I > would propose the following for the config option help text: > > Legacy cgroup v1 memory controller which has been deprecated by cgroup > v2 implementation. The v1 is there for legacy applications which haven't > migrated to the new cgroup v2 interface yet. If you do not have any such > application then you are completely fine leaving this option disabled. > > Please note that feature set of the legacy memory controller is likely > going to shrink due to deprecation process. New deployments with v1 > controller are highly discouraged. > > > Signed-off-by: Roman Gushchin > > With that updated feel free to add > Acked-by: Michal Hocko An updated version with a correct commit subject and description and your config option description is sent to Andrew, you're cc'ed. Thank you for suggesting the config option description and reviewing the series, appreciate it! Thanks, Roman