From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74E1C27C4F for ; Wed, 26 Jun 2024 13:53:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33DB06B0093; Wed, 26 Jun 2024 09:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C6BC6B0098; Wed, 26 Jun 2024 09:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1411E6B0099; Wed, 26 Jun 2024 09:53:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E611D6B0093 for ; Wed, 26 Jun 2024 09:53:30 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 85B7B1A11F0 for ; Wed, 26 Jun 2024 13:53:30 +0000 (UTC) X-FDA: 82273182180.09.802B570 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 66E7A20013 for ; Wed, 26 Jun 2024 13:53:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hfyZaCQu; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719409991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6L/CySx21VlY9lkKLs/UvRv4ham7l6zFWPjNK0vJEd8=; b=nFK5YcaN5l6vGvFhcKUYxB0WBRJdms78sKTaHF9f0sbz7rP2wWdbgHgIVF6CYaTC3xQAg1 g4inHdWg/fGFtxb7ekbYDSdXC1LhoDI1kQON6Z4giIqrkrSV//onFena+l7oN6vcPEUSPj NJnEMn+C3u+GZW84XjgNmr8U+Vz3Ofw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719409991; a=rsa-sha256; cv=none; b=R8Omc/+3/Q3mFhT5f0WNFauxPII+Wykc6icGYGhYysKOri+UD5ZnNGIm7Fuhq3c8WjLF7t v+0Yxe0LJek5nvXxF8EVpEz9HxldriGfMwza4XnHPmMZNz0MnhMKyOKqeMl+guJL30UAvW vFNikNb05xNhpG9rjj4agX1OjgYo77Y= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hfyZaCQu; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719410006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6L/CySx21VlY9lkKLs/UvRv4ham7l6zFWPjNK0vJEd8=; b=hfyZaCQu31XxNRucNB75BPsNsZ4pHuvL1XPzD+fAxuG4XHG0kgjGH0h3JcVosqderAyiiP FTbwhijcSTKJP76Yg8HDJpAoAhvLb6v21Pvo+N3NxqUD4n04FmN9KKBPv6hcP+qXZJwD8t hWToBiERPMkhZGzyNzJL5RePO3VEDbQ= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-M_In85RrMmOiA6_mqMOavQ-1; Wed, 26 Jun 2024 09:53:25 -0400 X-MC-Unique: M_In85RrMmOiA6_mqMOavQ-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-43fd537e6a6so14120051cf.0 for ; Wed, 26 Jun 2024 06:53:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719410004; x=1720014804; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6L/CySx21VlY9lkKLs/UvRv4ham7l6zFWPjNK0vJEd8=; b=MdE+eD3otGSnY2pN6hmeBpnvOMOygy2jO/peHPyE45TLMKmB/aqVIzr8jwSrqVjAEU 2k/te58Sh9TGT+WzaypcnB8a8qL3EDd+r+Ii81bHn6PDbhJtEPVzft0iInMoTLcs9h// nwvDmjwWx1HlkO+xRqVrVQnwxTk7CBx+YKHwSe4BAcoFqy3AQmtxEayOb1wwMje4nNpb 7qkSd9Gtga5hIl6G6hJZCC+Gz3+x0i5DdIR7oYstM4xANkz93T6qvv6hrQ1/bdd97Kqx F0wQu5Igz/duOObbeTh17gT1upR94kXvx5yvlyp6el5BJ+mY1nR1mmqqolnneoMV+Y+R 3MPA== X-Forwarded-Encrypted: i=1; AJvYcCXnu+ENl1JD19U67gDj2Rt8Sz1JiR4FNUK4SzgywBPtoHhHSaprAh5AXOFO+mvfu9/kY6eMuD2Wawt8PsdKDqQdXfo= X-Gm-Message-State: AOJu0YzgcQDuV552A6NczfmQ+wF3oHWKDVsU27e7MCRLSSN4pcCLihhz Z/pERC32Ek7KicQPE1+/TUa11tIZy88yHU8DI2HbuQdrs+TQOlxovaId39qG+kJ63lufsPlpvjS JUvDkjJj3E7NQVFx9RaHd/x+U6v0+NSwtbYHh+6FBjmPEuDq4 X-Received: by 2002:a05:620a:29c5:b0:79d:53d0:95af with SMTP id af79cd13be357-79d53d098f6mr146858585a.2.1719410004596; Wed, 26 Jun 2024 06:53:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfg5gp8Vxw/erpGLqvLxIwWQrtznQgrqGbKZUsqsdxrw8Gui1u4uAwFXpio7u+OhtBKCeLlg== X-Received: by 2002:a05:620a:29c5:b0:79d:53d0:95af with SMTP id af79cd13be357-79d53d098f6mr146856185a.2.1719410003910; Wed, 26 Jun 2024 06:53:23 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79c082c7433sm137223985a.53.2024.06.26.06.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 06:53:23 -0700 (PDT) Date: Wed, 26 Jun 2024 09:53:20 -0400 From: Peter Xu To: Audra Mitchell Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, aarcange@redhat.com, akpm@linux-foundation.org, rppt@linux.vnet.ibm.com, shli@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org, raquini@redhat.com, linux-mm@kvack.org Subject: Re: [PATCH v3 3/3] Turn off test_uffdio_wp if CONFIG_PTE_MARKER_UFFD_WP is not configured. Message-ID: References: <20240626130513.120193-1-audra@redhat.com> <20240626130513.120193-3-audra@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240626130513.120193-3-audra@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: tt7kxpf8ws9ahaet9t5fszpksce884z8 X-Rspamd-Queue-Id: 66E7A20013 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719410007-103098 X-HE-Meta: U2FsdGVkX1/zl0dqIOnT7XTmmKKdZJLXdlGUvs2jifxUIAsxF5pfcolrhvBB/TeJWTkNu52kfQWiv+fOa1iNJ/kEiXXqPtuvSdg+OQvRAcJYr4wlv9SW4s/VUSAGgg1ddMUo9cjThw5Lx0UXlWkzrZTyQbF8fx7kvKImzKhsHL8l69ATbCLUVj3eLlgKLNlZsvkV6nj+jFwkgivXU5CLVtm70prcqvM5KsHGGEo1qas/0Ok6En18ktEnig8qtk5T64u4DAmj9Odztrkg+FqCbXXguGumttMlSRciIczOGOxxEnZlT02Ej4a3Q7VGlViTSPYcQce9rqpMz+8eRWMpusF7lcJWfsV60MPxxkZ2WKt0RdBPcK72i9R+xtODvrSHbucyzXaBiEiGl0ybWNmDaTk7Bwtoe+cj1nZUWolVR+PKgSQXb//yuiiBCUXA85xQkj6TkLQUQKa0WgL+4w+wVTiZJoB4rpLXus5Ijy3kZqADvWrHx0iTd2SbbEE//VCgjOddT6PFamcvAJluB9/+i3F0ef98Lni+QZgP0NLNn+NPm8oN6XfBBYU+abkpL8fBWNg3x2WGTiqN/gskorA5xiy/d38UPmQnVBcsOqS23NqAxDNrn6h18nZ/CH56t+vyz79hr93jU385QcDNVzs3q1h5f6GTP/KCBc7AeFx9TQIZ4x2dWVK58gw2iRzzN6sat8s+WDbvU7PgSZthi10sIiM5FtkYDM/weaL7URdab/G0CObOJ0w31vzXNW6nhRkjdh8VYt39EUsHexxAPcVrna+pZEPdQJfh2iaVwtnEY7o37mbpuOjnfOgFhA66J3cQZ6qIGq8iYzHJhUFZo0cFer0ZfeiULJGFurGtuihcNAqZ4opJIzKB9c+3FONzp4770XknEI2F4e1hWIhjYUWKywIiicNqo5i7UZdAJgNzWZSkrQisoBErbHOEsH2VqtZcaSmFLWrCpdgUpKb8TQo 75bFraGk /ChZjqwjfMT+z2oOuI+cNssRdRMSbHtf/jT9ZJP5iyunyCEohOJi86ANsauUxiy7gBp6BIHdmzoRx7xrlPf6MUe9hF0yCTi/PG9qeQWnQa1fH0hGeDfiUlp05jdWhNI5Dn6SysLXZKOe32+XE323mXq/B60HVGDe/c45xDVa0yYwmPdLw8zhlu5Wf1BKNHicsZg68TTCFKqx8hkLYxVXoCaFgownckdVArffLFbvZe0vbmsAsZdbS/x6KD7526aHWV//QL8ElNDKkW0mgXeHC3bp5Jl+6yrf+EkbGtxtO6pUzo8paR0NTPmmDE1ZlwT73dKxTuzn1swHzx+zfqIusK0wnah43y3mGeb8EhHXfz27q2yhUCOL1NE52JT74DBOUx3dVf5KQVaPiO5uutsl3ZVWJddIxhquavU5z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 26, 2024 at 09:05:13AM -0400, Audra Mitchell wrote: > If CONFIG_PTE_MARKER_UFFD_WP is disabled, then we turn off three features > in userfaultfd_api (UFFD_FEATURE_WP_HUGETLBFS_SHMEM, > UFFD_FEATURE_WP_UNPOPULATED, and UFFD_FEATURE_WP_ASYNC). Currently this > test always will call uffdio_regsiter with the flag > UFFDIO_REGISTER_MODE_WP. However, the kernel ensures in vma_can_userfault > that if the feature UFFD_FEATURE_WP_HUGETLBFS_SHMEM is disabled, only > allow the VM_UFFD_WP on anonymous vmas, meaning our call to > uffdio_regsiter will fail. We still want to be able to run the test even > if we have CONFIG_PTE_MARKER_UFFD_WP disabled, so check to see if the > feature UFFD_FEATURE_WP_HUGETLBFS_SHMEM has been turned off in the test > and if so, disable us from calling uffdio_regsiter with the flag > UFFDIO_REGISTER_MODE_WP. > > Signed-off-by: Audra Mitchell Reviewed-by: Peter Xu > --- > tools/testing/selftests/mm/uffd-stress.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c > index b9b6d858eab8..3266ae885f75 100644 > --- a/tools/testing/selftests/mm/uffd-stress.c > +++ b/tools/testing/selftests/mm/uffd-stress.c > @@ -419,6 +419,9 @@ static void parse_test_type_arg(const char *raw_type) > test_uffdio_wp = test_uffdio_wp && > (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP); > > + if (test_type != TEST_ANON && !(features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM)) > + test_uffdio_wp = false; > + > close(uffd); > uffd = -1; > } > -- > 2.44.0 > -- Peter Xu