From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAB1C2BBCA for ; Tue, 25 Jun 2024 10:32:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E7986B0308; Tue, 25 Jun 2024 06:32:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5700B6B0309; Tue, 25 Jun 2024 06:32:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E92E6B030A; Tue, 25 Jun 2024 06:32:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 182686B0308 for ; Tue, 25 Jun 2024 06:32:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C81481A18B6 for ; Tue, 25 Jun 2024 10:32:30 +0000 (UTC) X-FDA: 82269046860.07.7F4F613 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf19.hostedemail.com (Postfix) with ESMTP id D52891A000F for ; Tue, 25 Jun 2024 10:32:28 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AV55csMB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719311532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hwlILf/vswvcQXQNiD+f6wBVsZ6SMfSlkE3EALaPOOg=; b=J06XRZzAGAWF9mk28otOiN6gGtXznyLF6oNmyNX0tcMLSBJhs+evDbzI+uzz6//lZu2INr Rz20vjpGut2NIDp48ZVyGyFVyLvuC0ToYscoixlH4oiunkobsDHazemaDqbALWX9hXefsa YA9ZKL1pyzAQQHuMfoKmeqQuaSQOwA8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719311532; a=rsa-sha256; cv=none; b=FMcofvc0AI3vXSby3bx1a2DCJKnaIi1GTvkA1f/KF5UNtOc0gaa7PUWhwQXGfaE3bSuj76 jcSXYvaLjxw37qHvAaKfqLbbCKNJKUedHHQJKWl+m9AuCR30AN7zD7Z9+BSCSdRYljKgYz Oj6pVHqZDn+WJsQUIQMAhUwOnCIcH1I= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AV55csMB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52cdd03d6aaso3203224e87.0 for ; Tue, 25 Jun 2024 03:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719311547; x=1719916347; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=hwlILf/vswvcQXQNiD+f6wBVsZ6SMfSlkE3EALaPOOg=; b=AV55csMBsR/rBCYeOOsWM2DUY4znZCGCI+laQdMY8C8xClq6yL72up6f6wGJzX4OUy XJ/umhcOF8TmTg3hEuqQVb5q3eqdgeRkUxFbK7Yv8Wk9z3kaNTCoJJOh85uMaFjJ0Pbc A9nDlQFqbUoMw6JK+BtuvWZVpYeD6FqT4f+UMEY0bVsNvVF59FWVJAd1b7llDGN3NDji O/h2WhQiHctaCJe9x1lyFH+4MN1KmDhsZ/uytVINMUXSZ1mJtqHDd3mxjYy73osMhbsR J/L1EGzOwr1YRzr8xojsL6T4myMGetVUTCR6aAPqGz82yeYzT0J2qtrfYW6Oh5mg85Pn K34A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719311547; x=1719916347; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hwlILf/vswvcQXQNiD+f6wBVsZ6SMfSlkE3EALaPOOg=; b=QqjoYwjSoqcZz1jWVO+M9biNQGV7yYbh8XlrsWajz5/ucx5PXcW3DtyoaIOq/uINf3 6/M+NCC2Oaias6JplRIgUQCPGuXEGTp1Z4au51u1lSu9iBvyUUoOq8t/aFrQChn7QWq0 DQcqp352Nl3V+LTzUsvx/oYGW2OtLSxQa+HSjUNVVhEO160NW9gXuFxjUEiDSCjy124y LX+gjYNpAKa98JUJ9V8CUoqZSn37hFFzQy0V2d1xb58h0CpeOwGBHSCloiieIKnDa78Z hNRSud7c/ghU5jcgkt1LYiwXUH0k9ST1kdWsQpkO/TjXQn+lhwWVoIfi3RFFFWuAPAov P2Xw== X-Forwarded-Encrypted: i=1; AJvYcCUSWGcOxc7wCYcpvSAiV5ZeEStkZdEeiHk6iy1BGMCbfo2axCwACnp5kH6u5QoY4/DGIuarEN5xSv+uflEyRhHAPm4= X-Gm-Message-State: AOJu0YzEbvaDS2BobMWP6ttzyzhzpNBdF9HgktKV745HRSKAcG6V4R6D 3EYSflfPKoGeLj1y5zM/Icx5xv4fdeCVotK/I90VcbhP+8jvFdGv X-Google-Smtp-Source: AGHT+IHDpYG+hLWunvJBAtgghz7RU1rOfdf/y+G3mJ4Hofm9Q9LEuktQaJ5yAE3vHGX7WYR/sLdxZA== X-Received: by 2002:a05:6512:2083:b0:52c:e040:7d9 with SMTP id 2adb3069b0e04-52ce0680398mr4513835e87.59.1719311546840; Tue, 25 Jun 2024 03:32:26 -0700 (PDT) Received: from pc636 (host-90-233-219-252.mobileonline.telia.com. [90.233.219.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cdce71c86sm977460e87.142.2024.06.25.03.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 03:32:26 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 25 Jun 2024 12:32:24 +0200 To: Baoquan He Cc: Uladzislau Rezki , Nick Bowler , Hailong Liu , linux-kernel@vger.kernel.org, Linux regressions mailing list , linux-mm@kvack.org, sparclinux@vger.kernel.org, Andrew Morton Subject: Re: PROBLEM: kernel crashes when running xfsdump since ~6.4 Message-ID: References: <75e17b57-1178-4288-b792-4ae68b19915e@draconx.ca> <00d74f24-c49c-460e-871c-d5af64701306@draconx.ca> <20240621033005.6mccm7waduelb4m5@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D52891A000F X-Stat-Signature: 9nefbsa8o83dkecrowy8w73z47fpg4if X-Rspam-User: X-HE-Tag: 1719311548-429375 X-HE-Meta: U2FsdGVkX18IKKFoM7+pCn9zSoMcX12G7sqbeTNkV1+iYEvz9sOWnCn4wTl/Bv6anIEzm+31LS7DIBUsYXI/8sfuejxxQh69wkyCQbi2dCtbYDeA7FnJijG7gm8+CsXyCUv3vBRDT3aJSIzpdSu2ku5XLftvFV0UJNklptT9f7GwN9izqnelw8fiikEDabTAGvtoDE72rPfE4nMX2H+JdMACr9Eye9+p8yKuY0EITLfmMdtJo/pIiWPsjeF9cTWof7a8c2rKh4YO3ZWJu+Y/otyygxaawzdWwczpa/Ns8wlDiiM//mxAMGHhcFphIT8QR6+IW9RwAzzMw2rONOeRVN4FUPNBSaMYutEZMqdeLqRq9zW0vpFWh7fnZikhg9O+v/8pMHegxnrj4okUamF39SFuXubns045T/QgmCKePyW7R6Qk8obzMOmz1n4R0NWd8kJSXanpgwy5fKuC9m6X65st5PAo3+VSBrnT+hqWLWjWOA3sRWosDlGrqcEv0zKvYsNxo+3HQlfBy8D2Me+wyZH8K7yVkDAf/z+eQx2ilRt2PpgirE6bHnR3cnSVrNKu9s+lkqebEgSGg6O/MASQ4wXyjcvk2luaiF5dygDa56Je3E0igQFPloU9MwePomlZkd0/refXs5BW/Wxy60HY+zFpGxC6yWy6BAdjsX0KUNU3ohR9ViYPY5BPnHFZvQcKCbOGbq6VP0t4rd5S+bqcB/2awbvMHsfxPt6aSN1WQSwQwRSldrUD21EeeyVKpLHlye9exfwFsVF5QHEe1wcP/KjSTN6W/XVeBOBUkOM0aI7T2uaor8lMYXHCPl/20jrtzscHklsV6TrvKubuxgjW4AacFEMDu04bIw+4fUYgbBw6kLRHiCX+2gnnL6VWmd6YJsnfBtYHLGFqPlLZovN4Vu3BzQGMzLLVudcNoDyxVwmK22RX8994HvZK4lbrkWB4dP7TQM2vLOoh3pht9XS l0+qZf9n dxZ3ir3rwdhIBc7WAXki17SHJdsLVitTlMn25zAAPoq3Z5kDTMYR4HnwG46BIjgtIfEap9DZLlxCEI1Kn31vsv/hXdJw9FAEVeQaluhvP3LEdFCbec+pMe4hcF/a9csqKPNeLH29ROfKNHGQGV6soHq0AAR8se+7OkWkvQDGS6A9akgVCfJqfWhA/zvybuVmpngERTSnkPXrr+WwZdWCqZ7gx3/zaRxoOSmudw/bPBc8ln8D3pxnx6ugqtJqoXXJZhJsfx0Al/Sgzixq84fxn1a3Suf4wWO6tUoALOX4WSC2BBNQ+zvxXe857wRoIwFVXtfaaRQw9dQcnUwXmiIpn6NH5b3AmvrKtD/fKXe7rvHV6WVkYlEffSNUQ3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 11:30:33AM +0800, Baoquan He wrote: > On 06/24/24 at 02:16pm, Uladzislau Rezki wrote: > > On Fri, Jun 21, 2024 at 10:02:50PM +0800, Baoquan He wrote: > > > On 06/21/24 at 11:44am, Uladzislau Rezki wrote: > > > > On Fri, Jun 21, 2024 at 03:07:16PM +0800, Baoquan He wrote: > > > > > On 06/21/24 at 11:30am, Hailong Liu wrote: > > > > > > On Thu, 20. Jun 14:02, Nick Bowler wrote: > > > > > > > On 2024-06-20 02:19, Nick Bowler wrote: > > > ...... > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > > > index be2dd281ea76..18e87cafbaf2 100644 > > > > > --- a/mm/vmalloc.c > > > > > +++ b/mm/vmalloc.c > > > > > @@ -2542,7 +2542,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > > > > > static struct xarray * > > > > > addr_to_vb_xa(unsigned long addr) > > > > > { > > > > > - int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus(); > > > > > + int index = (addr / VMAP_BLOCK_SIZE) % nr_cpu_ids; > > > > > > > > > > return &per_cpu(vmap_block_queue, index).vmap_blocks; > > > > > } > > > > > > > > > The problem i see is about not-initializing of the: > > > > > > > > for_each_possible_cpu(i) { > > > > struct vmap_block_queue *vbq; > > > > struct vfree_deferred *p; > > > > > > > > vbq = &per_cpu(vmap_block_queue, i); > > > > spin_lock_init(&vbq->lock); > > > > INIT_LIST_HEAD(&vbq->free); > > > > p = &per_cpu(vfree_deferred, i); > > > > init_llist_head(&p->list); > > > > INIT_WORK(&p->wq, delayed_vfree_work); > > > > xa_init(&vbq->vmap_blocks); > > > > } > > > > > > > > > > > > correctly or fully. It is my bad i did not think that CPUs in a possible mask > > > > can be non sequential :-/ > > > > > > > > nr_cpu_ids - is not the max possible CPU. For example, in Nick case, > > > > when he has two CPUs, num_possible_cpus() and nr_cpu_ids are the same. > > > > > > I checked the generic version of setup_nr_cpu_ids(), from codes, they > > > are different with my understanding. > > > > > > kernel/smp.c > > > void __init setup_nr_cpu_ids(void) > > > { > > > set_nr_cpu_ids(find_last_bit(cpumask_bits(cpu_possible_mask), NR_CPUS) + 1); > > > } > > > > > I see that it is not a weak function, so it is generic, thus the > > behavior can not be overwritten, which is great. This does what we > > need. > > > > Thank you for checking this you are right! > > Thanks for confirming this. > > > > > Then it is just a matter of proper initialization of the hash: > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 5d3aa2dc88a8..1733946f7a12 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -5087,7 +5087,13 @@ void __init vmalloc_init(void) > > */ > > vmap_area_cachep = KMEM_CACHE(vmap_area, SLAB_PANIC); > > > > - for_each_possible_cpu(i) { > > + /* > > + * We use "nr_cpu_ids" here because some architectures > > + * may have "gaps" in cpu-possible-mask. It is OK for > > + * per-cpu approaches but is not OK for cases where it > > + * can be used as hashes also. > > + */ > > + for (i = 0; i < nr_cpu_ids; i++) { > > I was wrong about earlier comments. Percpu variables are only available > on possible CPUs. For those nonexistent possible CPUs of static percpu > variable vmap_block_queue, there isn't memory allocated and mapped for > them. So accessing into them will cause problem. > > In Nick's case, there are only CPU0, CPU2. If you access > &per_cpu(vmap_block_queue, 1), problem occurs. So I think we may need to > change to take other way for vbq. E.g: > 1) Storing the vb in the nearest neighbouring vbq on possible CPU as > below draft patch; > 2) create an normal array to store vbq of size nr_cpu_ids, then we can > store/fetch each vbq on non-possible CPU? > A correct way, i think, is to create a normal array. A quick fix can be to stick to a next possible CPU. > The way 1) is simpler, the existing code can be adapted a little just as > below. > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 633363997dec..59a8951cc6c0 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2542,7 +2542,10 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > static struct xarray * > addr_to_vb_xa(unsigned long addr) > { > - int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus(); > + int index = (addr / VMAP_BLOCK_SIZE) % nr_cpu_ids; > + > + if (!cpu_possible(idex)) > + index = cpumask_next(index, cpu_possible_mask); > cpumask_next() can return nr_cpu_ids if no next bits set. Thanks! -- Uladzislau Rezki