From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77402C30653 for ; Tue, 25 Jun 2024 09:55:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 099416B02FA; Tue, 25 Jun 2024 05:55:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 048DC6B02FB; Tue, 25 Jun 2024 05:55:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2BA26B02FC; Tue, 25 Jun 2024 05:55:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C42F36B02FA for ; Tue, 25 Jun 2024 05:55:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4C70D1A1726 for ; Tue, 25 Jun 2024 09:55:42 +0000 (UTC) X-FDA: 82268954124.13.3D253E0 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf24.hostedemail.com (Postfix) with ESMTP id 6264418000E for ; Tue, 25 Jun 2024 09:55:40 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SNvIQXpR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719309329; a=rsa-sha256; cv=none; b=E2JMs0uuBqaTndNA617qIcrOAKFOT5GM6RNzcNc9I2Z/6DtjMpTONvn+Ra81825MLvS6Oy PgeUFlXHAIMN4zdnYQHe41SuzFqmUneNPpEcueuJlgflQLqM+gMYBWAdGv/YzZx6LvxEUD 5PTvUMgM2YkOUDl2rH2N6K2FnkfR3/c= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SNvIQXpR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719309329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gfQp3tHSHToj1eIsyyv3AOWK2ep4ErUvO8iv0wMJcac=; b=Q2QRgBzTxuoYD9lAXgX4HDqd3gMk/QzqF1B32bwUqBq3QV48JYd/CadWoLDuMnrdHgya6X U+Sk0NSHyvjR2GEQk/rK9MWtqgEmJLGDe/jXqiCZN8FWgEJaJs8yxP9p+PQ2ChuDuF/GGv /7dYy6SR6/VsmkYGZebM2lDenYQIS8Q= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52ce6c8db7bso2328928e87.1 for ; Tue, 25 Jun 2024 02:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719309339; x=1719914139; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=gfQp3tHSHToj1eIsyyv3AOWK2ep4ErUvO8iv0wMJcac=; b=SNvIQXpRSmvkdUj6VN/Kd+84wRwgIc9GYGHSyN5O0eKohoU8Hw/KLiQprV0RsyMLzm D88F5RZFasu4jPUmgRrQ4RpCuRX186GDPhADLwiRU55lfiQpI3SOc+2b/VZ6mqbLj+ho AceN2iJMgEtKx9SKSTU4JgbnnPblHYx3oM50u7oL+sanrFW9e/Q7AnNOLgUojnpijmaU PbNrWlnR/GuTiLGPBjDThSEKU8Q64wAcCdqZmzLnQy2VnHlqsvZQhRNqnYkLDNxdfRpb Cv6hvpscosLLPXo+zw3pT566aGKGu4xID4ScRv5ZkHyjZzfeu5Ye4c/5jQbBsss7Flct xiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719309339; x=1719914139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gfQp3tHSHToj1eIsyyv3AOWK2ep4ErUvO8iv0wMJcac=; b=w53jU3kZCAWtIIveGORALhhIvu2JYx0MH6mSrpVp4ogIJ8OAUU9MZqI2xDSRUb2Ezw hPCVY5G/7xPHsbuSkasifBKBe67cjqCoFP5wSZIJjxUroU+H33xHXm/O1bx+AhRaGLUu i7L+rP4bOKGpcPn0raq6FhkjR2fbxoZudMIKFzLMX5FKyxgcQmBnPkswllBnEKyY5zq1 5bVebAZwAF1CxIU3j/2bqmwzU3VabCwNiOKUs8T7PdcfCKGQ4cB6QMcNclRmd5cx/WV+ 225uUo34DRW6fq1q48nNS8TVAhNJI0X89SlaTBBEURG8vPoo0Q34Xytdq9xxLip3pEB7 qvdQ== X-Forwarded-Encrypted: i=1; AJvYcCVzdyeRFlXOvHdmixJrgJG0b+mWIEEuMSJIeTI0zZBuA3nP2iMO/Y6OwBDrWpFuiclSkbvgYmE8VM8GjbWTa8ci+2o= X-Gm-Message-State: AOJu0Yx3GXVU/9jfNG6tOMv5AstdXVK8LoMhPyR006CxznyrD42/EHCw zErcdbsyGjzg+Uayh6nWaOkc+btLkemEBRwkwgKcgw5SzOhx+OGSjYdzYw== X-Google-Smtp-Source: AGHT+IFDyTMqAyCzv4pa7W+j1ChiYbIQFSUuiDfMgLet2zKOii0moGRZ7U4DIe72eYKnmsBvJ0cFFA== X-Received: by 2002:ac2:5311:0:b0:52c:8479:21fb with SMTP id 2adb3069b0e04-52ce1835594mr3967757e87.27.1719309338345; Tue, 25 Jun 2024 02:55:38 -0700 (PDT) Received: from pc636 (host-90-233-219-252.mobileonline.telia.com. [90.233.219.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ce042dcd1sm761886e87.70.2024.06.25.02.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 02:55:37 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 25 Jun 2024 11:55:35 +0200 To: Hailong Liu , Baoquan He Cc: Uladzislau Rezki , Baoquan He , Nick Bowler , linux-kernel@vger.kernel.org, Linux regressions mailing list , linux-mm@kvack.org, sparclinux@vger.kernel.org, Andrew Morton Subject: Re: PROBLEM: kernel crashes when running xfsdump since ~6.4 Message-ID: References: <75e17b57-1178-4288-b792-4ae68b19915e@draconx.ca> <00d74f24-c49c-460e-871c-d5af64701306@draconx.ca> <20240621033005.6mccm7waduelb4m5@oppo.com> <20240621111545.awvgrap2nscgehxv@oppo.com> <20240625092601.uo7266gp5joluyg5@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625092601.uo7266gp5joluyg5@oppo.com> X-Rspamd-Queue-Id: 6264418000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1t1k59tnme1uwhqp8m3ekw3f5bofu3f9 X-HE-Tag: 1719309340-955800 X-HE-Meta: U2FsdGVkX1/v5Kk5cfIW68eoj8iafebsUL6d6rFABQQ5WqJPm1M+tnDwZcyGyKnFM4NXq/vywloltopKcrgpQEhRuMw1Lx4AzAWjyCcH8va6Gxfwb07t40g7IMgnoqPoOzla3uwblOGJFHur83BNiE7usCUp6X2UqJ6K87ukUg96xM8YyTbrEK8SEG7m96fL/OljtIr/zJN+C0ysLuupxIWdG+0CYRg1wrbnPpxP9MGe8p/AnhXAvUJ1eOLbOiVsFjIyiWXyD4tdjNVsUyTd4N6L6MKAHFyQ4VQ/SuFULCPDlMoK6tKlv32/0cHFZXQwJXB2UTEXcXElZtHI0OIEZ4SCvL/9wSBhh87LNkNOuiwk3M7XUKTpNEDhGPKa48PdZSFho9U+cWpDB72cx8YcjHCda3evG5wp0Kg666wBU0Qa+dEwLVfjyaSyAUNjeps7FExEHGRqOC9gaq3EemKBqdAJRC0sllLMfKJoD5CGdUgialr8y3IhvniO8mouFxivP+TF0V5XEZTPbQYa09V0DbwaTwd/Vzx8XxcBgrMjSFVh1Im0dnvGHffKVql+XVF4pWqDXkdpN0GRK2Edae2c3TDFXGj0GtAkv5OJ6+px2GYytEVZQ4q22EIjYYLsvY9hVl5FPL0HkOiZ6A5YhDaPzrIFZaLgbYL+lfXU8J3DHLgGEgXpgyPQAqH4H7MjqxvXpAT3f54forezSWQR1lgCZ2S7llQ8EfvWy/xASa1HsbJxKt8BzMdNqFnltpeBrAVpBCKzEDEe44idH3VA+i7tE8tolr3V3jQGdGsUqHryh4k6B/DAmVx+EjL0DiDvAQoWGzKYxCxk2C9xt0RWjglkO9pGKHfWKs7ECR/HwtPD5VfC7JiBtHEREGULCE106GxtNuRhMzsafTbp10xq1+SgRVYTDh+FqiU98X6LTVo58Jv9fSGMp2d17FXS4cZjxEGXX5Fg5qu3TtD6dXjfmpS 0SQfj2aq jiP0w5s73+8t7lINQ5qdzKJNgw2Rt4QK3XjVgMRUPzuMFFNwGWsu+DSu3M3R1hYr9nZHWtVTOwpvWr6SqR8JuxSSKp6TiZbiwScBvXQ6Gk7ezgt+gkDdZaajQbe5GlX8mF6DVMQFFFL/RE0m9BxXRBI2LLsNxxfzOP7fEL4CNctupAV8WdZ83lgCdopwftihLsvDba3s0e6GTXKYM4PK4N+kpuWtZ2IHQ8tknHawD+gjrVW0uPbVptWLwPWGek5H8iblEymAGVGGD/GKryU2AmSXsb+rpdlIwnQMDHmD4KzCtRdS7095KET2SLg2NNHSwMOCyITYSnBCdmr6BbFzcWX3wW08mSaXhnZgo0BVMfURfQVA90aZBXAyeSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 05:26:01PM +0800, Hailong Liu wrote: > On Mon, 24. Jun 14:18, Uladzislau Rezki wrote: > > > > > > IMO, I thought we can fix this by following. > > > It doesn't initialize unused variables and utilize the percpu xarray. If I said > > > anything wrong, please do let me know. I can learn a lot from you all :). > > > > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > index 11fe5ea208aa..f9f981674b2d 100644 > > > --- a/mm/vmalloc.c > > > +++ b/mm/vmalloc.c > > > @@ -4480,17 +4480,21 @@ void __init vmalloc_init(void) > > > */ > > > vmap_area_cachep = KMEM_CACHE(vmap_area, SLAB_PANIC); > > > > > > - for_each_possible_cpu(i) { > > > + for (i = 0; i < nr_cpu_ids; i++) { > > > struct vmap_block_queue *vbq; > > > struct vfree_deferred *p; > > > > > > vbq = &per_cpu(vmap_block_queue, i); > > > + xa_init(&vbq->vmap_blocks); > > > + > > > + if (!cpu_possible(i)) > > Why do you need such check? > IIUC, take this issue as example, cpumask is b101 and nr_cpu_id is > 3, if i = 1, There is no need to initialize unused variables here; > initializing the xarray for the hash index is sufficient. > But. It does not make much sense to skip initialization or keep it "half" initialized. At least we can guarantee that all data structures are properly setup. One concern is what Baoquan raised about per-cpu variables. In your scenario, b101, accessing to second per-cpu variable is not allowed. So, we need properly check that concern. -- Uladzislau Rezki