From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E51C2BBCA for ; Tue, 25 Jun 2024 07:09:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D9956B0337; Tue, 25 Jun 2024 03:09:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8881F6B0338; Tue, 25 Jun 2024 03:09:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72A086B0339; Tue, 25 Jun 2024 03:09:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4B1F76B0337 for ; Tue, 25 Jun 2024 03:09:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0120AA4379 for ; Tue, 25 Jun 2024 07:09:27 +0000 (UTC) X-FDA: 82268535216.05.1C7F1A7 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 1CEF71C0010 for ; Tue, 25 Jun 2024 07:09:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="YMrwl/5+"; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719299351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U5vXRW5dvx+Syj/FK64X0BFJAcoWaIpEJ5624gNlqnw=; b=Bq6SO+i0UPDRnxd7ab1QI6ezBZu1eEfTH46MD6gnFExV0hjwHP4QvFoH0EVz60hb4TU8jR RMngV1VfkOMeIK/lu82AG/La08Mm1UR2Gu7SRdrNSq0ATdoWB4v3aMLkr4OeskWJpOSHj8 1tGWUChaer/PsdOZDXn5x5TwWnlhxjE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719299351; a=rsa-sha256; cv=none; b=DasgZV8J31IgnnyPb6u1yUDmnKyX2158P9FM0cffLG3ow9sCJ7P0XSfX4n8ImHUZHCnb3x W41IJWHr3ix1s1OSyA2KKSN7lp33sOaZxOvzjtR1XjfRe3kn9gbAHN9L5A+brVIuKOeB0m Qe9/egMKUFm3zhzS6b6LaKmU/pTC9Ig= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="YMrwl/5+"; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57d26a4ee65so4853911a12.2 for ; Tue, 25 Jun 2024 00:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719299365; x=1719904165; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U5vXRW5dvx+Syj/FK64X0BFJAcoWaIpEJ5624gNlqnw=; b=YMrwl/5+k3dS81fBGbhc5vFBcSSFuuYC+9YAPoT41h/mvqI9fOnT+qQK9dR08tJzJI +CKeCTV0r6DOc9P0arhJya+QuNISAbXVUyWsf5zKRGaf9eG0wFCuemBdz+ImezkuOyXI plRql7oxYw8lVA0CzmGH7v2cP0kZ3hk7Viu66SLhCkSbWXWhjgL4iMMwO4d9ddzCyBUU FvT22aCeIWr5Tlq3z/ntHrmE4k0PgNtRRD7Xa7QlzzX04DPsf4fldcVjhhEf+nkO35j+ vnXj6wC9G16A0YqXoV+pV6/rHgO2GxuNQveKICzJuCAL2R9KddbMfdpVrXp9oAKAbsrc pwPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719299365; x=1719904165; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U5vXRW5dvx+Syj/FK64X0BFJAcoWaIpEJ5624gNlqnw=; b=WU888Rx8E5lculLuo7xpga3FnTkFDb1gYXtD5HMl33YUgrmeQIdi+wtmBCu2VoI6YF Lhpo4pg5VntJPo0XuCnlN8rIee0c3VIQqp/goQXIVqORxd0nxI1p8o/kiJjMye88x9nL LQzdBp8Yb2z2VLYMrtn/6nG/xYWgqJnp9RUkzCWL+vVXdyHNY+A8t2MPQhx3kkPouGkI g3guyFNzQ8gDKWFch2fLIJ4H79komnaU7uLBTcgPRhQVhqNd5nU1Z4zE3Qhl7S8ffnTb JctuS0r6U7RxJF5rmp+PNA5CdPP8xfPRYkvkLWqG/E7Oo2kXsbxBHd8lbbgNDERN5qd/ S57g== X-Forwarded-Encrypted: i=1; AJvYcCXPy21HRHmud5FGcYcVA14pBNrzIkMR5+B5P69mwZEHYfyqGwLmmbnbUG/cTMsFZFyrFXEVuw5EQ5sfhZE7NqDKRc4= X-Gm-Message-State: AOJu0YzRdPcdiiUFSFkJDvJHZcC1FpANHPFB9D68bG+iDtbbRylwgPfq TMqd1Ars3FHXz0F7aCTwVg4dZ6Gf4UaI4lfYiVrgaVLeOcKT1bljeZuJbH+Sp1w= X-Google-Smtp-Source: AGHT+IHYgiKW/FJ9NFC5aPZHT8xWkLKpTuEf40vlCMNANNzpkEm7W87I3SwUfKnumikspd2mcY9LFA== X-Received: by 2002:a50:cd14:0:b0:57c:c10c:eee8 with SMTP id 4fb4d7f45d1cf-57d49dbf7f0mr4735870a12.19.1719299364597; Tue, 25 Jun 2024 00:09:24 -0700 (PDT) Received: from localhost (109-81-95-13.rct.o2.cz. [109.81.95.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d3041208esm5541172a12.30.2024.06.25.00.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 00:09:24 -0700 (PDT) Date: Tue, 25 Jun 2024 09:09:23 +0200 From: Michal Hocko To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 11/14] mm: memcg: make memcg1_update_tree() static Message-ID: References: <20240625005906.106920-1-roman.gushchin@linux.dev> <20240625005906.106920-12-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625005906.106920-12-roman.gushchin@linux.dev> X-Stat-Signature: gwyag6cd4tr8ir39okuxbyjfsjjhagza X-Rspamd-Queue-Id: 1CEF71C0010 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719299365-777640 X-HE-Meta: U2FsdGVkX1/iOVl3dLj5fjPPlIambrMICNGod9y1nCMOBogEvdgkcg1Hy+Npq3izLqPoDOtL+Ru98+WEgeCmWhM2hJXoJ6CP5XJ6ei5XNn8tV5JXEaUPHQh1LVcnvTRp7huKSEDvV/dSQX/ZN4qyysOA+eNa+p1Vph1GVDqhhRoq/7lOrqc9+w8zgMNVwZ7R5CbU1tQj2J90Wl1qbTlPgdsR4obw/dySLb/uSQgEZ0Y0mv32FfYrHD9Uu6fQ1KOcAFAzGa9fZamnFHHTFVcyDCOiT0nfRGMaySWKllSWGT7LwBLXs0RsbSFVA/wZqXDNGFiGjBh4mwjqnCF9PdQX07SwFdiGBUZT3sEW/t8ZyYslz7IE01CSCWqjOGyJ5ecI1br83028fVOyObQ3rO1LI2VjuKvT2tr24hj3+ZWjSR8T0AlgMUYitoT5T32I+xdsTeL+ji4NgSPfqwpkTA4+6HDgKlEsfkN/WGYxqk3hnY+FZOliPdmeKqNTtW5u8VHV8VNmsVwuoASPTW2fK5zIOtj3c3ZSXa+84pHLPasoMyIaW6ZJsZVPQ6XdqEdP1CczjzatQBlHMlBFqHxZ5IsBto33FWuVYBYB6ZiNbhGlGkDXp57qJzH81lNiQkrXC1AnUO3upDbGiZgr2dB9oBHhE5Rn8a+MCtzqBSqg6vbezWozWV5nNhLHFLFgwQQZmqLo3RXrlCpAtoDnTmD4y9U2BGjvSkBSwa+mxR+hRwKMB0qXUd/DZ3tynMDnhdms5cRO/nHR1AUT5Y8+rRUyIm9l34qBJ6mJMqtTrOzRlIRRShb0irlRYHcdAeHOor9Li0NtojUFGzwHFJ4uNypKWqVGAGkgWm2j4Za8MwTsao4vTjKJOAcq9g5ou/H7c3Dic6cm8wfL5rvgiTj8sF2r/16M0Ec4lsyRwD+rDZg9+TIJKNvLFKsi8ygXZu+Q4EZDiIagBIHQls/cggkKh3OarSr 3PZBa9ED lLDouPsD17kvPhFoPN+gja1gzfPtU51H3UyDYQ/Mt0/kufnRAR/yMdSk0MdUbZ+M0wAYUiHKl5Z+f5GO6Ogqc4/KrlyON2ATPDsQuqm3/DD3wcZIQMFpBed2a+B5A3TDX4zlbnWFlVkf5LGjWLlufzOU1mnBmN4fWEEUIOh5IrpyLrC592OxJdaax1QFS4HcmKkcEJXjI/l4LeY467Dcd/8xvgrPNFrvjWbSim43zkMfJ1kHPEm2qMS3Ndyd75p9jd2u3nr6S2cHoGwYQNs1euoAbBAdkH3Jx/XbqI8iMA90Vzf1+b2CT9HMLbwTBz4dlz7lZm6g0wG73TE5IDI9/6OwFC4cEJUP/0cNkepn96lpOVVn2/XwBIIUSyf0QF/LdOMutzbC5rrF6oMU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 24-06-24 17:59:03, Roman Gushchin wrote: > memcg1_update_tree() is not used outside of mm/memcontrol-v1.c > anymore, define it as static and remove the declaration from > the header file. > > Signed-off-by: Roman Gushchin Acked-by: Michal Hocko > --- > mm/memcontrol-v1.c | 2 +- > mm/memcontrol-v1.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index 1b7337d0170d..f89de413004b 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -201,7 +201,7 @@ static unsigned long soft_limit_excess(struct mem_cgroup *memcg) > return excess; > } > > -void memcg1_update_tree(struct mem_cgroup *memcg, int nid) > +static void memcg1_update_tree(struct mem_cgroup *memcg, int nid) > { > unsigned long excess; > struct mem_cgroup_per_node *mz; > diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h > index 7be4670d9abb..7d6ac4a4fb36 100644 > --- a/mm/memcontrol-v1.h > +++ b/mm/memcontrol-v1.h > @@ -5,7 +5,6 @@ > > #include > > -void memcg1_update_tree(struct mem_cgroup *memcg, int nid); > void memcg1_remove_from_trees(struct mem_cgroup *memcg); > > static inline void memcg1_soft_limit_reset(struct mem_cgroup *memcg) > -- > 2.45.2 > -- Michal Hocko SUSE Labs