From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FA8C30653 for ; Tue, 25 Jun 2024 07:05:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 098A26B031A; Tue, 25 Jun 2024 03:05:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 049AB6B031C; Tue, 25 Jun 2024 03:05:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2C6F6B031D; Tue, 25 Jun 2024 03:05:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C58476B031A for ; Tue, 25 Jun 2024 03:05:34 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 70C43A169A for ; Tue, 25 Jun 2024 07:05:34 +0000 (UTC) X-FDA: 82268525388.30.CCCFFB8 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf04.hostedemail.com (Postfix) with ESMTP id 63F3740004 for ; Tue, 25 Jun 2024 07:05:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=TPyeIaDX; spf=pass (imf04.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719299125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dRU5D6TfCbGDRiZmBlg8+VtjEI6bshTmmOYL3XFdx+8=; b=hhfxBOuTmBYBrEh0qEYnO1keUAY6qvTQztm3IVpnR7kPwf4ei4UxYcOmXtwVWh2WbSMkP2 szDlWkQIo9B7TpSa+1dXHcRjh3q0k89PHHMp2X2kXq1/3c0d+Befqu+1ATWc1vDwaLFrEa u4ngA9DVDqkZnhQnIaRPKFTTe+gE/+c= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=TPyeIaDX; spf=pass (imf04.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719299125; a=rsa-sha256; cv=none; b=gWtWgRbEKEOh82k5wC33yX31UJoY+XvvO9pjLQfHBWczgf0+EeArasizKVIQR6kc/Tu3Xv R6eC7bhnKaIA91NeyjDXcdHNMY4OhgPFTu6iHFVpbVTsHUIjyIQOZGrOSlw6HHwpXRSXoA DGmVUz9ZUVeKFF+k5FeFpD+UC6e+xUE= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-57cc1c00ba6so6291429a12.1 for ; Tue, 25 Jun 2024 00:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719299131; x=1719903931; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dRU5D6TfCbGDRiZmBlg8+VtjEI6bshTmmOYL3XFdx+8=; b=TPyeIaDX+SFOEqgxe8iMPH1hTHmm1kgR9kOtxMMR3ujIgEyvi5Fu2flXZ+lGgJsmtM 6w/Rk7T+1t+kW/WHJMv/iFj7oC/4EZDcpau791lb2BtafKOY1TXzPKJ5wtRky66Fow8Q 4cgYYSGmO6xwt1GxAPULP0j+FO+OyLKMT6q5Q1coUamfk1/oo4JrgpORIJ3SxF1JNLVZ nRNBw68mN18lm7yHPpMVK7xN3h9Se5KLbHX3zprF2nr/R+mwB4btXULJmkC4wiaFC196 SXrDxeRbzpwrlaGds57oSviCRSyKxVZ3i+B91fnprmnTvEDlHsBjgo5MKiYTjbeXZh73 DlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719299131; x=1719903931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dRU5D6TfCbGDRiZmBlg8+VtjEI6bshTmmOYL3XFdx+8=; b=wAlEDTomb5+XSQHfqxjrzS+9K2mBdyR1ASGecjIFKCgosEW0ditfthm188eqkmlskX b9dxiR7R8HtI+PDTVTf7gxRPjBeUkzLa9TOkxY5IvVJtAJzEMcj0Zcj2oaIu0vjY4s+R ttrweJwkRZV/S6cauI5POvFCP022tEmubmxZBJV0XCDl3Ku0aPjYcFhumdtUrX/zpFcs o5R4l4VVxWwTOuRA1+gzSQ4tHU5WZquLasV4t6leVnOD21e/41P7T/lSOKZO011dPZV3 sI+9sPv3IVfscnqznOgqOKQMqqtaseRtNssFUHTK+tYFqqpsXJuRXM2y7L/xoc7ZuXWE 924w== X-Forwarded-Encrypted: i=1; AJvYcCWCfWlm/M+yJd6/RVjERRRpG3iTBEUYjAAfIVzA4AIyVue++Qw4KESvOnCND8FuMVWAJ+rYDcLPBueht/Wtx2GLSUY= X-Gm-Message-State: AOJu0YxzH4L/6ckiWxhXu+HohpNQ/cxPXPTRwQCaCtXhXTwQOHxWFrPJ uVCCC8t6g09PhU8XH8VUWE/CeRUWGRAfEgiMJxbHtGReBaCtOPeBbp0FkdB1kP4= X-Google-Smtp-Source: AGHT+IFRK+lk5imMJt5M29iwxHDdbQXMOuxaGyygqaPcLVPZB9z7Ln2YwJJbnA7lqq9jY9Vh78Xqug== X-Received: by 2002:a50:a6c4:0:b0:57d:50e:d76b with SMTP id 4fb4d7f45d1cf-57d4bd53462mr3633602a12.7.1719299130392; Tue, 25 Jun 2024 00:05:30 -0700 (PDT) Received: from localhost (109-81-95-13.rct.o2.cz. [109.81.95.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d303d7aaasm5548582a12.4.2024.06.25.00.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 00:05:30 -0700 (PDT) Date: Tue, 25 Jun 2024 09:05:29 +0200 From: Michal Hocko To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 01/14] mm: memcg: introduce memcontrol-v1.c Message-ID: References: <20240625005906.106920-1-roman.gushchin@linux.dev> <20240625005906.106920-2-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625005906.106920-2-roman.gushchin@linux.dev> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 63F3740004 X-Stat-Signature: wshh9iabbqekihbr8fcjs1y4t1ty775r X-HE-Tag: 1719299132-861686 X-HE-Meta: U2FsdGVkX19aF2NRwdia0Veps7TbZ7A1JJwrVrcAIbOrxGKbyR/05730qH+Tqgipx3wUCTf3P7inP83zmoI3DwIcTc1V8RyZLcC6opRfPfpdwQl+RIl7Tj7OMUmN9XBRJJpWfm3sIJo8ilwuC+al2K1RFjPdsitPDwIPmg6unim7e9t4oNl7NYM3o9N2x4GOJhLtQ3lvgEuDkQBMMRMyxm1Jg1squxzhUAfhMJZT9naqsiSprWjvwjr6ymuhNzNUvbxwGwkttxLhTSNGh0HxppmRwU+VT0krqLoG9cCvcIpBGfrFwqugi6TR8YorfLrj57f45/t/yQo6gwYFhbQOtjd4I9tyq4VdM+GNrukTs9clnbkZ5u0ld1BtDnpYc9A6DNBBWpTj9/7cD00HZmKbY1GZ3fnMRM+F+KHHGUfpABOkwG2K9Q/HYWgiap36UmQzWYN+tcsr6ts4jVuQCbd2AaaOtW0o65w5cklCmpqp7NFQheOmaiI22hoz5XxNCfI6An62U1+z6NCThkUKUBP3ZoqblvzhoPyj6VJKaqUHjd5HBRTru76GYdGZKopvIr8i0nJJncP9jkeEVTnpP3ZJ6PW53SiLOe1gHZVSADC1CQWnPQzt33WgjLkiks/6MVNoDQn0Tv5cIhbLDc+fMTUYLux8W7kJFvOQvBA325tiSLnstX9a4vee/WkH1KFvlkqAbXHy4muUU1h32HNVtDpCHAxqHCYVmPFhTmwhq4QgOW1egA8zjCCqx2DNcXmCIIjD+pyCNfA85s4YASsVR6CJCi3Bh27oBHVAJ/4UXrccS0hauhR4l02CS/buwjRb6j2/1fhud5tTU/WPBboZ1eoPNEqjDPisTlkdGXWjF1MROUufFNj2arPbfABDyVwROhq3okHxdsh+IqxjGVE0ryxBsVybezkZu4nJRovfCNZzU4LaWrZnyPV19oHs2E10YE5NA4GUuBPuPnH2PCBzw4u GfzQxBEh QKxCQa5t4bw/WUb5pgBlZ3uola4JZF6YfA+BF164UmAgDdQ29iVxsG7UlbrTwCQMkNsuWAuQ5w2wRHC8XNbOeSFpbKPrMZQVGN1C6eu7KOCOs+r9004IpNmLMTYs+OZDXOrgG9wjpgjqNVj+4mVGpUk1557DTeUTbCo5++YySleSXIWHpl4zdybl6fM0r2tGiQaTh2WjTjsCc1+GhdIq61RydMPPTCupV6GPlNy+BxCCv3cGazAhLDPw2GgPwJYtWKS2+CsYkFZPvRSo24mpMpLUxRRsyIHyFqpzWiuJ9yboKUs0XKN48Nd9Ld0oq8xgSmLm/dzhbQwsP1fUDO54Mvh8IbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 24-06-24 17:58:53, Roman Gushchin wrote: > This patch introduces the mm/memcontrol-v1.c source file which will be used for > all legacy (cgroup v1) memory cgroup code. It also introduces mm/memcontrol-v1.h > to keep declarations shared between mm/memcontrol.c and mm/memcontrol-v1.c. > > As of now, let's compile it if CONFIG_MEMCG is set, similar to mm/memcontrol.c. > Later on it can be switched to use a separate config option, so that the legacy > code won't be compiled if not required. I do not feel strongly about that but wouldn't having the new config here already make it easier to test? > Signed-off-by: Roman Gushchin Anyway Acked-by: Michal Hocko > --- > mm/Makefile | 3 ++- > mm/memcontrol-v1.c | 3 +++ > mm/memcontrol-v1.h | 7 +++++++ > 3 files changed, 12 insertions(+), 1 deletion(-) > create mode 100644 mm/memcontrol-v1.c > create mode 100644 mm/memcontrol-v1.h > > diff --git a/mm/Makefile b/mm/Makefile > index 8fb85acda1b1..124d4dea2035 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -26,6 +26,7 @@ KCOV_INSTRUMENT_page_alloc.o := n > KCOV_INSTRUMENT_debug-pagealloc.o := n > KCOV_INSTRUMENT_kmemleak.o := n > KCOV_INSTRUMENT_memcontrol.o := n > +KCOV_INSTRUMENT_memcontrol-v1.o := n > KCOV_INSTRUMENT_mmzone.o := n > KCOV_INSTRUMENT_vmstat.o := n > KCOV_INSTRUMENT_failslab.o := n > @@ -95,7 +96,7 @@ obj-$(CONFIG_NUMA) += memory-tiers.o > obj-$(CONFIG_DEVICE_MIGRATION) += migrate_device.o > obj-$(CONFIG_TRANSPARENT_HUGEPAGE) += huge_memory.o khugepaged.o > obj-$(CONFIG_PAGE_COUNTER) += page_counter.o > -obj-$(CONFIG_MEMCG) += memcontrol.o vmpressure.o > +obj-$(CONFIG_MEMCG) += memcontrol.o memcontrol-v1.o vmpressure.o > ifdef CONFIG_SWAP > obj-$(CONFIG_MEMCG) += swap_cgroup.o > endif > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > new file mode 100644 > index 000000000000..a941446ba575 > --- /dev/null > +++ b/mm/memcontrol-v1.c > @@ -0,0 +1,3 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > + > +#include "memcontrol-v1.h" > diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h > new file mode 100644 > index 000000000000..7c5f094755ff > --- /dev/null > +++ b/mm/memcontrol-v1.h > @@ -0,0 +1,7 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > + > +#ifndef __MM_MEMCONTROL_V1_H > +#define __MM_MEMCONTROL_V1_H > + > + > +#endif /* __MM_MEMCONTROL_V1_H */ > -- > 2.45.2 -- Michal Hocko SUSE Labs