From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F66FC2BD09 for ; Tue, 25 Jun 2024 02:36:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7AD06B032D; Mon, 24 Jun 2024 22:36:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A29BA6B032E; Mon, 24 Jun 2024 22:36:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A3AD6B032F; Mon, 24 Jun 2024 22:36:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6B63B6B032D for ; Mon, 24 Jun 2024 22:36:36 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D827A81433 for ; Tue, 25 Jun 2024 02:36:35 +0000 (UTC) X-FDA: 82267847550.11.FBFFD29 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id A75D24000F for ; Tue, 25 Jun 2024 02:36:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S6Of6d5J; spf=pass (imf17.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719282983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lgjh/ZqyuyNc2ziwefd5jIC6p/c9Pbm133iPEufxgFk=; b=cjFJQwCG+MDIJAgFmJcLrqZqWftXzYFD52mDge2ZBW50TunJMT2AwPslrLiLxwRByjWpoA jbEbiLHnsk5iMqzSHmsAH9DsKiCinVW7FvnbZLvLhXVjSiWtZNzHRVpvwNivOlnCsPDHj/ BIUJN2K4VmG1r8y1pyt+BNuF6iBWRFY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S6Of6d5J; spf=pass (imf17.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719282983; a=rsa-sha256; cv=none; b=YG0EEuOshKoQN5FAUqC7/rAvnbhCOGK4+w7XYo40jJXfG6plKpdufMaV2fuW4Qe3wyBBcA +nU0pczJxaSZLRzDPVMBDKoTFtrFaXEE7oAk1gmM+nARIAxeCjGqjJiDM+I0Lp5zQUNMi/ 9VCMWGjypzCe9/ATh8dlobGQYqyKJws= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719282992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lgjh/ZqyuyNc2ziwefd5jIC6p/c9Pbm133iPEufxgFk=; b=S6Of6d5Jdw3yiPYHikH1KxuxNbJ2CbLTzI9FKc7ihXnOGKlc9zFTqZIGZxxQzvkz0Tvb7i Fwe6I/H4hy4MHtriKQW4O8xBYTxu1NIByWsFxB17UV8aEk/LcU22ZseM7A4hWq6kgJeD5H nVAwqOQFDr1e0Oig3y+n6hj/gEIeUj8= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-rHl29sXBPwmwiiW7XYgyng-1; Mon, 24 Jun 2024 22:36:31 -0400 X-MC-Unique: rHl29sXBPwmwiiW7XYgyng-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1f9e9aa8cf3so46215575ad.1 for ; Mon, 24 Jun 2024 19:36:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719282990; x=1719887790; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lgjh/ZqyuyNc2ziwefd5jIC6p/c9Pbm133iPEufxgFk=; b=sn3I6M2LHdsLPuJ/IWg8/X11mZkie+lAtztYBEh5RF+DLw8Vogi+ycgp9lVHmtj4GH wlnwuzlmHtj1B05LlcuHqOTXb+E+YQWuZTryuX+6uj/O96s0DQnBnNEFwws2SGjIgR5r qX3t5OvEzvSfO4KpT/FbCZHqg+KWQys/tL+xdxaaFKN5rX3tnjDLJYCCrhCCD1jmTUuX 80C6oSzAqQOVs4Rb9QwdigC/5N/W2drVH0snmeoMiMjboK42LyR95wxTnq4PlpNyP5w4 mm7e6ZMweJsUX0FHdlJcKjaA0WL9TUyCPGNKkqfNiU6tg9zRfz+zD2rxFfdcKqmMfCxL IFsA== X-Forwarded-Encrypted: i=1; AJvYcCVdbBfMoHUy7et5GJfVVWd35tz0MyGqKpGcHKsROd3vZxvwpxCWKO7JzGI6X7/8NC2bQG+E9VRjrXu9cqqAjSyJCe4= X-Gm-Message-State: AOJu0Ywg7ygdiWZ3zXnPgEYGxPUqf8d9nZM4FN0QRWG+gRvNWezvD7ms 1xvlEJBro1nnuXq9cRbIVi/lADbSBQZYjkZEgarukmPHV15r+CYb+v7nUAC3tZj7QerxqjhiV8W kJXE9XOIC65VkIMhbV8/MNeIb88ZzTUAxJ0/tMSAcz+TVLgvW X-Received: by 2002:a17:902:f54c:b0:1f9:ddea:451d with SMTP id d9443c01a7336-1fa23bdf3b8mr64914965ad.3.1719282990055; Mon, 24 Jun 2024 19:36:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4WMoko6gcC4VFyy3g03y2NymCh8kug4N9kCWpYbiJNlDLdPwV2S623AMwW20um4Llrvh4oA== X-Received: by 2002:a17:902:f54c:b0:1f9:ddea:451d with SMTP id d9443c01a7336-1fa23bdf3b8mr64914795ad.3.1719282989651; Mon, 24 Jun 2024 19:36:29 -0700 (PDT) Received: from LeoBras.redhat.com ([2804:1b3:a801:fda9:d11e:3755:61da:97fd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb2f038asm69440895ad.52.2024.06.24.19.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 19:36:29 -0700 (PDT) From: Leonardo Bras To: Vlastimil Babka Cc: Leonardo Bras , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Thomas Gleixner , Marcelo Tosatti , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v1 0/4] Introduce QPW for per-cpu operations Date: Mon, 24 Jun 2024 23:36:21 -0300 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: <261612b9-e975-4c02-a493-7b83fa17c607@suse.cz> References: <20240622035815.569665-1-leobras@redhat.com> <261612b9-e975-4c02-a493-7b83fa17c607@suse.cz> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Stat-Signature: s1xnd79tg8ngxiysai1iq6hf334whwaj X-Rspam-User: X-Rspamd-Queue-Id: A75D24000F X-Rspamd-Server: rspam02 X-HE-Tag: 1719282993-269261 X-HE-Meta: U2FsdGVkX1+IbgUiR34RxEzCFx4fEgvAZrXEH7D54HLHcSXjmMChhAJThvccB7c7ad00XGs/6Yb3N5IlCMcxY9L5PGs3Ac2RFUwqOMBqV6Evlu88+d+bWvlAw2YMqqNTmHBUOXTi74BdZJ1UcyPaH3hYF9ZKMyXz4I+snaeqy+X38w1NzQdhblunk7NGv5M3ZGQu7lTQm8Hi1p3Gv4jC0Mcq6DWAPSQAFVhJisbMer6GM7m7xp+Pjz+lL9JK7WutJF259MuqWLtY45VAPlfzXFXwdeppWRLhtb6VC79AESMOc/W5ny6SZDLSs73JuY5pesos7rhsp0maBqPNwBpDPO64ziPTE7ChHJIlLum477QGh55Zqg548vlXpg3671uKxwe4bgdmL7YYcUAFYk9SvXGJwGmDnqjVLpnmKfTmsrtUhkLpnvkHVwTQl/XwtgJV1r3CBY8nSMsjWxdCFIjq28+C3rXbNTxNkm0UNBzxOuaK+wtnQ24jm+gClCUIfPZyTrOS/78GHg0K5WGRGKwfUfug2tO1rknO6xqlAjAMhmUR4o7uO9+Nlyb0Z4xz9cXBO4quhCUqY+9FqDXq3u4iwwCMc8sLmEmkagblEfGQIjMKphR3JjgppCpD/c1SD/f2oY610sgiXr9o5D/YHJCCqiU17rcK4gexF/vsOhZ2eHM7OT6YhaamRyCzNpCbxiVZ8bk6SlVBm9DRujpkvA+yvhhKi28J3TJzypXKr9Qo6D7HTNxm+9xsLTuuxC/IYiPt8YBifSidC7TpT9VEyBaD60oxKNw9K84tO7De5WxLq6Ka7kg/6X2XX1iK/EjDds6tmQT9Umvv8bP7CrLqk6s9OLmB3Pnb08KivnPViS6RhW1/b5Zw3bjWeB2h14emOZ0yw5+lplYD27GP+rSygEXYlCzyWJEjAU9iK7OjJSKn8emMgPeO8m1Ockrc5bHPN0rmVGD38Li7dsdYsHccS+I C6g82qIv IQRDw1x2FroCbFZZ/wvonhtTgOJQFKupFIfH2lwjseB5q0cUKwScEKv+5C5Keaj1CyJm8SMqz8ghliApi8PAYSeQ2mhHDmNckL1xpOfrBJnY3/tkTjpPrT8uDTaR2U12TYcKOHq9rbBUwDMK2b6LKvKqcqdzvaDJ5EHr6GHyR+gsKE9P/nd+Sm3KZ0Oe7SauTZHJTOHVN/jAjEXLGLAfQbVdgmnEVm3+DCt/D0gYHsRcS2XNO8d89eUwM4Wge8yv0PGqRdhtVyD2lu6u+pdgKNFJ8NsRFlFEl3E/1mID37TgSQKkoP/NU61if5SY0RTxiMbCy1crXdQJkcyByP5CWIxgHLWh+LCKDlf1PYATVQMrlKyxGVm0IVbiQ06MXsK4LvFIxDkt5ryTvaljWEyrPTJm1nsA5Apj9kQuSzTKwT9o34V50zRHpaBSYIkSSthhwGAbUn5xJUqmZv8bvVmDtptQZ5t+zUpVSpkiVq7C8JlxG7kI+LYYZq7O9uLKEmviPQYNJPxktHFQEU6M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2024 at 09:31:51AM +0200, Vlastimil Babka wrote: > Hi, > > you've included tglx, which is great, but there's also LOCKING PRIMITIVES > section in MAINTAINERS so I've added folks from there in my reply. > Link to full series: > https://lore.kernel.org/all/20240622035815.569665-1-leobras@redhat.com/ Thanks Vlastimil! > > On 6/22/24 5:58 AM, Leonardo Bras wrote: > > The problem: > > Some places in the kernel implement a parallel programming strategy > > consisting on local_locks() for most of the work, and some rare remote > > operations are scheduled on target cpu. This keeps cache bouncing low since > > cacheline tends to be mostly local, and avoids the cost of locks in non-RT > > kernels, even though the very few remote operations will be expensive due > > to scheduling overhead. > > > > On the other hand, for RT workloads this can represent a problem: getting > > an important workload scheduled out to deal with remote requests is > > sure to introduce unexpected deadline misses. > > > > The idea: > > Currently with PREEMPT_RT=y, local_locks() become per-cpu spinlocks. > > In this case, instead of scheduling work on a remote cpu, it should > > be safe to grab that remote cpu's per-cpu spinlock and run the required > > work locally. Tha major cost, which is un/locking in every local function, > > already happens in PREEMPT_RT. > > I've also noticed this a while ago (likely in the context of rewriting SLUB > to use local_lock) and asked about it on IRC, and IIRC tglx wasn't fond of > the idea. But I forgot the details about why, so I'll let the the locking > experts reply... > > > Also, there is no need to worry about extra cache bouncing: > > The cacheline invalidation already happens due to schedule_work_on(). > > > > This will avoid schedule_work_on(), and thus avoid scheduling-out an > > RT workload. > > > > For patches 2, 3 & 4, I noticed just grabing the lock and executing > > the function locally is much faster than just scheduling it on a > > remote cpu. > > > > Proposed solution: > > A new interface called Queue PerCPU Work (QPW), which should replace > > Work Queue in the above mentioned use case. > > > > If PREEMPT_RT=n, this interfaces just wraps the current > > local_locks + WorkQueue behavior, so no expected change in runtime. > > > > If PREEMPT_RT=y, queue_percpu_work_on(cpu,...) will lock that cpu's > > per-cpu structure and perform work on it locally. This is possible > > because on functions that can be used for performing remote work on > > remote per-cpu structures, the local_lock (which is already > > a this_cpu spinlock()), will be replaced by a qpw_spinlock(), which > > is able to get the per_cpu spinlock() for the cpu passed as parameter. > > > > Patch 1 implements QPW interface, and patches 2, 3 & 4 replaces the > > current local_lock + WorkQueue interface by the QPW interface in > > swap, memcontrol & slub interface. > > > > Please let me know what you think on that, and please suggest > > improvements. > > > > Thanks a lot! > > Leo > > > > Leonardo Bras (4): > > Introducing qpw_lock() and per-cpu queue & flush work > > swap: apply new queue_percpu_work_on() interface > > memcontrol: apply new queue_percpu_work_on() interface > > slub: apply new queue_percpu_work_on() interface > > > > include/linux/qpw.h | 88 +++++++++++++++++++++++++++++++++++++++++++++ > > mm/memcontrol.c | 20 ++++++----- > > mm/slub.c | 26 ++++++++------ > > mm/swap.c | 26 +++++++------- > > 4 files changed, 127 insertions(+), 33 deletions(-) > > create mode 100644 include/linux/qpw.h > > > > > > base-commit: 50736169ecc8387247fe6a00932852ce7b057083 >