From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31479C2BD09 for ; Mon, 24 Jun 2024 15:21:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C7AA6B0109; Mon, 24 Jun 2024 11:21:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 377BC6B010A; Mon, 24 Jun 2024 11:21:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23FB76B010B; Mon, 24 Jun 2024 11:21:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05F046B0109 for ; Mon, 24 Jun 2024 11:21:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A3379C10D0 for ; Mon, 24 Jun 2024 15:21:43 +0000 (UTC) X-FDA: 82266146886.12.55F3647 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf01.hostedemail.com (Postfix) with ESMTP id 169F240026 for ; Mon, 24 Jun 2024 15:21:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BOxl82ld; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719242482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6mlbe76eIK+t44kk/XWRZhfvBA54CwR57wx+DLukPvU=; b=mTLCBhcXIWSZe+EIg1xGljR1fLiLgHrWndpEEmqV1SAgjApuFvzy0oSJa9DMHXGX8GX8Sg QdScBTAlUmI8ib0NNBhGx4TA53pRxbWAB0y+QUvwaJMWjEbhHzeOgqyMWOx7mI4lIF4VIH uLwgTOyYlzevfQtn5+36lSNVr1uSEkM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BOxl82ld; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719242482; a=rsa-sha256; cv=none; b=0yuF/BQo0L8K4+Zk6QFA282b28mrtTrRqmb6QWNBFmoqKUuklRLDaVmOFifT0rszRG3QhU hpWSslOLAO83EuJdnW1YNJqcyZdkBdjIqhOxUWFbUgUfxjtmUlRGaUCAg7OeGXzYnFKBAQ fcrP+FxlcI3trd2lf8nEHgPN//t1tY8= X-Envelope-To: longman@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719242497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6mlbe76eIK+t44kk/XWRZhfvBA54CwR57wx+DLukPvU=; b=BOxl82ldM/sEeuyRdG8oshCF6F9eOz/ZaPVCp9WOZRn5XKX2sSPGKZVal/U+0GNteeVT/L /kvORp6v/YdGVZrAu4/KgDBwWXhRnWnXZVA3bZBjwdL3BxLwDT+uyl2y/NOR2kwFHjgBOX XKwGLTr2YvVPwp2qWDmGrhD2Y4eBYO8= X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: corbet@lwn.net X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: akalenyu@redhat.com X-Envelope-To: pehunt@redhat.com X-Envelope-To: linux-doc@vger.kernel.org Date: Mon, 24 Jun 2024 08:21:22 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton , Jonathan Corbet , Shakeel Butt , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Alex Kalenyuk , Peter Hunt , linux-doc@vger.kernel.org Subject: Re: [PATCH] memcg: Add a new sysctl parameter for automatically setting memory.high Message-ID: References: <20240623204514.1032662-1-longman@redhat.com> <77d4299e-e1ee-4471-9b53-90957daa984d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77d4299e-e1ee-4471-9b53-90957daa984d@redhat.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 169F240026 X-Stat-Signature: uqckap6gbsswiohckbqdtakifzqptrty X-Rspam-User: X-HE-Tag: 1719242499-120974 X-HE-Meta: U2FsdGVkX19lbjB78I7aKSBZnXbGoUVWzp17iYIo0amdxSi0mOmwWDle0xWnlVTxNuaauSrCNR9GQ7ylkqWQMIBEbtfx2GhNtjI0Qsmbqtp5GBF0RxNrVcg6wPZsnVjIyr4brb1i9Sun1VPh1hWJXdLbt478+SkTms7rTBrDFTG2uXEtUBQRO3srWDpY4lIGl+pP6CnGpf7oAwewsD+YGZCTKEthWCepv5NPLg/Ov2fzARPM/Y3AGwkMJjmfvPYt3uf6hPgd/GixDX73Mun/5ytbsvUSW3Ae0vY9jbL9Sx5SbSG7UAukcYnlLp6fyP6JkKoby40Vzf+8jBKkq2Nh2eYPtXFxnYwo2rInA/REgbIXRy435/y29QAKQVeY9pcRUwnIqeYTaB72wYJVgwADALKSaaPyiUMowjgOWkmPtcgU8FJhXAO+/gjeWsdTK48qLtgHVLwNZR36NJ/m7STV+0lxSLA1oiQCTR9fueRXJ3mGycSMNAVkFekboy1G6lUJoUXLdjiyTNJ2XNuvYf7Q6a0+BmROSx/bcCs0SNBbBPaZssWWhHIMrkmB7YmYmATSOjb0JNA7U3hbv+F8ssBwXYlHYeoF3uqWGdDI5H4T5BqJ/eh4PKrjEwp05qL6FhX+8MFRabCqSTeuoIn0J3Igatlf7CjDVVTj+RMD3FFDE07N12DoZvX9FygXt6AT6QZfFaXlrwBSNTQrTqLXLJQxYv15QcsZEH75ZqnEamqovjWQCdF1DuDFuPengMUbmZn73Hb2Csb1M6pLXQ4NcQdnCADlViNjt6EJzUF+DBO0W5mm7/JM2EsBqPe9fyusnuIOm/l6KrAjKH3ZVXTo4RGBO/y6oPgfffE0hAiQbSTiCYV6Q10w35Wqrq5NyM1FKwJLRF75RErt5YzhPHATH14j0p/cVWThIXcEyINBoHkAXgzDAtfS4JaqvVraAeIFwWYTqfvgdhYFZYGetkqEfop dDawOeoE KPi5XN8ojg67g58Y+Qn38+blw6AzDzdhq10jQZl4VAEgc1sBrPxQf//CgwGsgNDKkVCRK7ibOKVXucHQwdzGviNUabQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 23, 2024 at 04:52:00PM -0400, Waiman Long wrote: > Correct some email addresses. > > On 6/23/24 16:45, Waiman Long wrote: > > With memory cgroup v1, there is only a single "memory.limit_in_bytes" > > to be set to specify the maximum amount of memory that is allowed to > > be used. So a lot of memory cgroup using tools and applications allow > > users to specify a single memory limit. When they migrate to cgroup > > v2, they use the given memory limit to set memory.max and disregard > > memory.high for the time being. > > > > Without properly setting memory.high, these user space applications > > cannot make use of the memory cgroup v2 ability to further reduce the > > chance of OOM kills by throttling and early memory reclaim. > > > > This patch adds a new sysctl parameter "vm/memory_high_autoset_ratio" > > to enable setting "memory.high" automatically whenever "memory.max" is > > set as long as "memory.high" hasn't been explicitly set before. This > > will allow a system administrator or a middleware layer to greatly > > reduce the chance of memory cgroup OOM kills without worrying about > > how to properly set memory.high. > > > > The new sysctl parameter will allow a range of 0-100. The default value > > of 0 will disable memory.high auto setting. For any non-zero value "n", > > the actual ratio used will be "n/(n+1)". A user cannot set a fraction > > less than 1/2. Hi Waiman, I'm not sure that setting memory.high is always a good idea (it comes with a certain cost, e.g. can increase latency), but even if it is, why systemd or similar userspace tools can't do this? I wonder what's special about your case if you do see a lot of OOMs which can be avoided by setting memory.high? Do you have a bursty workload? Thanks!