From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002DCC2BD09 for ; Mon, 24 Jun 2024 18:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F2536B0382; Mon, 24 Jun 2024 14:33:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A2A26B0383; Mon, 24 Jun 2024 14:33:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 569C46B0399; Mon, 24 Jun 2024 14:33:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 363C56B0382 for ; Mon, 24 Jun 2024 14:33:15 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D9A9EA1250 for ; Mon, 24 Jun 2024 18:33:14 +0000 (UTC) X-FDA: 82266629508.28.C3E25DD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 80C7818000F for ; Mon, 24 Jun 2024 18:33:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vE8d0lxM; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719253979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WZcanLtIBn58D6P4Ny2Mji71UPrni7o62c3guhZTyt8=; b=iAaQA3ub7CoXEUkvtcg+ZFXcINi8RazTHjzYyfs7lZPoMlXyzvaQWxlZuhOI+tldgeJtMR XWMhdt0IVcujXVHOZrGwALTC38tiZp2fA7O8nbM7FimLL8NxJRoEzCIU1uvqzn6khb6hZC 2Tz9UjIc70AlLGczlSWZeYRasi3cF80= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719253979; a=rsa-sha256; cv=none; b=sKnbLYxCOT7j269FJ5x1BIXQFZAONktlxofb8rUyvOzVgtSg5xwe+6+wcX/J4hi4HCTL4P E2W6fySO8X186uZnuR1mUT3zWu6ak+ms4YRz7cfbEG6cEFB3U6qZRqVomFryhfapdO3G5S 8QVK3/ehCJ5oTt66AlyE3xCzJxDajqI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vE8d0lxM; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=WZcanLtIBn58D6P4Ny2Mji71UPrni7o62c3guhZTyt8=; b=vE8d0lxMu1NwuMeo/zSO6sxXI1 MAkftBHbgwA3nUxh2bs88Ur4e/jcH+hHc3evS+hsel7AmiPBbPmcRjTvND5X4q/ji1hRwt+uWMpM7 ThFHA2WduMwXYbq829XqW85hPpuKZ3Cp0opoWIfMvIs7ni2u0J+1LJx+GFQiR2+IjnAmu2U/6Fe0r rliQ33+pB+UnsMVIBemr2MrS3RDi0mI09rCssODQ7S3PvpZ2f8HaBHaw71Q0OK5UWluaf+CpCcGPj VIgV5gtoozfEcrM5ChzmD/E9XmOntKir5GyNVb5JPH3EfL8gdsyMODSIpdYa8XeDRlEZc2D6pnjwH GXiU/EGw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLoV1-0000000AKbW-1xRU; Mon, 24 Jun 2024 18:33:07 +0000 Date: Mon, 24 Jun 2024 19:33:07 +0100 From: Matthew Wilcox To: Yosry Ahmed Cc: kernel test robot , Usama Arif , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Chengming Zhou , Nhat Pham , David Hildenbrand , "Huang, Ying" , Hugh Dickins , Johannes Weiner , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [mm] 0fa2857d23: WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof Message-ID: References: <202406241651.963e3e78-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: 85ke3khoeidu59y9qazcf9oa5wqqjfsf X-Rspamd-Queue-Id: 80C7818000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719253992-93780 X-HE-Meta: U2FsdGVkX1/ndL91SglyPfmm3oYVm44aV5E7u3JrqebSoS7flHWFC0DwEO5puQ6uFjD6o6bBAKhQGVdoU7FgHFj2wKxBf7ELMs1caLbfNBNTVFWj6LH1vTEkhfDd+6NKk2ffTKxl1chOf44jh09EaVHlxufEiGCMLx8+IjeadnTSvfLqXPp35K+UHD50G/TgdFeNV3jJCLPjrfnH1Z+jTDIZ1wPjcYzXNLHYE9jHk4QFfeioiRcizRzbDLV3eVvHDV3bmp5bIdZSnnBWCXSnHjbSPvitf6712s3TxNOxdm7eo94BeGVD+qvdWDfnJ8mQrvmF/M+pm6+vKqebOoIbRPEPaWRPPiH3kIulBxEr6Wqnx2laImkE3qP+x4LMv8aRIdwsu4qkHhpw6oyT98N/CfqKKa21hoYOkQMmOZLcdYjf91Fb0hNcgbD1AO0kd+YWbEL9mTZFG1vEMgv/25+opfss9cPqxavDDwsQhT2z0eIpyW0eqv6zhFsGrUrcRmldADzuJWBeSk8hI1NpB9yIHt+UhBwgL1TYv46ekVuXNnaO5gj1SZKidOntDHEOLEKAMTW4qb2MDKHpZk0u0PGj32+aNufnLNbPKPnYrZUPNaajZK3VLF0f7ye554T8885AhlKQLFIGHR2Xv/0reFeusxzUjU8uD0KOrctV4tNdrBQPjm/OH9iDmphDOayoP27VN0VLwFYdGw1Hrkv93KnNk9ICjkaEfTpdt7dLhVUewOmcr7Y9BEpFCszfus5TyWfOksZbHps3yfderWhx734UhseiJijzKEdte08DhpguXr4zYKeNxRJdC0lJenOUUnAx60VMiMG7iGUoRkJ/LT793bma7Xj6i0c33KCeRbqOchQTqmztsD4aDqriK5Z7R/dr/zM4zCkDOhCirrJ30FaiNwFgFjmJpOFbbEZmcOWohhmjjg1vKD6D4kiEBpZjA2b2SozmMk8LLLHf4eP49X5 I3/VahLM VDEj4weK8R4MSB01ebH3mCFdp3w1RBb7r9q5crMyZQ/0sqMS05uXWRUepSfNKhxXkCgRif9tGzwKbc1hQVbk9dqsT8SuIkp7BVN8YhMM1xOTq/Yc7ukBmRWQi3szA9hrlJzLvKfUV8eu1qZZOeM8VBOYoyFuHc8c/Dbi5L/PcWyNwJS/m4nQ6YR5VxmMAXL0S2ESuETkOOJPhypxlkv+2fFoIWa+hcWx6BjfcHXYB6qSdF6CbF0NAXgnYDUEIQCGBMnm/qyXS2TFob0TSZrw/WXMnhJDIWSqGFkQhcQBiSwVjMy60jZwXvVyggZfpuxUcB9jmZAA3ReP4tCGL0X9LESpGrRBBBxVfGXDhwW0C+ujPblE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2024 at 05:05:56AM -0700, Yosry Ahmed wrote: > On Mon, Jun 24, 2024 at 1:49 AM kernel test robot wrote: > > kernel test robot noticed "WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof" on: > > > > commit: 0fa2857d23aa170e5e28d13c467b303b0065aad8 ("mm: store zero pages to be swapped out in a bitmap") > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > This is coming from WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp), and > is triggered by the new bitmap_zalloc() call in the swapon path. For a > sufficiently large swapfile, bitmap_zalloc() (which uses kmalloc() > under the hood) cannot be used to allocate the bitmap. Do we need to use a bitmap? We could place a special entry in the swapcache instead (there's XA_ZERO_ENTRY already defined, and if we need a different entry that's not XA_ZERO_ENTRY, there's room for a few hundred more special entries).