From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5A4C2BD09 for ; Mon, 24 Jun 2024 12:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECFF76B02B3; Mon, 24 Jun 2024 08:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA72A6B02B6; Mon, 24 Jun 2024 08:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D482E6B02B7; Mon, 24 Jun 2024 08:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC4B46B02B3 for ; Mon, 24 Jun 2024 08:18:49 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 69035A0EC8 for ; Mon, 24 Jun 2024 12:18:49 +0000 (UTC) X-FDA: 82265685978.16.9906F24 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 720F340010 for ; Mon, 24 Jun 2024 12:18:47 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=htW25T2x; spf=pass (imf07.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719231514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pI+IBO8mbNLx4EB6hYvwY+pSQvTtQIyHsgLM0FFnMHc=; b=dew8huAvw272espi48PaXvwGSBd8TtD4G++cCbiSMJIRDS28fOcGwm2jauy6XfY26Q58Gn vditAqFr2vlcP7V0ckdH3ZPC+F6WL1VnJmxEECnXhVSuin/3hfNxafi5B9RCAjaT8wCyF6 x9tvrtVsOKSjxOVpx0A4znell5u2KE0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719231514; a=rsa-sha256; cv=none; b=zII1cW/1uIvVepzW2OsarYbEj4HI7V+2YEc9GhjxtouCARrXpTWQiQ7yGn5x5ftcHkmARQ 1CyXNzOBP8iCG/dx1W0s/ew2chTFfkDrtIS9VKZcfb12bfBnUnGmdBdPQHnujKHRYGn0U/ 8Db0bwA4NWfXTIPXJxMQwNUEnVMDOj8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=htW25T2x; spf=pass (imf07.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52cd87277d8so2593365e87.2 for ; Mon, 24 Jun 2024 05:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719231526; x=1719836326; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=pI+IBO8mbNLx4EB6hYvwY+pSQvTtQIyHsgLM0FFnMHc=; b=htW25T2xz8hTWFgQ+EpYgPQf98Hh3YphaFvifIGkL2KCIw1YIAY6l4yLjc6tT+ThXQ wKYHBJ6m3YcwIAi1Ar4MSyAMOlrUbyu4Yq00u8EpNj4AOqNObRvO2I4LQ1atj+DpO6MC rpi4eLguC+TerH3AugozrnmYj1V9+Nzzr/SA1JnLDr2wpUJ1d9TJ84ttMhu+tHA4h/7B vvZYyrnU7v1JajP3E6pHzVW19Yfh2+o+CAGPQDFGdsv29P/W2HOuv4c2tuSoP7Le3v4d A9P1xp9knYFOUwu6acOsRRQW3ENwMSodqlfSJkN2aOAjwQGqnrHJTc+dFKuoyJoVH6bs 9MxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719231526; x=1719836326; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pI+IBO8mbNLx4EB6hYvwY+pSQvTtQIyHsgLM0FFnMHc=; b=u+i4pIw95LIXdIGYI+T3bobF4jRO7ZsO8Ey/VOcD1qQWANzWgesldIpYrXF9n/T7Kc HFSfOdbEU2kixCZadAEAUXe/gyNNFLnjEFcYzK0nAlABVCqKlBSNChg1OEIp8Z0zZ/Ub C+hjwdiPxjlzqNHHPtMaGztfIHd77CkiTHGIX5BsjMT7QGxYwjirykq5Ck6svQN1JVSt Og5xpAZ33eFXXJ8prYJEQfHML+BD6fhZnuDFqtefOuYGbQoskhUNb9yDH1qtn/HcXGIB 2GyOetI7xZX+d/JYb/p2ABoES7cFfNfPh44OnwUI6u8kuAWj5UVuNIL3/ytA+HjO0BYd 2I4Q== X-Forwarded-Encrypted: i=1; AJvYcCWckIkKYABDvLxvIu0IGfMLyakq3bDK+w8Z+X2uXGgtyIaW2tVqcQgunbhfoF2vxMW67+SAWxskuCKtWGhGYqepiSM= X-Gm-Message-State: AOJu0Yxa+npQYcvMgie7pBosREsaCX6sDlFiGi3+5EbhFIeHlaC1ktDw EmatfqxLCIX/NWwMV2zXtzO+Y1O3DiTZ8z+15vwHZDWbjnwYYqKx X-Google-Smtp-Source: AGHT+IGOhdNKCJLKfAuk/c+639B/KspuwzTM0seZDswX1n8I2/wI73HfO1Ej7KKMpMuoOrjlYz8GWA== X-Received: by 2002:a05:6512:3450:b0:52c:dea8:7ca0 with SMTP id 2adb3069b0e04-52ce185cf71mr2383149e87.55.1719231525645; Mon, 24 Jun 2024 05:18:45 -0700 (PDT) Received: from pc636 (host-90-233-219-252.mobileonline.telia.com. [90.233.219.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cd64390d6sm981488e87.238.2024.06.24.05.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 05:18:45 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 24 Jun 2024 14:18:43 +0200 To: Hailong Liu Cc: Uladzislau Rezki , Baoquan He , Nick Bowler , linux-kernel@vger.kernel.org, Linux regressions mailing list , linux-mm@kvack.org, sparclinux@vger.kernel.org, Andrew Morton Subject: Re: PROBLEM: kernel crashes when running xfsdump since ~6.4 Message-ID: References: <75e17b57-1178-4288-b792-4ae68b19915e@draconx.ca> <00d74f24-c49c-460e-871c-d5af64701306@draconx.ca> <20240621033005.6mccm7waduelb4m5@oppo.com> <20240621111545.awvgrap2nscgehxv@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621111545.awvgrap2nscgehxv@oppo.com> X-Rspamd-Queue-Id: 720F340010 X-Stat-Signature: 9i9ahnkw4xywaonoe3iixgsiq41suww7 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719231527-15415 X-HE-Meta: U2FsdGVkX19tz5iB4Lwgq12ub+0ZBAIfyIUNCPllLwxBXZvCzrRJ3HblTr70rrvmKcbeN8+ZJPRneIYhhNF/Ds+EtMTNrRgId/xOLBwWTywoLNtdYyruV3Sk9i1wxfuqYTlOtg/gjsFYq4nUwhxWvViVmYh4UTtCV5WwAlVagGbOvkno1wwuAFaRfWdx7tQVIuFMdWqZ1wmDTQJ1+8vGJx/8QEQV/WtP1ay3NCnk2Kq0L9UN/weSaN8UcvjMa1E+lnoJrUlW9OcB6Zk83BdwmM7gLAzZ3adXS+vJ6AFSEiusyc7vLBcZYlqA5pzRt41pDfXOoqQoMdWzCk5S6gJ8VlXum4SEqbyWPpPm8ZRcknVcUF7dC7Kjzb/xuU0pklhEoiQ+c0EAAJTCNe4jlmJF8kBq8+XUXWm1nE9LiBT/KPjSQ5j5AxnNyLskIQnxPSaWekBNMnW3ZxXNHe7/3A92mdW6cKxi3GCbY1jOP1ozmWCGvTgr/1EEL/a78EsQyn37y83Ja2lUycwiqPGCdVgL6M1UFV0TieCChCgGE0mfK5BL/0fykcYgj5pQwZFAmu6qzJIM41xIcx26/UbPO/EU+jrGkd+hSuc3g6NwF6FUWNQJkUSQe41uTzZTrtvs4/oW4+gyslwRAT3CM1Py7SmCcNIWwwrNJvAoSfoSgt04jhYfymrzFWJFaZvy/WA+Koiehh10e3pamCbInDyVspfgwR774Gxbdf2JM1/L3xhPFF0C9YTCCRbjaOkNRi6+RttzGK8XzCwYP++57liFQ/NF7a93njoot1xCMlgbZJOpxSnK2EzLHC24MVl6IduJzLQgAoP8lNH2EpTSZDcBXuzXveMyluX35UwJzHeK3wfwAC5D8dNjhMbSjOLsAS1LYiVGAuc2sZhlgQI7HawpPtCKvajUNPq8KuhvX2nkZJL18bLP02PxMVNf3xstdDXi16K3w4KaAdg9MqEQV//e9mL yYXhyRkR 59oTyKFjQqUgj3P9D5CBYd3B+kQJGcfjFGbnxxfAKgpcIYIi0H83roaz6cQ80r7V1QNdJE71HNb2xbH2iPZvcu/lKpBGW5hlPdTK50msD12YwSAS/89u7LHNZH6AUWw+7mqK/w3HYsToPMggqErBYYBXc22YR+2UFwSAP+GI2fceN5oFAKjkc++p1tFoHVrg5lG1QR2FMlN3uu3uF/kvkoHAR+bqJ9Y0+w7yR5+UkEnGPmTcsjffyrbio5pq5rAbsK8qzvFMaYm6KgzVj6rcGX9UsGBsuyLytdpAejvBd4hvyuhg0JeiaNbmirAw4nF7UwDOx6fLMgKxq4IvuLopNuQ62LNb9cCqPNrg/O4Un8yAgEugpyygovn4UXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > IMO, I thought we can fix this by following. > It doesn't initialize unused variables and utilize the percpu xarray. If I said > anything wrong, please do let me know. I can learn a lot from you all :). > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 11fe5ea208aa..f9f981674b2d 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4480,17 +4480,21 @@ void __init vmalloc_init(void) > */ > vmap_area_cachep = KMEM_CACHE(vmap_area, SLAB_PANIC); > > - for_each_possible_cpu(i) { > + for (i = 0; i < nr_cpu_ids; i++) { > struct vmap_block_queue *vbq; > struct vfree_deferred *p; > > vbq = &per_cpu(vmap_block_queue, i); > + xa_init(&vbq->vmap_blocks); > + > + if (!cpu_possible(i)) Why do you need such check? Thanks! -- Uladzislau Rezki