From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED5CC2BD09 for ; Sun, 23 Jun 2024 03:11:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5322B6B0580; Sat, 22 Jun 2024 23:11:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3726B0581; Sat, 22 Jun 2024 23:11:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 383406B0582; Sat, 22 Jun 2024 23:11:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 171B06B0580 for ; Sat, 22 Jun 2024 23:11:35 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8179DA1855 for ; Sun, 23 Jun 2024 03:11:34 +0000 (UTC) X-FDA: 82260678108.23.E8D788E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 8B154140015 for ; Sun, 23 Jun 2024 03:11:31 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gXVx8wQO; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719112279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y9uWSeBXGFFkTKzpeCZedo92XcBKtugbjarhe/W3XfE=; b=G6061qhLqrLyDfPi9Tm0bE1FXS26FyjKAri3MF26vLvLYAHPFGvcEDK3ezMnVocF3/I+6f 69EeD9TDUxnhTMmaW8aJh3dJoJd53KhUDSsFbzhlW4vJBvukti1Zyo9UI3PirY+LDQ1dt9 0R7lT9bmb424qJLwheUeJcvmBnJGWHQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719112279; a=rsa-sha256; cv=none; b=d7syWUkdq6bS5vOYaZF0nyqoNTAFJXOKln8QbZCn/LEjmH0AuXiHWDrM44WNbOCUUSjEGD wXlUCUHUSFF80W7RTf7gqpJW+LGKJ+Dk9rbvQKoRn0Dnl1vLmxsflNDElnlkS7tu+LFlIO +9Kaxwc7Y8kBqD4Af4p4d7BT8fVHX5w= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gXVx8wQO; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=y9uWSeBXGFFkTKzpeCZedo92XcBKtugbjarhe/W3XfE=; b=gXVx8wQODxcvu5+RNSe4JuP8dx 8YiG5Llm57Kofa9LcDUF50LviqbVQzF3RV/awxWZw3StuN4cblmBdraMszSMKhHYgo8cO22aBvBp/ h8mbYDVzId4UL+Svlf+mV2XV5MBhLZC8ubx/yBcXGFp4e4uG1U+o70EKPrhti73Djzw7Ot1yur4Ya IWnDexW2JlS2AUlNYplSpJqG5twbYdclTTbJIu08AmIt37T3KYHrtiUMsKdxo26LwZmX4JhGtxGrT COledEBuTIjN8iUsEFVTQxiFX4ODRTnxF5NCfzVUnBw35s1gKe7cC24wLu48oGlWKYySg7vA4zgBk QclIweFQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLDdQ-00000008lfC-1wDX; Sun, 23 Jun 2024 03:11:20 +0000 Date: Sun, 23 Jun 2024 04:11:20 +0100 From: Matthew Wilcox To: Yafang Shao Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} Message-ID: References: <20240621022959.9124-1-laoar.shao@gmail.com> <20240621022959.9124-7-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8B154140015 X-Stat-Signature: fscu6a69oh3mkk87fmg7iwtq5uiifb4j X-Rspam-User: X-HE-Tag: 1719112291-688291 X-HE-Meta: U2FsdGVkX19P7JkK9c430sHbFL2VfvK+/ZU1HaYq3BeF1JHrIFTV20X/50ODbuq7rwg8AOmoU9CcJGNw0nTPKrcOhpys5PeNMHfwxW4RoU7+F2lp//kGqJ+he7d/ynwuElY/uX5jcN5vkdiXbQd1ADp7ckBpVKlmTy2XveRc3Sz/Fo1Xu8enAe9q/Cblu+eto2Fil+ruRKXT0Q61ehBtzmkx2JwJFGazAdqgUO8scsIH/ekMn3DdQnpdvxvXQwLPvP0H6uv9jJ6i47wc5IGOpBULZWwHwzrEZUZTo9ld11nu2mAQuK2uMtWafy0dcuoNrTH1bNYauVTyfxH/lTimsFApmbSDMNsEEv4nZAVYTEGYNk3iOTZJcV+jVSBrfF3uayNSxTcVU4Pc+cECNWxX5/RkvGJlWAw0m4h2QZAMjZTOKZMJXnHD8ypM8B5NBj98rw7JhohOBNlv6gV74v1jSqVGmo9jje5y7ekWEKxBKjW19KX4ZyqutNRAa0CvpelERuc3Pozt0KQEuJ4VULXb7SybDQ9CCcJ6FKoSxdWFMs1ZoHpdWZEWW8J4lrapbiziHyaEa8S3WxLeX2+JYDGmRXMmgban2tWHRRAZBwCq5VVWyvj+Q40glnImNqA1ws1VZs9Unob/6On7gMDHuI/WkrK2gILaDFfESvqLZyCX589tSbBbIQ7LimYl8OLlbvRfmXdpuoiCFhwSAwL5nnFLFwD+/wPw7cZcy5U6TEow1DDFlTaSCrSc1eItRlBcTvmYkIG+F1fFOXndF5Vpiwi82Riu+Xil4nlSl3Wbn/bfsJK3d+ID+fiOQqa9MKLlG2hcIcqG2shrwQpSIx27P1iEipnu3408wrxruW9BXUgAwC4yczlxN3Yq0F2pbOcCH6X9wRTB0FNXHxK/mSYJZi3O98SA0WFhtc1MIhWVFhqarTy+uTckJJmi2mr3tsKXYWo3s8Cw07wPyw/dNDOY8iP Vgy5lXop o6LWbIgJe5LwH9sVXs6hqckWz3+N6Aam1yk7JP1wqm7GacjtdNbW2ll91iogI3Vf4wRXxhWeaqWef/5BIy0MtfYQYIYJ92bC0Wz0o3LahJa7Ql7C5cVzf5XKTsND/AflfwGzlrq1h67nB6TBAgUWH0C+/v7PmI/Y9jsR3dmxYL9R6yaovYp/l40obDkwoLThIEO9yrFQb15iqERddyE33DN0rQeXZf/y8MC0aZ4ljWHcPpcbRh9K2WpvdGcDtS9T2PTvv0sliqB36wiXNwu0bgbFqIItKknKCBgs+39h6HoyJifK8zlgz5rd1pYwLtLKoTFGwxxXNXm2gl2FOG9aYaweT0lV0zaYz7vD7cT+bMvJrEzgeLH3SuxvuloOLAjSJ7JqzwBrQxokGhzND66OH99aAVV7A2SmLaODd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 23, 2024 at 10:29:30AM +0800, Yafang Shao wrote: > On Fri, Jun 21, 2024 at 9:57 PM Matthew Wilcox wrote: > > > > On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote: > > > +++ b/mm/internal.h > > > > Why are you putting __kstrndup in a header file when it's only used > > in util.c? > > I want to make it always inlined. However, it is not recommended to > define an inline function in a .c file, right ? I'm not aware of any such recommendation. Better than putting it in a .h file that everybody has to look at but nobody uses.