From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE18C2BB85 for ; Fri, 21 Jun 2024 18:14:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5B106B065C; Fri, 21 Jun 2024 14:14:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0ACF6B065D; Fri, 21 Jun 2024 14:14:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD2BD6B065E; Fri, 21 Jun 2024 14:14:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AD54B6B065C for ; Fri, 21 Jun 2024 14:14:05 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2F571160EC8 for ; Fri, 21 Jun 2024 18:14:05 +0000 (UTC) X-FDA: 82255694850.12.54EB40B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 10FF9C0005 for ; Fri, 21 Jun 2024 18:14:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=exm+5gBM; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718993632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8CaEQPz8O8rxqBnGpTbHDs7svMvy0Qf5Sggnc6KPEyQ=; b=l4o5w/2GYNh1nNF5e2HeVCP+TMR1e9McHi43MjRDoE4A0ZS0ibIROWxp+Oan0HFJGvsD/A x9LSBkrxzakKGri6J1zltH21It7EAwsgGokw02LNeD6kxAa87PYZae2Z8EyvQ+ti+yewaU NDOSQBhxUQx5oAedkAwF+wjoaIlOlLc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718993633; a=rsa-sha256; cv=none; b=TU4Y8O9q4NDFD8StqF6jcE8N93GgDL0x2YbWFW1phPt+heZ2jD2WQD0R5/97A8wZTjBBkZ 696pdiWz74Vi5/IJjb4ARcUhTexMuBmJLVesdTY4DwAxJx0Rd72HTy/s2OBTTCkTePjDJK 2Ri4f8YhfFVSZo6Wx+QQP/9HiGK7/JQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=exm+5gBM; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8CaEQPz8O8rxqBnGpTbHDs7svMvy0Qf5Sggnc6KPEyQ=; b=exm+5gBM0vKdyiPkc7w8hOqrjj EJeERKQpbiqJrHqYCBN/yoUl9zH4e+9TFixngqwpq8dNe0itUlJM306cfIbQJUCyhwsQRWeLwRqG0 jTRg+tTnsG3555RsrQ7boEfhZgsL11xqGJlTfGQKrmAIEAOR2GaNFel8dxH44xyV8Y6PxQ8zrmWnm wUfzLN1lQroylfu0JiBm0SaUTYnEPzmXtREvm3ZpHekToDBrwBdtd6NZQW5fT3SDCg0z8bhOdctIb CY1HRGUfQ9W9Kvr6zDlmGvqThfIN3V389zOUdukmSwKds3EPkOQpdMMfRq5r5cPnQzuKwAGNGIvtd Eky3gdAA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKilq-00000007T4K-03r0; Fri, 21 Jun 2024 18:13:58 +0000 Date: Fri, 21 Jun 2024 19:13:57 +0100 From: Matthew Wilcox To: Shivamurthy Shastri Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, anna-maria@linutronix.de, tglx@linutronix.de Subject: Re: [PATCH] mm/vmstat: Fix -Wenum-enum-conversion warning in vmstat.h Message-ID: References: <20240621111604.25330-1-shivamurthy.shastri@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621111604.25330-1-shivamurthy.shastri@linutronix.de> X-Rspamd-Queue-Id: 10FF9C0005 X-Stat-Signature: jb1kmz8r6kctgduyj1kbqhzh4i95jbiq X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718993641-177603 X-HE-Meta: U2FsdGVkX1/mIgfrjlDGPy92ylEV9E+pxUkqRHBcJzDx1Ss4dTdN7SJhpzKhkoZo3+bDJEcPcxyeVeYoCLU2RQ60zWFhr0ELuVtxemIekLj7ZccKuMI3Gq5BsX5JRt157EbKtBFk5zqFOFYInzg9p4YPauUKa87aK7NVnA8Lfcq+ILmASjsTezVt48a2Ted9wRuQPdBssN794sLszVRgkk3nhy6FHngCOHRbBdQNmTJEaEtx80v0sg6DmlekcuijDawjATAYexMplisAHSDY2c9gfkRqbGq7K53jDJYm/q+HVpGcb13/Jjz4tNzHGkG6hAH23qyI1XDFhARpf2AGQiKCMf97nxmR07Vr+fCk8YBW7bo3PZrcJ/Dp1L3qsLruLJJv1xLTQG9uTAZWRb8pfK1OJMrw5rp8IKcYq5dPZiMfgDgdLKssRmWlTT5JRXlMewPVFxTrRanyVVuGxSkyU2TmnpzYKZUfBDhS7WSB631Imo7l4HZe99pQW2VvpPOpOLnhMSFnT3MFcJjCP9afbQNcHz9ywU783oayQPsuATAf2DMGm+BHOm5O0oN/oJfY37NB0/IcdMqEzzUXARGM4s2my9S4Zyjg+VOJFe0U7nuRVdEJHw6KcpGQLL/YH/fD8MWdngZJWBqe5UbxNAmXA4oPzqqF0XZnj7V7lw5DMVQ+82xcGBfgf033+ykDEXvUqHsrhWTGZXnDmAOCwXzt2DrXEC4g6vaDWVSyG4b85tCLD9b0YlvGKPz4eY5yYBXYUXrAOyMqPmY6EU+OIxmgaNyjFkiR9/iUzVoIFYXio2Lyfepmqm0ru5yiLk9RfpWIT5td3dBAdPr5M6MdifoLhKRH6KFpvFaSFWQ4gy9CqiQh2dwiVxgBlsjDsyj4geulsIuc0HlIJiqelRudnTYFF1a/fMCCe4F3nbkDpC9q/oJTvJq1RwZvZfsoLJGMCBaqcpHA7ITRzGveuWHBTmh Evj4G0p0 hybRhdmRKVFiiFxeWPLhgIiR6YmhReALKXupuBTOsU/eTPRtzknhP1+6mF57JlJuHEx9Nv584QrTxIvWYQc/xrzaZkDZ+diqXhAhLtRv2vI6vguv7cj7aHaBUfuffWdN/Kae+hceQy703UJy79IPZSpUZyPA9kfwDXbrh2I83i4briJCy+0uEZSm2aOvph2ZwzMQCCU4NzlHdXK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 21, 2024 at 01:16:04PM +0200, Shivamurthy Shastri wrote: > A W=1 build with -Wenum-enum-conversion enabled, results in the > following build warning due to an arithmetic operation between different > enumeration types 'enum node_stat_item' and 'enum lru_list': OK, but why do we want -Wenum-enum-conversion enabled? The code looks perfectly fine before, and now it looks ugly. What bugs does this warning catch? > static inline const char *lru_list_name(enum lru_list lru) > { > - return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" > + return node_stat_name(NR_LRU_BASE + (enum node_stat_item)lru) + 3; // skip "nr_" > } and honestly, I'd convert it to an int instead of enum node_stat_item. Because it is not a node_stat_item, and it wouldn't make sense to add two node_stat_items together. Just like it doesn't make sense to add two pointers together (but it does make sense to add an integer to a pointer).