From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DC8C2BD05 for ; Fri, 21 Jun 2024 16:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 958448D0181; Fri, 21 Jun 2024 12:39:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0FC8D0170; Fri, 21 Jun 2024 12:39:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 733018D0181; Fri, 21 Jun 2024 12:39:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 519EF8D0170 for ; Fri, 21 Jun 2024 12:39:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EAE0B1C0AB1 for ; Fri, 21 Jun 2024 16:39:33 +0000 (UTC) X-FDA: 82255456626.25.E08C6A1 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf30.hostedemail.com (Postfix) with ESMTP id D75DC80012 for ; Fri, 21 Jun 2024 16:39:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b="MTFU/yVI"; spf=none (imf30.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.208.174) smtp.mailfrom=daniel@ffwll.ch; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718987960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d+B4q6j7rnOa8lY5YGMu4l7DUBInPDPw5kUdlNxco7g=; b=gC2L1r+VOd4yBa5YOu5u2RFxTAuGMv0wQMnIERsCgP/9szUg+9/YgXL4o/CZI/LTWQeVtz YrbPEhFu+ib2bOLETcNAN8g4NUjqAY6Q7PntxWKjK2M+nUYCAkS9Ebqlz4HYN8FdD1NNDj 08I+KDKWU3K+1YY4tdC6/OIiazdGMLo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718987960; a=rsa-sha256; cv=none; b=bKVD1ExSkTHmpufm5AJsIcai1QUQR5UvgDmwlc530GjbuC0KoIxgdzeBP58pYIVeRGD1Xn u4/fODwKC3gEQFhs+6H/uxv6T5z/CNCyLXfGNZnCwSrhw5sSghTkdMoiXcoebNrMaUZmfE VuubOoC9F18cx6IgWWLS3v88KT8Gt4Q= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b="MTFU/yVI"; spf=none (imf30.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.208.174) smtp.mailfrom=daniel@ffwll.ch; dmarc=none Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ebd6ae2f56so2920651fa.0 for ; Fri, 21 Jun 2024 09:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1718987969; x=1719592769; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=d+B4q6j7rnOa8lY5YGMu4l7DUBInPDPw5kUdlNxco7g=; b=MTFU/yVILa8/wFhbN5mgvUp1kp8Gu5S2HfZqj6Pt3S2wae15Jf40TuYIGFEK5LY5g6 1rZLJYAeSiWxrmr8+xQaJ3YRkL38OyJaNVLmrg9XzdBtomfkw0AGioxLkR3kx9N7NXSH kole1nrOe9dq3bs9eAiCwScqKTfwwn7vgUnnk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718987969; x=1719592769; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d+B4q6j7rnOa8lY5YGMu4l7DUBInPDPw5kUdlNxco7g=; b=SIIA3M5Yro8I/0A/vx36rj6pwHJtfjhOTmtlimF2UPBCVBp1M0evUuYVnZ9JeL+VKX fbZXBsOgugTi585dgJODEwjpmK4AnhNYu+2uvprcp7W68mCE5CNceFMtzRcXqUATVZuM tu7CeyWLp/dy1u45fS6gMuxbKQNYfzK/n7sw8MF4ACyv/AJrwoy1Ux++BiWlppsxR+c+ RWAr5zliJUVY6OLf8PctodJZYWAbr8YGDbQ26lG7vii3lc7hJc/NJfVAOpnEYwMd925G yI5/UNBJbbAL9NmP9uWHgtGjbXlzU0gtUlz+q3xWrmN8ZN92n+qrCClvSgZvrr9lHbsy e9CQ== X-Forwarded-Encrypted: i=1; AJvYcCXhToUJYeqzeFDKhSxDl9qKfn6QgTKmgFZAlr7KMqMW3cbdem4AAei/mdlbuxeDoc8+OMrMFdc8j4XgH8bL97lTm2A= X-Gm-Message-State: AOJu0Yx3aNGW43xuz88QkligZMx4X6Op2Gsz5+LYZ9sLO0QMHuJXBXkh rvI3VdzHvbTKgGwHcEcZBAtpsY83qoxKUB5QS8nZuU7mD1pn/SEOVKUy7qnQhLM= X-Google-Smtp-Source: AGHT+IG0ddJjXBlSpbVZD4r9/H9u00KEsN82L79oP/i1sXbnFlr8kZL72WUFKn7R6WiFRcw1OhTvRw== X-Received: by 2002:a05:651c:1a12:b0:2ec:5365:34d3 with SMTP id 38308e7fff4ca-2ec53653746mr3909701fa.1.1718987968916; Fri, 21 Jun 2024 09:39:28 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663a8c8960sm2247234f8f.100.2024.06.21.09.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 09:39:28 -0700 (PDT) Date: Fri, 21 Jun 2024 18:39:26 +0200 From: Daniel Vetter To: Yafang Shao Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: Re: [PATCH v3 11/11] drm: Replace strcpy() with __get_task_comm() Message-ID: Mail-Followup-To: Yafang Shao , torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie References: <20240621022959.9124-1-laoar.shao@gmail.com> <20240621022959.9124-12-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621022959.9124-12-laoar.shao@gmail.com> X-Operating-System: Linux phenom 6.8.9-amd64 X-Stat-Signature: tkm36a1g7ncdido14r4rc9tsr7jqrrgz X-Rspamd-Queue-Id: D75DC80012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718987970-60998 X-HE-Meta: U2FsdGVkX19N/qTNhDdAxS6XrZ09UyyYzwFbhJJqM399CDkNqTGhTioVjMrGiDRqxqZXDwznQ0xymOgOi/3+hdRERT2ETdBQtMmC9J6xRk/1OTMK4guEjrNGLkr3meKEL5LWmAz4gEpiMeM625JEn1OaFdnoWk56N/XFn7/jUQ3MNjpApfKz4TnE+tJzBc5eh+m8vCbl5uA5+JgeAKp+obtKB7Qa/jhcTorvvUv4bDF7ZqGZgkiDhZ7o9HK4DfPZVJaGzMzN5K73iM6lib4tXuuneCgGhmaQ978mDeMmWeBv2y2T/mN2WioBYWz+bxUudbexEdE3NPCJPRq7GpG6jzqGQH40IEpgljngdb5EgAAQi+peON7yQCLqs91QVFmEUK4tK4+5c3vsFETsUYyyasp1/sbYJ10loeYKVH/ra20PRFjmnd3wd95rLF9VmITUuJQ93IShsy5SZwMc8y2ybnsvPT3rfek2hIUXoZs6+QAu085Ln7tBy2DMg6IhQ39JttWx6aJDm+dDuOXm4mdKDYR7sLCYE37d06D/afD3vNMrfJSS3+cpzXRTLdKUSCePIlhD9CgBee8OdIL6ekJtN3mUazpC9FQY9q1x6hHVg3CZ2XQG81U3vQM4iJE+L2aRCxI61+ppj3jEHAnoKwCsjOTkI+1KcTDUs+AGCEbTbpPF4mVkn4k4WVNl3l+zLWLaC1hFgSR+4dIa+7sv+u1Jddrqq5/gsyqu4zFIeF2E/yXxtlavUWWGBICZsOaTD3mi3BtqK62OE2y/XNZrvF33R39zKTPa/jeomjtDB5gA1D++oMFvg8SZ8159VCkLmpwG5YFpGtRhT+T8eZFTLtGFyAF7WKYRXTDcEzyfQEbpp8OVslkgnuWooBR2tn94yxVNUDNRvzXvEczm8jZnk0K7nfSFc6y5DnQEnBGIvP23yt4Sde1u5fGAeeFkY8JIF1r0cai/OEIsnYav2vMqYFb 8ReW12kS 5iCySCGWiIKmYfAS1Kq3LIxOP6XUdwOB5LJ3LPJrPXTmYXlB60Yhb6ETa8WgF9wQF5uWgEdl/HkRedggGmT0ACUMO9mPEvdkx6FaoNgLr2g3AU+QnTxxc0Dc9N0EFU9CYS28C88aiuvafTtis31q0tJ/TavtprmucLvpytTk3pF+Kg7m1fTcxdtbpapDFj3J+sOkXZ5+SJWfL5LPnznSPhv9KmVoXVuhE11+B7UM8Js0I27RA4hVYTQS9mZcu7G5gneZHejHdSpkNXIQtRMPEkN+4DbP8MCCNEQsmwi8GGKa2oT/6yQpOOSeMuGylsoRla4HsUmHaxtdV2WQgdnaP+Brelw31WaE8IVtJO3aF+jRCGjZfTAhcxugYFL51UlJ1k2HzO34Iu481KTLo+G0hjGyoVmfxQoSTnrZbtlyoRLZ3ni8OeJRadp7zsBQEct9ZOwsU2nvTh6ewLUnoLsWfLZ1C+t7GYbb5BqI4uHViHp02prLsWmiztKeZjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 21, 2024 at 10:29:59AM +0800, Yafang Shao wrote: > To prevent erros from occurring when the src string is longer than the > dst string in strcpy(), we should use __get_task_comm() instead. This > approach also facilitates future extensions to the task comm. > > Signed-off-by: Yafang Shao > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter I guess the entire series will go in through a dedicated pull or some other tree, so Acked-by: Daniel Vetter for merging through whatever non-drm tree makes most sense for this. Cheers, Sima > --- > drivers/gpu/drm/drm_framebuffer.c | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c > index 888aadb6a4ac..25262b07ffaf 100644 > --- a/drivers/gpu/drm/drm_framebuffer.c > +++ b/drivers/gpu/drm/drm_framebuffer.c > @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, > INIT_LIST_HEAD(&fb->filp_head); > > fb->funcs = funcs; > - strcpy(fb->comm, current->comm); > + __get_task_comm(fb->comm, sizeof(fb->comm), current); > > ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB, > false, drm_framebuffer_free); > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 625b3c024540..b2c16a53bd24 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1411,7 +1411,7 @@ static bool record_context(struct i915_gem_context_coredump *e, > rcu_read_lock(); > task = pid_task(ctx->pid, PIDTYPE_PID); > if (task) { > - strcpy(e->comm, task->comm); > + __get_task_comm(e->comm, sizeof(e->comm), task); > e->pid = task->pid; > } > rcu_read_unlock(); > -- > 2.39.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch