From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C3AC27C4F for ; Fri, 21 Jun 2024 15:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CC8A8D017C; Fri, 21 Jun 2024 11:02:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47C938D017A; Fri, 21 Jun 2024 11:02:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A6698D017C; Fri, 21 Jun 2024 11:02:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 01F078D017A for ; Fri, 21 Jun 2024 11:02:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D8214160ED7 for ; Fri, 21 Jun 2024 15:01:58 +0000 (UTC) X-FDA: 82255210716.17.FD1B51E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id D251E80002 for ; Fri, 21 Jun 2024 15:01:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fk7gGsY0; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718982111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=REVMzCf9KPJKxppAPyYl2jD1cpXtxvVGJIDHyR5KKbs=; b=chVdD92Nn4Stjo/9rErpvD9VXcupqRn1fnOANZ4odw+r3nYpObFYQ0Rzp9MQJiP5HgN3E9 TvQ7O+cnlCNNIcwiCbbDUxh1y5qKWxI1uMmMUWOe8TkSa6LzDjMnCkQozIWIWYBUwbtmYD 5k3iqsPypvEfjZnCriW0W4BPfxknpWY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fk7gGsY0; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718982111; a=rsa-sha256; cv=none; b=D9BE2rQYQtd+a3tsDy3vJDKQn4+oYKARQ2W7yWAR989ZTnFpHsAG76Nr10dcIJIqk8eyQ7 /Imn1uBlT0k787vGJMzJxSZ3r+bWxp/EbaC9oZO1XMPnYW5c5tXND/+Ndt23tvzGOoA3bG LTYlOu7hHZDxg8ntp3GEGb2y6TyEFPc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718982115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=REVMzCf9KPJKxppAPyYl2jD1cpXtxvVGJIDHyR5KKbs=; b=fk7gGsY0cgBTPHPqq+7cxogb54B8scrd0CUMHH+O3xfT768A5B7lO37qxu7zv6QJ2KSpbQ Mrz+qQkSIVY43r4adAOMQzP98YKtowW2BjnVZlf0Yh37nDhM1Gwxw7Rg33DOdC23pvGnVy ll+Z0IXU37jfidnNDd1+JPXfYacG4v4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-MuPiu1YgOOWGz_GddpzHsA-1; Fri, 21 Jun 2024 11:01:53 -0400 X-MC-Unique: MuPiu1YgOOWGz_GddpzHsA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6b4fc5c2ee5so3658196d6.3 for ; Fri, 21 Jun 2024 08:01:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718982113; x=1719586913; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=REVMzCf9KPJKxppAPyYl2jD1cpXtxvVGJIDHyR5KKbs=; b=MTriqQ7n/2SUncnfKdgI5K9xgTz+sznUJZiLaujfqrU/9Akb5j9wiIFY6JEwiXecn7 nErX5PtOGhdu++M9Fzk3dJqxpUmRI0QLLXFZlzAV82IwKsBGXELfRoAXHlPUoLFCBvtG vgyRZytELIKU50ExNKwvkrnSXGSgO2IPi5XVUOIKcr1PMF3744/RVFlQEji5PxB4p63/ IQ7CG8No03VXLGqBbyBBDSUI+WO+yOA0uhoWWTXGTwN0odj8k0Hu7eogzvhY5Tfe5J93 03LvCaMHqNRj4PzdA8nNgtydyDQQKFRj2wLZ0oDTjNw6KD/A8+DNCjxGaNNacABcJG0l pbaA== X-Forwarded-Encrypted: i=1; AJvYcCUAfTKJxX4v123fzDKOz9kMTPdf1IcX+ZMFNdueqwg13aKEbhmhH60YnZmHeico95TLOnGbpTHz1axG3yHQ7ZjRHk4= X-Gm-Message-State: AOJu0Yz6xveUqHO2UrviDwEoLeNdSVORclpT/BsTaFG5YwfkJRrwCLIm ge0p4OgS8qhkZbfB5pWJe9MsXhD3adYemul9jZ6TGX5rFj7qeD676uSJ3y8STt0egoO42oyadYJ hwavuyGDJsKJUN3+RN6VTzcwpJwUOt2Kk1nsGvFBsjf6N2WUz X-Received: by 2002:a05:622a:2cc:b0:441:581b:c111 with SMTP id d75a77b69052e-444a7a153ffmr95993521cf.1.1718982112685; Fri, 21 Jun 2024 08:01:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGy/M4tB0NsmwFw2Vc1r8qkgVlJcFixEuuYKG9UASFE/pxP8aIpWiptz9iA6cfjIHrhSLs9OQ== X-Received: by 2002:a05:622a:2cc:b0:441:581b:c111 with SMTP id d75a77b69052e-444a7a153ffmr95992901cf.1.1718982112163; Fri, 21 Jun 2024 08:01:52 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-444c2c3d946sm11823491cf.74.2024.06.21.08.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 08:01:51 -0700 (PDT) Date: Fri, 21 Jun 2024 11:01:47 -0400 From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: x86@kernel.org, Borislav Petkov , Dave Jiang , "Kirill A . Shutemov" , Ingo Molnar , Oscar Salvador , Matthew Wilcox , Vlastimil Babka , Dan Williams , Andrew Morton , Hugh Dickins , Michael Ellerman , Dave Hansen , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Rik van Riel , Mel Gorman , "Aneesh Kumar K . V" , Nicholas Piggin , Huang Ying Subject: Re: [PATCH 4/7] mm/powerpc: Add missing pud helpers Message-ID: References: <20240621142504.1940209-1-peterx@redhat.com> <20240621142504.1940209-5-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240621142504.1940209-5-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: D251E80002 X-Stat-Signature: 3ih5cfbbdnfdp8n1s44caa1utu37f9t5 X-HE-Tag: 1718982115-308333 X-HE-Meta: U2FsdGVkX1/flJrswugGvfDotzfh8w7+ZzFuMljOL+TCbIvujiHJk1NfIjT0vhQtpiOJ/11hFf0sbX0/w2jWgGC5ZvdeeDZnxblzdS/S6ihisorJ8TNRnC938p9NsMxkgC9jbGxDO66eUsturdgH3Lw8u/Kay1rNyg0oK3O6RWQKSqLI4ywbQJeBwkRTIfZaJ/Tl6hUdGdsBf2Z2EfaWGGssL8TcvR3FPGVxr9inMYRVnCUnViD+xrwoRCjPBYugBL/AppSzbnXCaHq/36bwo/s08cGJEkMRDT7ZAt602RcKeHe2kSUbvVaHYlyMRpzSuML8AS4AoJi9gHK5XH4trMZJWHQROpZQiCg3tfEJ9jBTusebH9apD3yHWUfGqnRuJ+T7A4KW5wvZ3ugZ81C1XZrVC9ZfrwtHouKUSwfT8ObLRUn0PXl7a4mirrQ2S03R86idmtGg8p6aADREEIVQKwWITcXtUVUuMNtlsViM9rROEuStzKpoJSgHvTHt2zNLbKKMKuXBSj072AA15kFu1+6VPRkYMXsHDqZe7qPpfquVSBjsDelQ7y2ivykYVW75nHrz2u5lhXswbSg36Urs6OgKgUPVrulUSbEhIrlTDxXqHn1Uwzq2ivPQd36JMhqt7EwlKClDSDjryAl65DQHan2ppWSId9REJ3/pekTeGlZlgwIq1We7MbPj+IQgH/pCLRPnDgYxll/QEjWgbsVXcMMbHX0m622CTF71qoirvXAiGN/pvjON3+MN6+R12f1urFd3eG0Uqq5wxSuIJeXaruQqxy1+JfS5WEy41gXLh4slh8rgfQbBJFO7rvFamwsFhxBFWSnH6jS34ZfytGpEbcdH0YJTunb7WBYLdviZqU1NBg9g1WGyHF6AHDFnQyk38bfzw8j8/diJcvtH5o05C4o4tJ+KsKgXWUHVvMsNWtvzDjFlWRfAk1eQknT1RWGB+WE34djJhZBf2RTVyOy gwKiU9WY 14Z4QgwkuQRG2kdzzby6qSLr3BhEFvDhEKiSDr+YzShNlTTYNeIaNsap3pmDediT6l1Lf1IbbXrSZrQ0/D+cS0ROkdCEijK4ylk5Em9sUYt5dID6GKv4pPuJOXD9+ukBxN3MGlBK43pI6UqFDph5ii5Xfl7LObF7fhEsYUBakRtO+I0qD+QcOe82maWs7EWqT5KE1aWQJrK1vCSIaXqugvMbxm0d2likA6r3CxclF4FUhXz3SjBrk2DFcr47JfkC7/zo6ObvO6zraMOaTwbyKhkxvUCmRzmWQV97gNe/zUchwoO9cJDEbePfXcWsAVHeP1WVqv6uyh1kevAA1k+4heNt34nUNseekByeb2H+cHEPNhmN7kPo/eb0PvE+EYgRFYcgrTq8oGIIDwh/28lucQWwyJhfDqg3RfWdRSkHJ8obOS9VKYw2LiMyfVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 21, 2024 at 10:25:01AM -0400, Peter Xu wrote: > +pmd_t pudp_invalidate(struct vm_area_struct *vma, unsigned long address, > + pud_t *pudp) > +{ > + unsigned long old_pud; > + > + VM_WARN_ON_ONCE(!pmd_present(*pmdp)); > + old_pmd = pmd_hugepage_update(vma->vm_mm, address, pmdp, _PAGE_PRESENT, _PAGE_INVALID); > + flush_pmd_tlb_range(vma, address, address + HPAGE_PMD_SIZE); > + return __pmd(old_pmd); > +} I'll need an amend at least here, and my test harness won't catch it even if it's a mistake as silly as it could be.. My apologies for such noise. Below is what I plan to squash into this patch when I repost v2. ===8<=== diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book3s64/pgtable.c index c6ae969020e0..ea2c83634434 100644 --- a/arch/powerpc/mm/book3s64/pgtable.c +++ b/arch/powerpc/mm/book3s64/pgtable.c @@ -176,15 +176,15 @@ pmd_t pmdp_invalidate(struct vm_area_struct *vma, unsigned long address, return __pmd(old_pmd); } -pmd_t pudp_invalidate(struct vm_area_struct *vma, unsigned long address, +pud_t pudp_invalidate(struct vm_area_struct *vma, unsigned long address, pud_t *pudp) { unsigned long old_pud; - VM_WARN_ON_ONCE(!pmd_present(*pmdp)); - old_pmd = pmd_hugepage_update(vma->vm_mm, address, pmdp, _PAGE_PRESENT, _PAGE_INVALID); - flush_pmd_tlb_range(vma, address, address + HPAGE_PMD_SIZE); - return __pmd(old_pmd); + VM_WARN_ON_ONCE(!pud_present(*pudp)); + old_pud = pud_hugepage_update(vma->vm_mm, address, pudp, _PAGE_PRESENT, _PAGE_INVALID); + flush_pud_tlb_range(vma, address, address + HPAGE_PUD_SIZE); + return __pud(old_pud); } pmd_t pmdp_huge_get_and_clear_full(struct vm_area_struct *vma, ===8<=== -- Peter Xu