From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD02C27C4F for ; Fri, 21 Jun 2024 14:03:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE4E08D0173; Fri, 21 Jun 2024 10:03:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1D088D0170; Fri, 21 Jun 2024 10:03:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 784CD8D0173; Fri, 21 Jun 2024 10:03:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4C9888D0170 for ; Fri, 21 Jun 2024 10:03:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DD45F80F95 for ; Fri, 21 Jun 2024 14:03:05 +0000 (UTC) X-FDA: 82255062330.28.2B674A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id A1A782000F for ; Fri, 21 Jun 2024 14:03:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=be3bwTVb; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718978578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=akLFQtt/+POxVR4pxOkO3hxUvw7PQRoqpGG2Zvxz0Ao=; b=PYM2J84HGymGOkomXXa0vKpTOZ73n5KyI7/hwn2InHsukqq1msKNhuiVtyfbXS0Yn5OLd5 xZKTPZIRqgcgxTvJC3w8jch273W+4HZhQxZLgNqtqOzAf2GjJMPM4E69eVK82ws7+6IhDC 2T+fBxpTeE+Mq512ii0o1euVbZJ+U/o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=be3bwTVb; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718978578; a=rsa-sha256; cv=none; b=iObhaTzz73tEG2HAFB0WpfXV5UCcAcJboArbPGsLqW/15c11mBysVwvrxAGrADnVB89Uas QRWDW/wzhm+J4FeZCk1QRobIEVZ0NuhEl3bltKU/+poyTzzPiQv/dHIK0KUgNCglJ367as PIM3Xgy01j+PM4stcUmN5JPytGKOThY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718978580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=akLFQtt/+POxVR4pxOkO3hxUvw7PQRoqpGG2Zvxz0Ao=; b=be3bwTVbsNx9+X+oq39+8rTJd+JWtI/Gcl08OaerVR03WdK/rsRFVyleR19RA20dBNJlnn B49fdtRHJQNN9yn7avkZtN48gqgj5Qh0MehFvuf4ZsRu0Sb24dzCfWDSUw3pGvw1czr5u8 vzUHksGSTKo2o5VC/2qfIGhCIfSE1qk= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-boMQmNw-Nki6ogvq3fnK8Q-1; Fri, 21 Jun 2024 10:02:58 -0400 X-MC-Unique: boMQmNw-Nki6ogvq3fnK8Q-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3D6BA1955F01; Fri, 21 Jun 2024 14:02:57 +0000 (UTC) Received: from localhost (unknown [10.72.112.17]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7D6303000218; Fri, 21 Jun 2024 14:02:54 +0000 (UTC) Date: Fri, 21 Jun 2024 22:02:50 +0800 From: Baoquan He To: Uladzislau Rezki Cc: Nick Bowler , Hailong Liu , linux-kernel@vger.kernel.org, Linux regressions mailing list , linux-mm@kvack.org, sparclinux@vger.kernel.org, Andrew Morton Subject: Re: PROBLEM: kernel crashes when running xfsdump since ~6.4 Message-ID: References: <75e17b57-1178-4288-b792-4ae68b19915e@draconx.ca> <00d74f24-c49c-460e-871c-d5af64701306@draconx.ca> <20240621033005.6mccm7waduelb4m5@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A1A782000F X-Stat-Signature: wun3tsro5ymw5fywxhiqh5hey9rbpsu3 X-HE-Tag: 1718978581-359769 X-HE-Meta: U2FsdGVkX1+cZe3fM7EBCV3ce576BoD2Kd3w1TiV9C1Hn7ckLfo1EtmvuO5lXGODDsUkkYtq3n+ApJrpMkN2chgvchJrro1YeOwq2cI1IdIpxOIjmgQdL8niRMx1gfvCwZn2Lp8nOfsEhOwIKOsujol4v3bmOj25xWir0f8aJ0H4+93sgSTHCL/CYnTeQ/nRaRAgrlU6X6uYTwALlL/1x8nBf/VzwqznA1H6phQ8SAOmmr9mwoIlJ2QD6Tz4Tk1rdEzMQtdRDFWqWKwCF1hByGphpdA/SXo/xeK/iPsw9cxLIIoM9STwao6MHTHcZ7lL97DTmzLmdaTijjwC5NUPMNWNSVjeli0Shh3uSHLDOuD/fB+gb27vLqbD670CdXO+VMXdMmuix6w8eV8kuzkLjen7TWqM/n+oVB+gjfOibynzhgYKi1Yvui15FFGdMY4Gi3u2D0FDvDcLLpAoSeg2rLd4oxASR7DYlx2gwoRuxfyNOwg8iGatwxQFbR0IC1TRbHPw2ZbAoZIpCNy6ynupmaP0jy6CtXJKiftOH5FA/8vGnhR/ohfW4kwvOTA6LrVnWw0VP+rMKpO4ZnhlyhgrZd/439u+N46mjWaXL5Tb6F538XEb6LOUT3y3R0f4zitiI43hcUHTjfUL1J1UX7jZu9f2U8eUoKgduZuoJYnkQOkTGnXjERwektuI2Z3yJd/67BIHIAyFJDZjqEuATgd2XWnp820N9xCREu2E0caNRb4xF6eBndFn3u1e+lvFc2SvxqpR0+eVMEI+zGejQ06/uMq+bVW1OPthqhdKzsYLYlO4ksPbArOCKM/4Oy/LMmhrFUMO+5UTRc7LgJF6sU7QvAA3canCGoKE0pTUiMmS1sqozsih6v4m35Mj44PDJ+pV7oyUgfmx03yafF5BosDjVrtWqt2PzpC8ZqSLia+4dJVZDODuNAnQBDB41g+6ycbIovXw07/t8rDXweiwraA AO1dk2A+ 0iY66ajpWdXJ7qumxuPi7TbUfJr5ed6r98FDN9QiK/iF/nwPxr88awaMe7dx9aRHl3Z5C6YLFtpumalryjj9dXdvydxooftr1nFirM20DRAYRsiHvDwfcK0ZgZr47u3FFylNps1MnNxyc29csehXCTVQSAHGh2H+jTfEQMho/2zivKKh/JRl+n9yHFU1jA406R9G9VEDForfDMl9fq7dGeEuQzFKIYT9Sx9ljVvO1SWfK+Tx1zac9R2N9HsDhqwQr70snXx7FrBcWqWvob57narBP95h2uRiNWJI8xqISu2U2MV6kFSB1zpIDRSEzjh6dUy7hRvBSQMiKVqE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/21/24 at 11:44am, Uladzislau Rezki wrote: > On Fri, Jun 21, 2024 at 03:07:16PM +0800, Baoquan He wrote: > > On 06/21/24 at 11:30am, Hailong Liu wrote: > > > On Thu, 20. Jun 14:02, Nick Bowler wrote: > > > > On 2024-06-20 02:19, Nick Bowler wrote: ...... > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index be2dd281ea76..18e87cafbaf2 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -2542,7 +2542,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > > static struct xarray * > > addr_to_vb_xa(unsigned long addr) > > { > > - int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus(); > > + int index = (addr / VMAP_BLOCK_SIZE) % nr_cpu_ids; > > > > return &per_cpu(vmap_block_queue, index).vmap_blocks; > > } > > > The problem i see is about not-initializing of the: > > for_each_possible_cpu(i) { > struct vmap_block_queue *vbq; > struct vfree_deferred *p; > > vbq = &per_cpu(vmap_block_queue, i); > spin_lock_init(&vbq->lock); > INIT_LIST_HEAD(&vbq->free); > p = &per_cpu(vfree_deferred, i); > init_llist_head(&p->list); > INIT_WORK(&p->wq, delayed_vfree_work); > xa_init(&vbq->vmap_blocks); > } > > > correctly or fully. It is my bad i did not think that CPUs in a possible mask > can be non sequential :-/ > > nr_cpu_ids - is not the max possible CPU. For example, in Nick case, > when he has two CPUs, num_possible_cpus() and nr_cpu_ids are the same. I checked the generic version of setup_nr_cpu_ids(), from codes, they are different with my understanding. kernel/smp.c void __init setup_nr_cpu_ids(void) { set_nr_cpu_ids(find_last_bit(cpumask_bits(cpu_possible_mask), NR_CPUS) + 1); } include/linux/cpumask.h: #define num_possible_cpus() cpumask_weight(cpu_possible_mask)