From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38A8C27C4F for ; Fri, 21 Jun 2024 13:57:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780708D0172; Fri, 21 Jun 2024 09:57:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 730258D0170; Fri, 21 Jun 2024 09:57:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61E8C8D0172; Fri, 21 Jun 2024 09:57:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 42A378D0170 for ; Fri, 21 Jun 2024 09:57:19 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DF092A0FBE for ; Fri, 21 Jun 2024 13:57:18 +0000 (UTC) X-FDA: 82255047756.18.07869C8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 777ED18000D for ; Fri, 21 Jun 2024 13:57:15 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mO5OOz3S; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718978228; a=rsa-sha256; cv=none; b=g9WNl5yKzmSax3GfjoshrDZ6SFc1punn0eFAg2PM/gyAWurvxPGzHcjCxEFYUd3xT0UAIO 72dqIlC+WMTgZH9AVCaekDd0/Sz07i8CTPV4qVyyuTi/uPnEtHQGehzDEo5U4HNWR6FVEB QtttKLmVortgrLdAj9Q6wTx+FhEA8tU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mO5OOz3S; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718978228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7D1XSOiDMq3J20D9eCQjvYB35cnbWTU/PoTWWvCb8rY=; b=3fmI/x8nLYEqUq48Ulk+glmcLh78A/aWu5ktoXjhVXvvns/iJ7sYnElaaak6WCzZXfushE d6HELfOcklk/ujvz45PGDKU0nvArEXqsdLx8CI4vAhQKrMgENop42pK6b6lHBO3YVa5WUP 0H+qk08F4PeY2ClD3Ab/gl3WY05MPXg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7D1XSOiDMq3J20D9eCQjvYB35cnbWTU/PoTWWvCb8rY=; b=mO5OOz3SIWlYAssxOG0CRWoAp/ L64OelAl2Iw5whZKQuTcpkXinUkOwVp6l9D5GRFVtsFuYWHJbBQqcL6FICt050IxsfQKfvDTuMZUl sg/akK8oWqgR8MYV/AbLrDQ+XphkyeSGmXCjIWigtkPjpD/CDpWQtAbhKMX40rz7r/GyVM0DxOx9+ P/Iw1kTh7JIISPvnZNKF9qfyxMec91XW4JG7yjCBYqPKzTL2010UQ3WH533TC7+dN1/Xf253uALgo fhYiTSl6bxT3icrvO6qwt74jay6C/y7Vh1HtMRIeAsCDYzdVzh7C55AGfmBQlcK8p05Wp54FdJrQR CtGKSFng==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKelH-00000007G58-0bUT; Fri, 21 Jun 2024 13:57:07 +0000 Date: Fri, 21 Jun 2024 14:57:07 +0100 From: Matthew Wilcox To: Yafang Shao Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} Message-ID: References: <20240621022959.9124-1-laoar.shao@gmail.com> <20240621022959.9124-7-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621022959.9124-7-laoar.shao@gmail.com> X-Rspamd-Queue-Id: 777ED18000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kjb9nxow39kjzbyii9ewo71j585b88fy X-HE-Tag: 1718978235-791319 X-HE-Meta: U2FsdGVkX1/6T2LmDxmBqAw13zuoFy1nhwfJE3JRy64SAoFJTcJL9Ovz9PVU4unEO+JuxjpDp9v5lgeJ/MrjC6k96EkA5faI+XBJHmV0Xb347SgY3DPiLFZEhiuuqqtZKY4PFuFzBindJQkRDAdWnOTAGPXs0sWef+nVMU/AT+6MvSTGieUG1Fk1ViG8eqxPBY7E1l+dm9+j8Emi+dfrd2knh6iOM8wAIGqMY36SwFhznESGKPGCZfYVs9onEZXREwxoOeJFnPLJUAzmFpVhRtFL7qeaqiId+Wrm1vhop3y89jeTjXV4j/mDjCPeVg9ckqBR3sbO3FxvCzHeiQtxi6J+pXt079yLmSFZv8JERYP0Fjw10Rfa43rzXcZ9xCRrocVGu5/taagCxO07emu7NzcUBsdJyF+uIJx1TyjQnWY5ITkcWJnNGTZYvyXYbV7gWjl9xuUe2EMkS4rVimi2ysBAdDmg8hdy9tMv4sBfzjeuLcfWHCsSB2eq2cxsjra8iaqXimsPNNr/mqcCIipuHWWNYAnuBpwVC5OYvenPTSUyYz/qRi4i2b7GOS5XZ+6oU3C90Way3mF3V9ajST6z46Ty8cDq8dPGUxIw+Lt1xo1JqFHTuwmqu8jlsEtZpdRMDGNuhIIUB+oKsAQSMyANuyFm5+rgwE+mUB+3Ot06gjjSYqcJG8YUbKYtmogXsLxBJaOWy3YC0MT/JutOhaQwaSLvRTK0r4Va3veeOf/EplDWO64OJsp9ooVqYRSYE+wvVi+CY+UQXwI15hRycxv5PStMTceV/uXltw825ydIPC0EV8cWz6izccF3Gd0EqLFa7OrbIUCfofodg4gaMAYl4dYeLDYUDCXEQ1VEOMcy1lAjq/p6qRkMOwJPlhIWN3VmoHz8D5c1lpfPvVStOAec0Fx0vQTtX92JxsrVQ9GA7GayFlmYD53DzCAoBCAc+tT9sk2mcP1sWfUT966uJtg Vvy87tS4 FPnwdaura6lM3+jrj2c5Heq5qzJVHLo0qcwO9b7QlL3F4jpqru+PrsV20NORblTM3sgxnNbGFkBZ9boSAPcQnT8xPonQWg5jnLQHbwuoH6SuvpaoQh1SCgO9mPuOFhKxote26fW/Kb3vInYSHNc9OrA7bsHAycj+7gXe82aEoN6TbP7SjH2qd8C+XERinswFVaCTXkYVQ17bFYFxW3yJ+l5ugV4KaEvTFqX1Hb3DtYQn1qoaws6cLT15b7xc8nz8vkv73AoP513kEgUc+N93eiA6+YW5fWgJXcxCvrEyyjCiGOSxamp0AAUmmv+9XFpt1mFEdyJC5WbNd7FA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote: > +++ b/mm/internal.h Why are you putting __kstrndup in a header file when it's only used in util.c? Also, I think this function is actually __kmemdup_nul(), not __kstrndup().