Re: [linux-next:master 6447/7105] mm/mempolicy.c:2280:15: error: redefinition of 'folio_alloc_mpol_noprof'

[Philip Li <philip.li@intel.com>]

On Fri, Jun 21, 2024 at 02:21:39PM +0800, Kefeng Wang wrote:
> 
> 
> On 2024/6/21 12:56, Philip Li wrote:
> > On Fri, Jun 21, 2024 at 11:17:05AM +0800, Kefeng Wang wrote:
> > > 
> > > 
> > > On 2024/6/20 23:55, kernel test robot wrote:
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > > head:   2102cb0d050d34d50b9642a3a50861787527e922
> > > > commit: f85385e70cb4bbb569298830fdf0a3d8325de36d [6447/7105] mm: add folio_alloc_mpol()
> > > > config: x86_64-randconfig-014-20240202 (https://download.01.org/0day-ci/archive/20240620/202406202319.pBcCfVar-lkp@intel.com/config)
> > > > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/202406202319.pBcCfVar-lkp@intel.com/reproduce)
> > > 
> > > Hi, thanks for report, I try with gcc-13 from 0day[1], but can't
> > > reproduce with above config.
> > > 
> > > [1] https://download.01.org/0day-ci/cross-package/gcc-13.2.0-nolibc
> > > 
> ...
> 
> > > The above error is strange, my change shouldn't affect them.
> > 
> > Hi Kefeng, sorry for confusion, usually you only need take care of the issue
> > that is prefixed with >>, which is the new issue being introduced by the commit.
> > Other issues exist due to existing commits.
> > 
> > > 
> > > >            |                                              ^~~~
> > > >      mm/mempolicy.c: At top level:
> > > >      mm/mempolicy.c:2221:14: error: redefinition of 'alloc_pages_mpol_noprof'
> > > >       2221 | struct page *alloc_pages_mpol_noprof(gfp_t gfp, unsigned int order,
> > 
> > [...]
> > 
> > > >            |              ^~~~~~~~~~~~~~~~~~~~~~~
> > > >            |                         __count_vm_event
> > > >      mm/mempolicy.c:2272:61: error: 'NUMA_INTERLEAVE_HIT' undeclared (first use in this function)
> > > >       2272 |                         __count_numa_event(page_zone(page), NUMA_INTERLEAVE_HIT);
> > > >            |                                                             ^~~~~~~~~~~~~~~~~~~
> > > >      mm/mempolicy.c: At top level:
> > > > > > mm/mempolicy.c:2280:15: error: redefinition of 'folio_alloc_mpol_noprof'
> > > >       2280 | struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order,
> > 
> > For this report, you can check whether this issue can be reproduced or not.
> 
> mm/mempolicy.c:2280:15: error: redefinition of folio_alloc_mpol_noprof'
> 
> obj-$(CONFIG_NUMA) 	+= mempolicy.o
> 
> include/linux/gfp.h:324:29: note: previous definition of
> 'folio_alloc_mpol_noprof'
> 
> but this one is under !CONFIG_NUMA, and from above config, CONFIG_NUMA
> is enabled, so this should be impossible.

I think you are right that this logically is impossible. Sorry that I didn't
reproduce it in advance, and i also fail to reproduce. I need take deep look
to understand what went wrong in the bot. Sorry for this false report.

>