From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1932C27C79 for ; Thu, 20 Jun 2024 09:25:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31BAC6B02FC; Thu, 20 Jun 2024 05:25:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CAB16B02FD; Thu, 20 Jun 2024 05:25:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11D296B02FF; Thu, 20 Jun 2024 05:25:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E50A96B02FC for ; Thu, 20 Jun 2024 05:25:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D348A18D0 for ; Thu, 20 Jun 2024 09:25:36 +0000 (UTC) X-FDA: 82250734272.21.DF97D69 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf17.hostedemail.com (Postfix) with ESMTP id 19C394000A for ; Thu, 20 Jun 2024 09:25:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Sfio6WQO; spf=pass (imf17.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718875525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f+xXT+pi71Ik+KvC0QHepWSaRorcAZ6T5r10Nujhews=; b=L2mLU0iZ4Kgq2nh5Tv5G+z/JItZi0kG43tM74Kt6yJ+AD17pfG9f+gjlVam7fZZG5zYn/+ SIodxQUwLDyoua3zvJVf8fgMA6Rb6eXiP7w1L0cX57I2j5P1h9Un0IPf/2ZQ11GF6HEUOv t5TxNT0Xr+xLHQqGUc2LN1nZQ58xvKM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718875525; a=rsa-sha256; cv=none; b=dCEPUy93u/qmZ4E+IxuQh9i2gMsRLFBvFDYHGblZIgHHGR8TPXkXNbU5zPUD32/SH0maNi t24amk7bMvyrQxdmCRZlQ5mZqk50YBBapL1B0XUfkrXXAOEIXAFzvgyDkc82bRhxP6sUa7 eja0zRgPNXscuzh9lFFiOjhAmGiUQMw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Sfio6WQO; spf=pass (imf17.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45K902cF016608; Thu, 20 Jun 2024 09:25:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=pp1; bh=f+xXT+pi71Ik+KvC0QHepWSaRor cAZ6T5r10Nujhews=; b=Sfio6WQOYVTagW1lvAePUjWg7PZYt5T+OSgX5FR5CBQ 4T8FqTVC4pGk7y9uFqQ9H82xU9f/hxcd1AgZq15JV1SUzIYn/uLKhvzmNl2iZ9Tz Lt8l30OOq/SVsJ62yESCJkh9impmd3uvFPWd2G7fr63apxlMVlkv4h2os7U1DYMX HmqePfnNaDGAu1KYVehinYSGS9ETdQuWZZLbIwk4lKJq0X7y+CEiEAxFDXuFX8Nf Dxsky2rQB37kiRnGjwmzceUoBJaqVuOj+MJJ2KE7GYW3ExS44sx0F4w8p1m4myRR jMxxH054GfGQtk+2zifvVE6F7PQWB8/ysIhYxJNj3+A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yvhd082aj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 09:25:24 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45K9PNjH007553; Thu, 20 Jun 2024 09:25:23 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yvhd082ad-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 09:25:23 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45K8q0Lp011355; Thu, 20 Jun 2024 09:25:22 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yspsnmdy9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 09:25:22 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45K9PFWx50331948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Jun 2024 09:25:17 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3AA6C2004D; Thu, 20 Jun 2024 09:25:15 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 50D6720043; Thu, 20 Jun 2024 09:25:13 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.21.176]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 20 Jun 2024 09:25:13 +0000 (GMT) Date: Thu, 20 Jun 2024 11:25:11 +0200 From: Alexander Gordeev To: Ilya Leoshkevich Cc: Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Subject: Re: [PATCH v5 36/37] s390/kmsan: Implement the architecture-specific functions Message-ID: References: <20240619154530.163232-1-iii@linux.ibm.com> <20240619154530.163232-37-iii@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240619154530.163232-37-iii@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: wGgihVial8kXJ1bFTIVWyPNHF-8EUg62 X-Proofpoint-GUID: 0mzQWVSjgWONbMvCB5bN-IoPQn2J8C9F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-20_06,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=512 suspectscore=0 priorityscore=1501 phishscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406200062 X-Stat-Signature: ysnngh9rucb9rw95kbkc74e1rzcnmumy X-Rspamd-Queue-Id: 19C394000A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718875533-507763 X-HE-Meta: U2FsdGVkX19svXjGOE4nDXh0eSMUkiJbSxEkNgTjyHWDi1M5DzT+UStuU+56oRhdN2pLTfT+KKRFu875GEqY7tgG1ARMND/eA7cUIWF1s4PYpOnvMisOa6dnN1AMYLZADf1CeE05+2Pp04o4MF2mLlFnukG0k4Zblie0wjZvrba1HZo6BTUhwPtKQGk6xFnaJkcbZ3cdV8hiI3Uclew/eHm9pK5AwDvSeW/7w3J4+mHqz+NjopVJASlzreCgRCUfmacSXaKo8FgyfWlRe3oElZcgPYrcRqcZ1POZAixb99UC/9uwbBsFA2jo3Nf34jWByGZDg98BrKXN5Bzk/e2FID5S+Uj7VH9YgIMHTeAgArYY6zx6ccTprhYoq93rDLZueETUs6sL5xx9a7z4+A/zmKmBchkZ4qMIcaztrHCu660LB9J6Q6V2gjiMA0zLBpthLBu3P0jC7hjEiXA5yckF9H38IvkEGGmGgcLJjU/+Gb2+uhxufzG0hfjqwwhfRjIY8j3S+O6xAs8SnImqE7iTcYhtyad5Nx/jGwWnaCww4NPoUR19RrurqXlx3kj7ch2UL8cmhBmJ0rvHaMtk3NJvWUe6vCNMYq2XILwT0a8cbKCY4tV+GI6/f91J28GMQI5PlrNu84gHYDT0+8IvzM5v2uj+l3xQJ31bHgTa1IE7/03cy/xCaFHZ8aLJr4VwVqwHf6fX3XYMmTc5BIgxAawLW9E/MEuEvV0YVzhZwo7IxbVzeGyPG5ZtPV2c7ixXFwUHgsjsmrW26ahizZlvWfTasrJTvoAq9eE8TfW8RyakWo4br9Xsu3VWz6IwDywsq/5GStXGyzQFkphBFLF9ms/RPplt0WiG5junH+0bINxIBiwErJBL6nlZiMVIx+vzUHN/aGJImk8gochysJyNbjPsELdhyM4vOQ5pE2BeWO6D/eb0XzoK7sw8EB5bfIqNQK1S9h9SVN1v4WelwCseWOl a0DsJIgj S0Kx5fHJWoOYOzP7ext1evQ6wXIms84ZsCZejrjGMR9hDusa/oUvA8JSuNZYqreuK9LVS8GOnH75MF0E/6V39hU/w2NIWxo9LdVURHFV7VJljPLut8g6s6d+SYEIPtWOfDXwA0cxtYEPhZHmAePY2xQWd3FY9b2yETpzdxOcUem7CczbKzlWeDnNwIQpDzFr/5fbXI1INjGWjko6HB7C3PIgjLU4orYjgX4v16fufSmEZHXRDqkOLE8NUH9VmAe/jTVwz5lggdOrW4DrR/u9Zj8RndQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 05:44:11PM +0200, Ilya Leoshkevich wrote: Hi Ilya, > +static inline bool is_lowcore_addr(void *addr) > +{ > + return addr >= (void *)&S390_lowcore && > + addr < (void *)(&S390_lowcore + 1); > +} > + > +static inline void *arch_kmsan_get_meta_or_null(void *addr, bool is_origin) > +{ > + if (is_lowcore_addr(addr)) { > + /* > + * Different lowcores accessed via S390_lowcore are described > + * by the same struct page. Resolve the prefix manually in > + * order to get a distinct struct page. > + */ > + addr += (void *)lowcore_ptr[raw_smp_processor_id()] - > + (void *)&S390_lowcore; If I am not mistaken neither raw_smp_processor_id() itself, nor lowcore_ptr[raw_smp_processor_id()] are atomic. Should the preemption be disabled while the addr is calculated? But then the question arises - how meaningful the returned value is? AFAICT kmsan_get_metadata() is called from a preemptable context. So if the CPU is changed - how useful the previous CPU lowcore meta is? Is it a memory block that needs to be ignored instead? > + if (WARN_ON_ONCE(is_lowcore_addr(addr))) > + return NULL; lowcore_ptr[] pointing into S390_lowcore is rather a bug. > + return kmsan_get_metadata(addr, is_origin); > + } > + return NULL; > +} Thanks!