From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D7BC27C53 for ; Wed, 19 Jun 2024 21:04:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B220F6B029D; Wed, 19 Jun 2024 17:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9257E6B0294; Wed, 19 Jun 2024 17:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 777706B0285; Wed, 19 Jun 2024 17:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4B7F56B0275 for ; Wed, 19 Jun 2024 17:04:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A9EAA1A0397 for ; Wed, 19 Jun 2024 21:04:12 +0000 (UTC) X-FDA: 82248865944.02.FE2822E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 32963C000F for ; Wed, 19 Jun 2024 21:04:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QtfvMNUs; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718831042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2IBPUPKo0mqW5x1/ocRzXKcaHwxGR4JPvd7Vmk/D5tg=; b=46dCDhWHsdof2lPv1ueM2LxsM+ngZ7ht589UwLxaDO6C50XbKbnj8pVvIcm1XEIs7H97uR nFXPcUONZviAbhM2PKi7+Afnpdit75lePOp04OXPdEBnRVMa+EBTCMTipNDZOAliEUazMk fO64iU9SV8bWv8CDZ3IoxOmgCN/VcwE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718831042; a=rsa-sha256; cv=none; b=HauhebbN6nEi78sfmfLdkN1FxCpm7Sv0xFicY5OZ+UHZ2sXIdcywR5xW5AgKurFfrgSzuo mOimzqkz6s8ORLz5NgJlxzS4CWxi1rkSYxnI/5wdQoGXoqM+NXVKLvL3Y+6moWkbTXcZ7e Ei3jOlbUlaFnCpNcF3U0066w3yG0ivA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QtfvMNUs; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2IBPUPKo0mqW5x1/ocRzXKcaHwxGR4JPvd7Vmk/D5tg=; b=QtfvMNUsLzhHtIyO15c8ZSH0Im 5UjJspKkVhqe81OEdcg9wwQpzlJrYaGK+2/tANdnR1vaRBsyjCFbjjaWKEzxZpZq8ze1qRrjRqfXK 8VH8KUG7YJJ6fq3t1/Qf+OXN8/3mktUp4oH8113TJN3xZgR4JsLObTCpCBhyhyRsrvz3JtD7khTxq +MnDT9x1chzkynwOHupqi5oZZEiHYYTFdyNXLqIcjYFZJJFOPabHEbbBHD9YfFZbrQiVQqcHN2jIH t1no/8WSLH7ce0c28OK5Uh5DwgEosB11gB2POERtqh9dJBVP6SEBJA+5Nl/1Vx4MhTSa451aqzxy0 gB/6L1SQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sK2TH-00000005BKN-2JK3; Wed, 19 Jun 2024 21:03:59 +0000 Date: Wed, 19 Jun 2024 22:03:59 +0100 From: Matthew Wilcox To: Takaya Saeki Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Junichi Uekawa , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] filemap: add trace events for get_pages, map_pages, and fault Message-ID: References: <20240618093656.1944210-1-takayas@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240618093656.1944210-1-takayas@chromium.org> X-Rspamd-Queue-Id: 32963C000F X-Stat-Signature: 9rtustriny5k6nkh87hzjn1959yydjkg X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718831047-156755 X-HE-Meta: U2FsdGVkX18b1+y/SJbQZP8SvB7vFslKfzZsxWWc/CWfr6K313PmkKSORcHTK7cHhSbgevLzBHK9TeZdahwLnKm+whO+8inmxU7rdra3W/YRT4chQsfOXuGtYomeLfiOXwUDXdkIirD/bBdOjd1R2nEOtBsibh1CGIlNoHBbwrIkDimkMJnCaDv8mGhTVC4SMcyirRErEKQburzMExE+DXhvUq8ROluZN/AbQXc9yb7r1o7+boRszXCte515Y7TSZtGVLDK/RxXgyNf84ELD0rMGDeuQpRIZWRx1SoBu1XihWYgwQCg3aVx5y4FoBrKm0dsHZTyugWh4CjSh6B4eRan7hxPjhmTAkNKHUM6Wxp81CfPt/w9WLslNk4RO4kq6kp4HMG0dFaz+C3Yg0pG19AQAz/USBEtfYfUnMpirF2GuUlcGVSHxDpDEkmGkIF5qFRsQ1ZWE0h4MiyxzE5e5BA6OriWK8FkxVZ7bWOugmryZieGw4LRKj+6JrgJHNHbsFuqTABW/7UomJz9nDSNbeC9+4jnML4OpkQLyDNiQt4bn4gmxUCATU1I/1Q1pD+V1oKqck08uR4RpRPMNCb69xR3YUMP3ukBQT5EO213o9eNPKatf8T0hKzi6gjyYbtZxJfMQPl1b0QlkOs/J6UJfpuZTA9Ov3CnWSGGYwQ6U92+kAx5gUE/3XNU8ceYPYn1OEKeH9SCC1kodL6ZdiZNazS6NqNLPUWyWR3UBWfB/Hz/7M3tfXo41JazbqsY3YR5+jB93ukYPKPbL9PwH8apLLRlrypirbVJAMxho3Iv8coJbwg3sTwehX4CPTbJwvf3GTtl4AlPM8Azr3OL7dGOn2GVaFXqLJ3XBn2BQwsUshlCLnPWZFS0n4MhvORwzdKYTHlQAd4aBohgRjYzpDAfH3SWclXh4oB1a2TPULJNM3/NVgf4mN2cwIewKUqigx5eBujvtsi4mgetv339dkXY rCJnrI9C KWR5o0+a3FH1EZhuAn2Z3MuWq71dXi7pGEOmWQu2gHx3+8zHfDkeZa10h1v32YwQUjCWk9NFsWCmJarIvJTrsegQ+iIP6fOCGot7yRl+rpebDV+by2a23jYekZHvmnVKnkERO4PdBD92HwVOaMD2ai+0NfOj74Yu3otp1cthzUEcSC+UBlXuGYjwyJqWHsggPSGcueNxFMCFsvc8PsNxtt8lKEW2tMhyAyuVLPqGviZ7ttSaXet2EKJo1VftRIvHSA//T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 09:36:56AM +0000, Takaya Saeki wrote: > + TP_printk( > + "dev %d:%d ino %lx ofs=%lu max_ofs=%lu", It seems weird to have a space between dev and %d, but an equals between ofs and %lu. I see there is some precedent for this elsewhere, but there are other places which use ino=. I'd rather: "dev=%d:%d ino=%lx ofs=%lu max_ofs=%lu", > + TP_printk( > + "dev %d:%d ino %lx ofs=%lu", Likewise. > + MAJOR(__entry->s_dev), > + MINOR(__entry->s_dev), __entry->i_ino, > + __entry->index << PAGE_SHIFT This needs to be cast to an loff_t before shifting.