From: Matthew Wilcox <willy@infradead.org>
To: Takaya Saeki <takayas@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Junichi Uekawa <uekawa@chromium.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] filemap: add trace events for get_pages, map_pages, and fault
Date: Wed, 19 Jun 2024 22:03:59 +0100 [thread overview]
Message-ID: <ZnNHvwV7tDlSFx8Y@casper.infradead.org> (raw)
In-Reply-To: <20240618093656.1944210-1-takayas@chromium.org>
On Tue, Jun 18, 2024 at 09:36:56AM +0000, Takaya Saeki wrote:
> + TP_printk(
> + "dev %d:%d ino %lx ofs=%lu max_ofs=%lu",
It seems weird to have a space between dev and %d, but an equals between
ofs and %lu. I see there is some precedent for this elsewhere, but
there are other places which use ino=. I'd rather:
"dev=%d:%d ino=%lx ofs=%lu max_ofs=%lu",
> + TP_printk(
> + "dev %d:%d ino %lx ofs=%lu",
Likewise.
> + MAJOR(__entry->s_dev),
> + MINOR(__entry->s_dev), __entry->i_ino,
> + __entry->index << PAGE_SHIFT
This needs to be cast to an loff_t before shifting.
next prev parent reply other threads:[~2024-06-19 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 9:36 Takaya Saeki
2024-06-18 19:53 ` Steven Rostedt
2024-06-19 17:57 ` Takaya Saeki
2024-06-19 21:03 ` Matthew Wilcox [this message]
2024-06-20 16:18 ` Takaya Saeki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnNHvwV7tDlSFx8Y@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=takayas@chromium.org \
--cc=uekawa@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox