From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D96C27C53 for ; Wed, 19 Jun 2024 19:54:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17A5E6B0298; Wed, 19 Jun 2024 15:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12B016B0458; Wed, 19 Jun 2024 15:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0D676B0459; Wed, 19 Jun 2024 15:54:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D32EA6B0298 for ; Wed, 19 Jun 2024 15:54:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 86D5EA3D55 for ; Wed, 19 Jun 2024 19:54:54 +0000 (UTC) X-FDA: 82248691308.05.ED16754 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 65AC74000F for ; Wed, 19 Jun 2024 19:54:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=g2jq7otu; dkim=pass header.d=suse.com header.s=susede1 header.b=g2jq7otu; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718826884; a=rsa-sha256; cv=none; b=dGgrit2yAb9nnBwZGdOTfjcLDSeBkiqm1Fv5gr0i6vVAWcBdiRula/YTNGfGVhIFRlI0PG E4gSDpWpp7TqhrFcCGekylUlBOZdToWXDJyMzyJEoeF6JxvcHDsIiAoDeHxXVvHomaR7HN t09kULe/IzHGgeUMtywUuQmrWOw2GyY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=g2jq7otu; dkim=pass header.d=suse.com header.s=susede1 header.b=g2jq7otu; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718826884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vvPxvXNf8zuYWdKZlteUBeJJW5m05KwucRi2QZhjROQ=; b=sZbJkvTI3T4Cfc7+bjbFBmvwG1vLFAxl4hWRzjok9gsw7rQ4+/2hQdGZiXlZsRh640JWym fV1859bJUlnopuF2wWy7BUGaWiUVDM21I4+gaeb8+BUMmH/LCC4xQWoXjFk/3Dxd9LPOaf ZF20qH/a+jlGVUwEf9wk7DeRzeFFRwI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA4911F7D2; Wed, 19 Jun 2024 19:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1718826889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vvPxvXNf8zuYWdKZlteUBeJJW5m05KwucRi2QZhjROQ=; b=g2jq7otuPH8lGW2UWyXzZQldU9CjsEl0R1MsMmgW92a44eQZgQNJdoBgM4Tq0qR4LvV7KR tJXTDkFn7OIAYGXeDt2YpcQ41O2aVPcsGzWzLrJ86hHKUL+BEBjA09rIBLjpzNryWfSszW mM0JbY9v6zgaa2IEqn3aT+XEpcveK04= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1718826889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vvPxvXNf8zuYWdKZlteUBeJJW5m05KwucRi2QZhjROQ=; b=g2jq7otuPH8lGW2UWyXzZQldU9CjsEl0R1MsMmgW92a44eQZgQNJdoBgM4Tq0qR4LvV7KR tJXTDkFn7OIAYGXeDt2YpcQ41O2aVPcsGzWzLrJ86hHKUL+BEBjA09rIBLjpzNryWfSszW mM0JbY9v6zgaa2IEqn3aT+XEpcveK04= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 91B6013668; Wed, 19 Jun 2024 19:54:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hAWKIIk3c2bDcQAAD6G6ig (envelope-from ); Wed, 19 Jun 2024 19:54:49 +0000 Date: Wed, 19 Jun 2024 21:54:48 +0200 From: Michal Hocko To: Linus Torvalds Cc: Shakeel Butt , Andrew Morton , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kyle McMartin Subject: Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once Message-ID: References: <20240618213421.282381-1-shakeel.butt@linux.dev> <20240619174751.7r2s7iojxbaxpqlw@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 65AC74000F X-Stat-Signature: jb8wjzgxaxtmz3mazm7ihen7j1g8ejzz X-Rspam-User: X-HE-Tag: 1718826891-343646 X-HE-Meta: U2FsdGVkX1+AnhLFgYA3kr1cH5QGKXjFZxYM0AtV7A/rw2vTGQyzvtueZP5G6BMzlPPhvQAFnDNMYzgVSHvg75a/1MIW7vHHgkq9ZPQyo/Lj13Kuocry5JicKcBYApf0DrW4NWVvyonUDiflgMAVLU5ulI56K4UVJNQBP/iPsYQqyQesp8vsNrDoLQKAVV0IfqRIptwAvy+QGpKBtbpCTF8OqTCPIoViRIup0kFNsgVnjwzsQetBSmybEiS65ySGGvDDxFF5ifObKff2ELpydeXyts2f1awz0qEC07mK815HmzOJb6nJzUalP41j74zjJIZ1l38u8egO7opdBPpaC6zBhkJNPvOz7DSqH543RZg/Oi+lVg4uhDHpYJTv66GLbjee4kCzqu8sWMSPa7LkNK7yHbsXP1mUBiGF5sDNQ/zq8ZH/uE5l2FZdT4IJEN0keY1wl4nYkssU/1vBGJpYWI1C4b80a4M7r+5pic+QxOoecVsvh/wdDj6IpY4pRk1blLanLz33gT9djgCsL8/r/WxdX3n1SlUyeiWcQvPHNrIfUfI0Zs1OBn7W2vH0dXdGJYIZ4PYHXF4guDxlChTPgzmpS7U1ng2zZ4wVVTk1wRM2JLXfBBGU5r4Hx2+n3cQeOBEH6cZGbD+3wc1vNTMln9+EOCkTPV69nMB05RJV8wfcl+4ERc8Q9K44xpkf5iYCa7b+lzqrp8qgnVfoXIN0CHADabJctbOBjHzuG9T7VPX7SlEFOAl+Udk/aYCPmMBksBrgSaM/kOK4XTdYAHUFSw9r1Sv2JpSanxKEG3SrDgFmpRAPHYRoVvP5ITULxTZxADTfw8YjH4q3RxB7CVgphhsMYVKsqzXSMFTCdX5W+A4A4m4sg0ofU6/p2EEh3Y1a87c2qoZ2Mq2dDIScL8tuLamQGaQiijqGTECI5hQtL6hoxJ7+zNNTzCiXerzYE01FSjO11US8eDMFTjsIjG9 GH/0EH9I bB9y0QeShD7w03wMAM/v5NKG6OpA+6mXuStp7ybeg8llSXRZAOTT5GYCGqkISU6WIUJPNQrlGLVa0EE2xLB8e/fLtVqPnbzHrCFNmFNy4/3QsL7pH7NlyRxgzFO91uV4JETUIiKp+Ab4RDGHFMoVTp1WeSYsP15uDJDBmWW83z3BI4UKFzSlSwVtuXRLlNECPVgB6IZBMJp5+Sex6r3lHHZqEnLSQbToUDNdg2sH9sa8nhR+U2jSfPuLMaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 19-06-24 12:30:42, Linus Torvalds wrote: > On Wed, 19 Jun 2024 at 10:47, Shakeel Butt wrote: > > > > Linus, please let me know if you have any concerns on the approach > > Michal is suggesting i.e. a variant for warn once for unique call stack. > > I think we should just try to change the existing WARN_ONCE(), and see > if it causes any issues. > > A new "WARN_UNIQUE()" might be the borign and safe approach, but > > (a) it won't actually be unique if you don't have stackdepot anyway, > and will just be WARN_ONCE > > (b) I suspect most WARN_ONCE users really do want WARN_UNIQUE > > so let's at least _start_ with just changing semantics of the existing > "once", and then if it causes problems we'll have to revisit this. > > I doubt it will cause problems, I would be careful about the WARN_ONCE used from stackdepot itself. It's been some time since I have looked into that code but a quick grep tells there is some usage. -- Michal Hocko SUSE Labs