From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06174C27C53 for ; Wed, 19 Jun 2024 05:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 730558D0072; Wed, 19 Jun 2024 01:23:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B96B8D004F; Wed, 19 Jun 2024 01:23:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55A458D0072; Wed, 19 Jun 2024 01:23:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 339B78D004F for ; Wed, 19 Jun 2024 01:23:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EC3DA1C181F for ; Wed, 19 Jun 2024 05:23:52 +0000 (UTC) X-FDA: 82246496304.04.A67A270 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id BA29A14000B for ; Wed, 19 Jun 2024 05:23:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CC+aG7Od; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=klF9jX88; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CC+aG7Od; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=klF9jX88; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718774626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cXTlgSHDZjc1Is0RTeFzg2tLZPe/dlFJM8+192GwUh8=; b=FFNglf4me3SYnxck9xlfmn5FQ7PF1ZhWEBENp/XaaYE3jTS7NGzNQsC49uydtC+pWbP19H 1ImayL6TRxgaYMClUz1WqbBg3dxT2UitljudTQQHMyAtA6tuQOONoBSZwI9bDnch0+Y6ou aWE3c5dKLdw5VpN8rmZ2Q7TAEePUyRQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CC+aG7Od; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=klF9jX88; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CC+aG7Od; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=klF9jX88; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718774626; a=rsa-sha256; cv=none; b=IF1pnJCMEGx+bnxUxRqy3Z0ai0+HOgIYheEqZoQCunCYpeo+C1yah6Cvps6147qh91ZTJ/ zitL2QFfHXoCfn+CTUKsUHib8UeOdaj++DT4AaQ0XwEW21SuRIjI+0KJ43+w0nLpBz8NS5 8JCoV0OfpHYPfpeEnXMTUjwuxfQy0jM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1EF571F7D8; Wed, 19 Jun 2024 05:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718774629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cXTlgSHDZjc1Is0RTeFzg2tLZPe/dlFJM8+192GwUh8=; b=CC+aG7OdhiVVbIE0d9/C++DTJ1b/s6k8fLezYp2sJTx/3u6PCSNuENCV/27MYvbjrE05xu lgJo6YgFVq6gGiWI+Ai6UvQdW9//ACbwSCN6t+7Q8mn5JxeIBzLu8HN9Y44k3sk7rB5r0x i6uVZUPm/Ad4BKzdrExj3J7e4+I+BTw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718774629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cXTlgSHDZjc1Is0RTeFzg2tLZPe/dlFJM8+192GwUh8=; b=klF9jX880MfqKE+halkart24l9VtRseQ+0BkvDmz8kSs0eNgiaMDpFN/HPxWHMvDa50DCy gHFRciyh6CkUo5Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718774629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cXTlgSHDZjc1Is0RTeFzg2tLZPe/dlFJM8+192GwUh8=; b=CC+aG7OdhiVVbIE0d9/C++DTJ1b/s6k8fLezYp2sJTx/3u6PCSNuENCV/27MYvbjrE05xu lgJo6YgFVq6gGiWI+Ai6UvQdW9//ACbwSCN6t+7Q8mn5JxeIBzLu8HN9Y44k3sk7rB5r0x i6uVZUPm/Ad4BKzdrExj3J7e4+I+BTw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718774629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cXTlgSHDZjc1Is0RTeFzg2tLZPe/dlFJM8+192GwUh8=; b=klF9jX880MfqKE+halkart24l9VtRseQ+0BkvDmz8kSs0eNgiaMDpFN/HPxWHMvDa50DCy gHFRciyh6CkUo5Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 53A6913AAF; Wed, 19 Jun 2024 05:23:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 17PTEWRrcmZ1ZgAAD6G6ig (envelope-from ); Wed, 19 Jun 2024 05:23:48 +0000 Date: Wed, 19 Jun 2024 07:23:46 +0200 From: Oscar Salvador To: Jiaqi Yan Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, ioworker0@gmail.com, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages Message-ID: References: <20240617170545.3820912-1-jiaqiyan@google.com> <20240617170545.3820912-2-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BA29A14000B X-Stat-Signature: xcscwwdtb956ytkg1j8xa7gzf19fummc X-Rspam-User: X-HE-Tag: 1718774630-697245 X-HE-Meta: U2FsdGVkX18cT6Ds6YMKQRfSAKm1EHD6ZF92ukN/uWsmla4gaC07ELqvC06tqAH3KTpXewVkk/WcZQ4/7QI6jco9HHRWzdph69B/m8DbxvpCe9W2lQ1Dv/rMDGCfc3HFSdDwVsZL7EshBlq9O9Z3XohY+3anfJldfd5pQKTpq3SgZtEopCKdXJOLTv3A9GhQezDUkBDMBeCgOFEtt690eLaJ+Eu5SZCdyA9DPGjrJUoJQs6GuMllDGSOTPiFoJ+0aM4ZgVZJUwDdiT9F0N5YAfhm2xr7sArPPpPM8WpwXkZ8iGLV1zSYjB0xXqBolHXqqh99iKw1JQ6Y8xBZbvxIS6xUS52lLVGRo+LBqIKGdqkVhj24/dajW2va77PVKJZdlJ5II+vPaZP7jY31FhSMlnJsYXpDQvQiijZJXj76VkK3sc8G7EFqKvDGr52a2fUuW6vG4y5TSuwgheuyp6MG0jHfxkfGXKMmsazfpr0Smxsu2jKw94qEa3Ax9C6E6dGdWTahuG0Tts4yo4LK2ZfdnZ7VEZZkN/tOcuhrF44h0Ltnp+F3RaUyyfN+SfmAbj1sHZlSFPabwOIv8l5OX9WvJ0RhZENhK6xgb7BCAaTRXyy2lZGu2Cdlql4b6/IERfum3q7QJJc8C3L3ZcH8OoapzSMvtHNwxg2oeDTLJLNZvwlNcMtzhtn9u8HShv1BlAEmml0/CBQzsBXzf5lYH/CBGD8UrHYn+D89/R+5/f9+vifNPDIB32B/lUQ5GS9ZamHWK8mfbRDKsKW2cVLptRprB2o6lON43BTK3GWgJ57QtqpsmIg5EpKRyR5QR5tTTMLWGsn2hOm9ZJVThKPB1tEK7h9NQk/mKHpxUZCcbkG2f28u95G5EfbQ1y/1oMRgkRAA9JJ4PldLj1SMC3TwyhpgZOcOEhFVXdJG6WakQBt9pHtuBn8wSPAh2aBykB2neXCLci8hPqKLE7Te2g31g5m /Use1Shh s5I49elLjEXoFDmFe/DOSf8RILzBn5cXpgPmdxqToQGL3Ki74fYuHOZoUD4qmhIg0oiUjdp7rCGKyfoauP+b6dzOgFuxOsOneWIoi464U1adMuAPVQscDBS7WQtnVFgvLOQV1dTg/pPuUUuDlnJ1mMJHfCzflYRa0HUvt/9oBQVsho6A37JBVYjMa/Jfh4if2s+DuDTIm46V58PWvH2lBwVZLQE+vob8VPg0iGjSK/rVMxdklazRt1aHeBWPtoQlexnBatpehYCr2aHFYE9pORVlIug5AELK/NvS2uDuxovyocoIpjFcGCaTikUDSTbxAF6148sOyDXFxwqGanqAlGhDLYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 07:03:46AM +0200, Oscar Salvador wrote: > We should not be doing anything if soft_offline is disabled, so this check should > be placed upfront, at the very beginning of the function. > Then you can remove the 'put_ref_page' call. Sorry, I managed to confuse myself, this has to stay as is. -- Oscar Salvador SUSE Labs