From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5486EC27C53 for ; Wed, 19 Jun 2024 05:13:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE60C6B02D4; Wed, 19 Jun 2024 01:13:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B95D26B02D7; Wed, 19 Jun 2024 01:13:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0F076B02D8; Wed, 19 Jun 2024 01:13:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 80D8A6B02D4 for ; Wed, 19 Jun 2024 01:13:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B4615120D83 for ; Wed, 19 Jun 2024 05:13:25 +0000 (UTC) X-FDA: 82246469970.10.F0C46FD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id 74E1318000C for ; Wed, 19 Jun 2024 05:13:23 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vVGeMBFr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=dapU7svZ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vVGeMBFr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=dapU7svZ; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718773997; a=rsa-sha256; cv=none; b=Q0P7ADE+JSJuj05byvtguZLYPbhGg5PzHmcZiMuA+adGv6ChuzBCiHMrRK6ooqsQQSPNqW U74hTcabcYQc94Lv7YIG1u1fVE4qnup0sK9XOuFSF/kJETNqS4tdbUeiNFWi1j0Edlxjpm nKJnIX4IXE6h6xOm3VYonbE2+7/34gk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vVGeMBFr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=dapU7svZ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vVGeMBFr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=dapU7svZ; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718773997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pAG5AI+tavN0s8ygl8OS0QBr+oMD6ODJzxCJLwUfzhc=; b=OXHRdH5ksoNBgeF+IciCNH8oL1xp34dF3bT2z1nPk2jy6knMaDxdJZGBByBssGnMhJeXjK a7g+vCUq4cBC2E43R4LOtqES1IICGiCRSlvX/w7+meIPT3xTG3bTMrUCRIbvV7RNe6FoLZ lqyA/Yj53uASmztwaoqNKbmx0ZLdo58= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C959321A17; Wed, 19 Jun 2024 05:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718774001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pAG5AI+tavN0s8ygl8OS0QBr+oMD6ODJzxCJLwUfzhc=; b=vVGeMBFrYKf540KL8Le+kmrqUf2d3YuKyLA+CmM8jxQ3tgyn93YdD0NLfQgDjdZmtXWBIg vEwlEA2WtrCtlnaDpo4NPbIPb6JO7lh2o/JGoBOuSwCQEgNPSYQoaBq41YtKOPhannSJ5l HEW0e1jTlOkbtWpkuX+jaM0FoWqDBdA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718774001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pAG5AI+tavN0s8ygl8OS0QBr+oMD6ODJzxCJLwUfzhc=; b=dapU7svZmG0V/wdtL9i4a/DpwPHTnute5Bd4Fpe8GWEjrIi28Xg5L/mzZPlGQnkFoFG2jI nUTgSVti8ypNv7Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718774001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pAG5AI+tavN0s8ygl8OS0QBr+oMD6ODJzxCJLwUfzhc=; b=vVGeMBFrYKf540KL8Le+kmrqUf2d3YuKyLA+CmM8jxQ3tgyn93YdD0NLfQgDjdZmtXWBIg vEwlEA2WtrCtlnaDpo4NPbIPb6JO7lh2o/JGoBOuSwCQEgNPSYQoaBq41YtKOPhannSJ5l HEW0e1jTlOkbtWpkuX+jaM0FoWqDBdA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718774001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pAG5AI+tavN0s8ygl8OS0QBr+oMD6ODJzxCJLwUfzhc=; b=dapU7svZmG0V/wdtL9i4a/DpwPHTnute5Bd4Fpe8GWEjrIi28Xg5L/mzZPlGQnkFoFG2jI nUTgSVti8ypNv7Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0612A13AAF; Wed, 19 Jun 2024 05:13:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1lD0OfBocmbIYwAAD6G6ig (envelope-from ); Wed, 19 Jun 2024 05:13:20 +0000 Date: Wed, 19 Jun 2024 07:13:19 +0200 From: Oscar Salvador To: Jiaqi Yan Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, ioworker0@gmail.com, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages Message-ID: References: <20240617170545.3820912-1-jiaqiyan@google.com> <20240617170545.3820912-2-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 74E1318000C X-Stat-Signature: 9db5z5ksfgj1dp8douxu8kybsbmoabjo X-Rspam-User: X-HE-Tag: 1718774003-462680 X-HE-Meta: U2FsdGVkX19yEQ4QVLnAx1icux6rideLEUKTjbKlF7glpXmnb0nZR3Uikp+x/AgJ6Lr4OoRUVe1qbfKzoEIAimX6QQrtXXmB4fe1ii3W4fThlBiq0EyEAptrsyYJQ4YvTxqaIy7j4c7xP04ubOaxUrCpoShzOsQDsnzp1v/uZx6N68KXtPDp87Keyu3h26XIdifsq5bmoU4wHnwkLOszmY5rR5oMBvWjUZ4haAxpDg1KVsBH9/wNq32H5VAQJ1ZnGIwreA2AKq8D+KXB2A8iyqCxIhhM//2JkDNcOmNj9LkANr9PcfUP82lJpbODJTXKMQQyNcAvabGHAMkOhWZL+CRcA+jP16xc97YLhca34ux0wxenhQ2ryEHqf9OWmRc5FwpZeHTgF3xM/K3/ZroPlpqKbCwowq/W4fL5ve0C5koTuaYmUb7jC2VwH+qHF3WVWFTUB8bAc7HvXHR3sFZaNI0XyLL+Ceo1xLT387GKuZjvRPcJTKr/HVivvRbaOeOBgV+0UQATPe71J+2tgp4dn70djUtxyGGk9NefoTa8hTQDrbSqdfg1ygBVsMMD+GSdLZBmZpk6ZsQJByndDFPhZL9KcF2P6fxd8OvVaIhSr2lu37sSmdH5pFbcGrnWapQZRzzJXHwkWqXaPQvPylsEqHdBxyCnLDiu31fWa0bmeKLr2IKUhh+qe8KnEbq9AZH9MDjlCf+ZG8/HSjosyQ7kRW++gg7oR1hHfsBGADBdpbbHp0qaIXvymoEYaqduT2N1+QkcIId8mky3u9qeVwn2dodqyoIXsgqA5Hls++dJRZHwsE1gAwFwFxqrToBcptMlU1lL2WNcLn6HP3FQv6PXd4hK+69FBhub1zjEJfuOWCMLHwLNCvcRu7h8fdxy2NyAUCgCJ7LqXGM8GEVLEYUW6Zh4VZv7IQ3TY8hCWyCRij/g1s0h84CEuAitQ59cd1+W99pKUNxTe/X2OxtIPaE fodh3WwY Kw066wvyxbkhOxifbf2oJbX9wFt8PpCLvZC4JaulmNt+DF1Fj2a2Cc/6Q9eL9QGtScHCUTyq/kMmEgwK1Gy1sXJzWfnnVsAFk8cFY/W+vj27O8k+PrHumiODrWTv5RhsPkFlJXoFYSGtkQhUMZLhA8EJ4ocwCiAPFpkbnaOoRptEIef9YfanZZJsyrkyKYD9ckSV24Gde+w+/kUD2uhfL/AZzRegiRkl0ElDJi0DF7WzPkkbr4l5PclaJdTYRZLZY+wVHcalxxYPraVgdeljAGxZ4FinTx+OjL8ni57bAmuQDRouP36mWklwTiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 07:03:46AM +0200, Oscar Salvador wrote: > On Mon, Jun 17, 2024 at 05:05:43PM +0000, Jiaqi Yan wrote: > > + if (!sysctl_enable_soft_offline) { > > + pr_info("%#lx: OS-wide disabled\n", pfn); > > + put_ref_page(pfn, flags); > > + return -EOPNOTSUPP; > > + } > > We should not be doing anything if soft_offline is disabled, so this check should > be placed upfront, at the very beginning of the function. > Then you can remove the 'put_ref_page' call. Also, I would go for a pr_info_once here, as otherwise we can spam the log quite easy. -- Oscar Salvador SUSE Labs