From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17AAC27C53 for ; Wed, 19 Jun 2024 05:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 465036B03CE; Wed, 19 Jun 2024 01:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 415446B03CF; Wed, 19 Jun 2024 01:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DCAF6B03D0; Wed, 19 Jun 2024 01:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0FB816B03CE for ; Wed, 19 Jun 2024 01:03:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 95724120D6D for ; Wed, 19 Jun 2024 05:03:52 +0000 (UTC) X-FDA: 82246445904.10.87AA6E4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 7227AC0004 for ; Wed, 19 Jun 2024 05:03:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dbwi9B83; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2PzFtr15; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dbwi9B83; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2PzFtr15; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718773427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XdNAJea0S6CPZeM4xRERRTfOhFTKjQqO+lH0ABKDivM=; b=eJpcz0EguR5UAdDwT2FkCU2BiTWpkbNABe280uUoeOT0SdLbzYzLq5ueNbZWkQxTowAOd7 EDYLWbHbLj6VJWkRYhKYirHgTyUs6QaYrCnHQdWfQILCu93yIqCS9+PjEzrZbKhKB6/P+E ILorqWBGbeRfWk6rra6q9CoR8lw1GbI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dbwi9B83; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2PzFtr15; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dbwi9B83; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2PzFtr15; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718773427; a=rsa-sha256; cv=none; b=B6g2rUtIvnaq3HeL+B6Qu7Dmpw53bhNIGQAu112lruiU2IbQhMlMpAUN9T+D1JoRKoxiv9 sj5HN7NRiwhLpjwWvjsIGTmAmu7uRI3TYBX+5juZExz06Cv+YyvgJ/JPAsbpXDzw9CgB2H jMTpfHeosyh9k9HSBjBXFuiQDUDFelE= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA8081F7CC; Wed, 19 Jun 2024 05:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718773428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XdNAJea0S6CPZeM4xRERRTfOhFTKjQqO+lH0ABKDivM=; b=dbwi9B83Ru9C8eTWGFvA0DybmcDpwG24WK/4NmvD9bP0ODDbFpvGusi3DecdoISJND7sdp xhgnwbLJ8M7X10mfYO4jgZEP5T/uj4aJpTHGxCNHYHtTFuUdY58YY8ZLOikDqJHXgyLfmW /W4xHUpgZ6TZ6k0IylMrkHuJOfXbEgo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718773428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XdNAJea0S6CPZeM4xRERRTfOhFTKjQqO+lH0ABKDivM=; b=2PzFtr15ZIkAPObLlVVbQ7Ny3pni/8Nx45a2yhcqaQ4w25hWk67ysDnxl2kWnArHoUY8l2 f2WROdLl+yTPjGDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718773428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XdNAJea0S6CPZeM4xRERRTfOhFTKjQqO+lH0ABKDivM=; b=dbwi9B83Ru9C8eTWGFvA0DybmcDpwG24WK/4NmvD9bP0ODDbFpvGusi3DecdoISJND7sdp xhgnwbLJ8M7X10mfYO4jgZEP5T/uj4aJpTHGxCNHYHtTFuUdY58YY8ZLOikDqJHXgyLfmW /W4xHUpgZ6TZ6k0IylMrkHuJOfXbEgo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718773428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XdNAJea0S6CPZeM4xRERRTfOhFTKjQqO+lH0ABKDivM=; b=2PzFtr15ZIkAPObLlVVbQ7Ny3pni/8Nx45a2yhcqaQ4w25hWk67ysDnxl2kWnArHoUY8l2 f2WROdLl+yTPjGDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 17F5113AAA; Wed, 19 Jun 2024 05:03:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PZa/ArRmcmZwYQAAD6G6ig (envelope-from ); Wed, 19 Jun 2024 05:03:48 +0000 Date: Wed, 19 Jun 2024 07:03:46 +0200 From: Oscar Salvador To: Jiaqi Yan Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, ioworker0@gmail.com, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages Message-ID: References: <20240617170545.3820912-1-jiaqiyan@google.com> <20240617170545.3820912-2-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240617170545.3820912-2-jiaqiyan@google.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 7227AC0004 X-Stat-Signature: pfjaam53bddp4z9my4ifr3ir8ti89utw X-HE-Tag: 1718773430-322979 X-HE-Meta: U2FsdGVkX18O5I5fD3UVvX+E6qBpTlhAq/GOYLjrS0qmlEtrhycyMvPfkrRqiTF7eetLFK+HMsHNvCm1bzinZCMD2PQMEBiI2MHovmm2YRmJ+TQTn/HXt+N1ZeRQJ1CI9LvQLSDcKNt9j/+9g0N9o6ub7Y+dgnrvlUuyAbilWwSfj2P/O9Cw7BtfPdNhTgiOZZt0TKdR9sE+SW8uTrU6+TYnkywmLQlHPok1Bs4QCa3m1jqKYCQjxXHZ2LzMxVqzNhnMuo+NWQS2czAFwPda2EFpCO3HLJInHpQ16m/z9Glcirr/F7/9uooY4GvIPC9jwSRYuBaacKAo1F+38uqReTFdLkbbXR4EecF9gEPsmSZN15fqivp+3njoMI2VA+pOsin+HKVtKiaSksy2IKZUS7IL9kGT8r37zMIVUYyPrEUqEhtvZVLAYO8tvlBt/2AaZ7rGx7WBPmDHCcyM0sgZapU8/vMMfelALdyomQpxuKjUUGSICkNHdaNbljkJe/xaSljCBLkO5wCXLJ/B5W2vqK8r0pP7TmcLCC9WADXkaFbSw9FWrkEK5oGlltZjeJ0b3HToH9uz+/F9r5JpzkB1w1yOw54o6RsbRUp6pAstAdu5TOPJx6hZFd/jD6X3JlL/+wmjBqJFZ/627WAE8JkZbUq/pTb/cNfsk0Wa/WnKhfvr5YMPSUdINbCHFbxrUiM1qHR522sjLezKllXjGjIOSdZxAh7V69wqDKTRVvatOcAFDcdPmon78+iQth1HSWh5d42jKuVroVRmwN1G651N2SDB5smXYuetUAFAb38gmk/ockq6onf3HxvfntyGA0GNIJ0+IkeWq/4Ue7f0xaFw6Ht1ZyhNyY8SrWEEvGc6RTC8AbIcEJjpuwEbezO7GRXk7Dpj9DHnjQKf1WxxCiGCsTMBE4QidMRG8HC9zCwQYZnZckkvxE+j4xtkKlWfzwY4xTz9UjVD3EJbkpjJGNq iuHclWMH pAb+ck+21Bq0MKDJt/Twu0pcrHBdOBezXbeXyswqcWx/9rcK3zcF6xcDHEZ6nk/Wf8PRAZC5nJdFc2UvYZMKUz4av+eTdXe6tRodWxjjgDEtwohuEzjroWlDQR30WcVoR9JF2Q17Xe12wHks1rXzs9L/wvLhAvm1KkB2zJ2/Ij09rQ4wvgwGmh4DgDJqs7LNwBf18EyUQzcVueebnGaAgGYECEHsn/l3/fTxgREKefiz8AqDst02z4rPlbSmPAIZ8OUcBd+NS85pd7YW1WbxrgCpDzoJxdAXVGuduxPVb5bX++Rl4wJf+M8XyOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 17, 2024 at 05:05:43PM +0000, Jiaqi Yan wrote: > - * Returns 0 on success > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event > + * Returns 0 on success, > + * -EOPNOTSUPP for hwpoison_filter() filtered the error event, > + * -EOPNOTSUPP if disabled by /proc/sys/vm/enable_soft_offline, > * < 0 otherwise negated errno. > * > * Soft offline a page, by migration or invalidation, > @@ -2783,6 +2795,12 @@ int soft_offline_page(unsigned long pfn, int flags) > return -EIO; > } > > + if (!sysctl_enable_soft_offline) { > + pr_info("%#lx: OS-wide disabled\n", pfn); > + put_ref_page(pfn, flags); > + return -EOPNOTSUPP; > + } We should not be doing anything if soft_offline is disabled, so this check should be placed upfront, at the very beginning of the function. Then you can remove the 'put_ref_page' call. -- Oscar Salvador SUSE Labs