From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1B5C2BA15 for ; Tue, 18 Jun 2024 11:04:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFCAE6B0348; Tue, 18 Jun 2024 07:04:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAC376B0349; Tue, 18 Jun 2024 07:04:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D73986B034A; Tue, 18 Jun 2024 07:04:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B8E146B0348 for ; Tue, 18 Jun 2024 07:04:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 375991207B8 for ; Tue, 18 Jun 2024 11:04:39 +0000 (UTC) X-FDA: 82243726278.08.AAFDCE9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 8996B40014 for ; Tue, 18 Jun 2024 11:04:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="MkbND8/E"; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718708674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IPZd5gC4o6uT2uD074T8ssLIueZbtbScXSyIcrAM7Uo=; b=IrSrgIyP26031HG2hyHkK8Xjf7EDOEwrHNCdmEx5HzzSQZEdx9PFKdcy1RIa0Ym/u6kCTW O6GlnMyB5Lr7NUQzdBN5MeXTCFw8Ayf3p7r3ozHnSTA6hLKC+3IZFnp5bkCxySIc8RAQpG alpYNNHvFFYs9mavaXIjsnxcg+Skd3I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="MkbND8/E"; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718708674; a=rsa-sha256; cv=none; b=ytmMWnak+mC4fK/7cOt6SjHKyxKpS2ynL3uMot72EIL2ReeE0h7bOUP80psO5l7JMMtmTg 5bCSqwjZ0+ziMiRpHIgEeD2ca3YvR+krinsb47Zc2G7xkOaLxxe6Q/axUZQSBIWV6kIkD7 3geeGKFMMlq8fsU60y2eoVL7nwJ1heQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6AE0360F4D; Tue, 18 Jun 2024 11:04:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D9E1C4AF1D; Tue, 18 Jun 2024 11:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718708676; bh=NY46nA/XWYixeSE6/TIdJ0Mru4j2agru9bQrVnYDEZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MkbND8/ENHkB+4ngD5QwaTxyG1rFJw4MP4C5E+HOS97H/Ct/x9rh+g2yudcs7Ptf2 IGiZ6yQgB4URmFoTOkOD0jSg+pRXh5kv4kg8nGoJ6b5KDVxeEtizWihsyEoOnG6bHn 9NEnrBD1GZBABcyvrf+BuTlg3nrP88hBYt/zc86SKnCRqN6K+ypY44bNgqo09E14zo RGghIT+rO8S7xZ8JnQIs1AZJM6+dn99w5jxr0L0jIyEBLESuNAy3uLzfHD3559/K6M tcRxfMT7DqtjxkKRIS9YifzD+twtbjRG8Tw4i9MepHz7qNL8VXgan9tKvwFQwbSVXT PY1ABvFXT/Fgw== Date: Tue, 18 Jun 2024 14:02:20 +0300 From: Mike Rapoport To: James Gowans Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alex Graf Subject: Re: [PATCH] memblocks: Move late alloc warning down to phys alloc Message-ID: References: <20240614133016.134150-1-jgowans@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240614133016.134150-1-jgowans@amazon.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 8996B40014 X-Stat-Signature: 1amm8wousgh7bcaddjiuhsbomwkdm139 X-HE-Tag: 1718708677-944468 X-HE-Meta: U2FsdGVkX19xSFRSDrjSnb5fzQ8UOd3LGyJpLLRkU/1h3y/Kscvz3+2QX1g2l7bxCH+nLB5NdkY95HKd8hwokQ5+GNElvUmbv5NMg2a/2elYGVnebDbvxPEXTAbtzmiWpPoktxgWSEXsLaUal1PKRXJB21U3cPr7mmN1CdEg3UdO7DzOUjSt3OX/N5nUdqkVbNBDfU3uBR2JmUtSZsdhk2/HNvvbILc5x6YLGKU1HCv3O/NyXouk3s6S8YheDCXqWgbINfWMNGCO9Mio5ZHnpjKWszCiy5Mmmd+mEWEW26SCSnWcLD1b0WmFaqWzuZ037noOLKXp4CkbjZL+Tt2+XCsmcmj09h6OAAF6AQmABdffzqdxpy0rRSNTumCKvNiN8WTWnodYlirNWEejOWRIVnXslLqmqK1kNNu/r5KLP80ACz3hezKZSKiijLOCUEYWtKX605phpfZVBXIdWRLj4tL9b9PAuI4toqys3j6ANAYpPz5T2TksmW8xnP7PajvCzTb+Pc1Kqy1n7tZIRcNflos/kjEMkcffD2uoppo0x27XSNEdrNsk4KsKUBclZ6rYwlDvtRiiWeyKlvKMvBh3wZJ3d84Lw/wSfQeN3fR4G1viJxBs0Q7az9KY7DA9/i2llRFBAphh7rKWHDRf+tblW5/6xWH8Tns0xmUSExuDhU5/q5Ypad5/xGMEuT/uREfS9cjds0tyL063DMflRGojwOOdMsjoMoDkfBwSpTDvI6+uirJEYqAp9UqZerYC81LqiqsvT1eZWCqZ5pC43VRpAI1YKn0Vn58AxkRAqoiR8lFzRrEkT3ByGNCghPI2j6ykbKX0FIKDqG8jvFkCl5XWq0hMfRHbuTZCw5CZJiUcq260QB1ZHmfT+z2M0LSsf1Tmd9b87HpxrF5MYt5dv9+rw8wvr+9IJ1v57uRBxJdHhhTC9hjaxEVWotvTnm+KW44rLqNJG51qdEHht30iaxE yubuZxmu /tTnTlrd7ijQImOMkQi0Q1vRkNZIR6MovON/PExd5bqRnqdKs/bpKv/Xqwn3Zr9ZGoKbdP3+p8UfCyJ1qR9sb99cm5oNaL+ZmZsL+xjwImt1n7p/N6I7At/SIzUdbkH+QmWppHqT1aUcAKOiOzDjL1J5/Onbi8jKHReEJt0QXsYXm1+S5Z147p0aVgYrRV+KZBs3ibRQW/VdwXYOZERXrlNdFbX2GZKUpB9FlBir5s0wSK0dS1KOfEbznVHmoSmZN4EKdMsmNKnmvwmXLJLrFGoars/iZs+Pxh9vazsVzPlWspmWQgXSFxzdr9VPpSdPzrH8i9XqcJXPlpnOhf4Xwobgfuv349QXW5PlPhWVnhD5y3V8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 03:30:16PM +0200, James Gowans wrote: > Subject: [PATCH] memblocks: Move late alloc warning down to phys alloc Nit: memblock > If a driver/subsystem tries to do an allocation after memblocks have > been freed and the memory handed to the buddy allocator, it will not > actually be legal to use that allocation - the buddy allocator owns the > memory. This is handled by the memblocks function which does allocations > and returns virtual addresses by printing a warning and doing a kmalloc > instead. However, the physical allocation function does not to do this > check - callers of the physical alloc function are unprotected against > mis-use. Did you see such misuse or this is a theoretical issue? > Improve the error catching here by moving the check into the physical > allocation function which is used by the virtual addr allocation > function. > > Signed-off-by: James Gowans > Cc: Mike Rapoport > Cc: Andrew Morton > Cc: Alex Graf > --- > mm/memblock.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index d09136e040d3..dd4f237dc1fc 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1457,6 +1457,17 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > align = SMP_CACHE_BYTES; > } > > + /* > + * Detect any accidental use of these APIs after slab is ready, as at > + * this moment memblock may be deinitialized already and its > + * internal data may be destroyed (after execution of memblock_free_all) > + */ > + if (WARN_ON_ONCE(slab_is_available())) { > + void *vaddr = kzalloc_node(size, GFP_NOWAIT, nid); > + > + return vaddr ? virt_to_phys(vaddr) : 0; > + } I'd move this before alignment check. > + > again: > found = memblock_find_in_range_node(size, align, start, end, nid, > flags); > @@ -1576,13 +1587,6 @@ static void * __init memblock_alloc_internal( > { > phys_addr_t alloc; > > - /* > - * Detect any accidental use of these APIs after slab is ready, as at > - * this moment memblock may be deinitialized already and its > - * internal data may be destroyed (after execution of memblock_free_all) > - */ > - if (WARN_ON_ONCE(slab_is_available())) > - return kzalloc_node(size, GFP_NOWAIT, nid); > > if (max_addr > memblock.current_limit) > max_addr = memblock.current_limit; > -- > 2.34.1 > -- Sincerely yours, Mike.