From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B58C27C79 for ; Mon, 17 Jun 2024 23:18:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D91026B02A3; Mon, 17 Jun 2024 19:18:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D40EA6B02A5; Mon, 17 Jun 2024 19:18:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C09A56B02A6; Mon, 17 Jun 2024 19:18:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9F72F6B02A3 for ; Mon, 17 Jun 2024 19:18:00 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 299661401B9 for ; Mon, 17 Jun 2024 23:18:00 +0000 (UTC) X-FDA: 82241945520.20.F06E708 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 3866B20013 for ; Mon, 17 Jun 2024 23:17:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KDljzpGI; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718666274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y9Jd7sTiklQCLsza9lamlBiQHn1JuoBWARVrfGvMzy4=; b=xc9lDmEElikPzmszTcOTWuOYa+ZJKNlnvM4uUDwSOtoK5EpzP32vEMNI1/oSWgoFMbofjb EA01v/33MwoNuNY123qLW6CVELA1jAdidD8qCIaz8W33WhiKqwqEZPOE+tKDRXCMceFJSU B4Iuad2AWJQAJqP7wgAdZs7lnUkZRYQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KDljzpGI; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718666274; a=rsa-sha256; cv=none; b=i9e6cYshDsvTmzDGYIaHkOvxFMQDwnjSf7zjchz+PeXQ6DEMAOHle0WIeYkEfebvHSTyK6 bCj/gw4BsVf0rEzgw/rDv/WbSaCJoF5ExRVX1mNOlvFubj9DEyAmABGHg0uTIPy3w6yKsM ZS7ThpPC7MwB8IeUxFrAPr5G1oNA5So= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y9Jd7sTiklQCLsza9lamlBiQHn1JuoBWARVrfGvMzy4=; b=KDljzpGIzUgr80m/yNUNNxDC9t O2nUqAqzuTqkx1KYhj4a/SQA5xnK5fvRRpIjOYfuW2pUwObzaz1Z8KRL+DUxA8qBMowOsoIQymk6p f81wPG3efQ65zmp8A5ahZ/aocXo8A6R9Z8uZnDFzq8gz+gk3zZ5kZsmnjB+0oRrIRtU534aIA8VzH g/hjsNgItbPANKCOgcrGO5znrXUU/9hpCK6EKaWZbo5TFUmkiSX9FmYtICwTaGuUEi6ZrKKzgINrF ldWQaYL079cjnE/vdvX808gZTS2A8nmR9p3yPkhuHd5boSGNvdZi8pizW/aWkMli8TFmyFL533uwR 6PgFwKFQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJLbl-00000002Ykl-3nan; Mon, 17 Jun 2024 23:17:53 +0000 Date: Tue, 18 Jun 2024 00:17:53 +0100 From: Matthew Wilcox To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, sfrench@samba.org, Barry Song , Christoph Hellwig , NeilBrown , Anna Schumaker , Trond Myklebust , Chuanhua Han , Ryan Roberts , Chris Li , "Huang, Ying" , Jeff Layton , stable@vger.kernel.org Subject: Re: [PATCH] nfs: fix the incorrect assertion in nfs_swap_rw() Message-ID: References: <20240617220135.43563-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240617220135.43563-1-21cnbao@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 3866B20013 X-Stat-Signature: 7cg4ehk76bo5c883ukmmufk1ah8jocgt X-Rspam-User: X-HE-Tag: 1718666277-532979 X-HE-Meta: U2FsdGVkX1+mdUQ45bexrB4fm2uvLL1biEWtfllTPFhArdd7bXaJTuhtzQxJs4k2+O71Y05sYAnyD4/R0YaV84PWh9m+xC6pFqNWkfwLh9gDwIybtAKILv/sT4ZtftmsCm84LBRCyNdOjTOIHMoAnLr4b/WBKQZLkoXBvhGa5ZD0tnTLvEfMdudFw55Bhm47l3C3NJNdzzxqm7qLpXPd2UKPCN/01OHyqcxq+t6reAlnxxDfBqR8PJWPGxjbAH/VmVUiMOyHbLhCS4jhup3ZG0q9U/U9FcBb+sOVkNBYujCwGK8csH1/i6aLEhGA8yUTwljPvWOhmVoy0w/PN0kq1EwK5sUUtrNEsEoscPH/R5fw0QdxNl7URVHHVjce/J1apFjwLfMr5Q0KIZGCGdkcWPY9dsZOedlWCmcIi6BNbZKUzrVc0YUDT8r1AgEE1TOt/dhtxV6TIqaz10kpB3Cf1AZ0eM0DDLfj9RNEDbgmivLDmtkv5qB2AJanJbVVrku1th6BUf3G3sD0NAt68NLINey31dVpwtogwtcyv//6Fkr8uYAamoEfy8CHu2ujT47dVnmTMR6ai1aykryRB/zPW6RQJNUcdABPszVmOAh7CbqqxMOj7CBaX7usK2uM/0eQG0bJiIe1l9qAgS2DYVXXXhocbfQ/UZboGxBAtDbTXM7UVWpanYejXADM3rbSsiYjd5gJMtTVuUrwz9sC43jcnhQVNHkr/CwHH29zJma9JJ2VkWjU8o2u3cFcQFH4hp8tSuGjMJhzdg60iR+IbTPUrPV16ela9zwiwMW8uzdti/CNwniJvBq06Z3z2eo91mPqZIg6cItENo8KCzoVa5rdQ6naU5cQ8l2AdxWMd0A8Hu8x1Sx0C1iH540AW3mDDwXEuYd9VXufRlZRdKXSYrJ84mxCsew/RLUo0iomwjr2AGW/MS95sfvtNI5s/n2WP18KW1cXQwVqOsmWBaHIigZ yqlBVrcX +dKdbz6mAGKu52frGtITWGNrTFWpqiDhBck5WOOtLow/qw/1uG5YoD6hpS8FcYs/PPQHmvAzKYivB3pw2w06LMR3duYrldQiCwqleqXk1KxhbrnERLsJ7TJcad3FKqBLONMUdy9S3vCO8Ys9SI3n3prVA1YFZPQueIKxvg4pWDFhWnYDQP0mX/U+LC4wV19R+aEUSa6l+COLt2UmXD0FgR8aGyOBBPY15tWeJHMpzhvHM8tXqH3JsY72bYWfch+fiC1zh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 10:01:35AM +1200, Barry Song wrote: > +++ b/fs/nfs/direct.c > @@ -141,7 +141,7 @@ int nfs_swap_rw(struct kiocb *iocb, struct iov_iter *iter) > { > ssize_t ret; > > - VM_BUG_ON(iov_iter_count(iter) != PAGE_SIZE); > + VM_WARN_ON(iov_iter_count(iter) != iov_iter_npages(iter, INT_MAX) * PAGE_SIZE); Why not just delete the assertion like Christoph did?