From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A97C27C79 for ; Mon, 17 Jun 2024 16:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A1426B020B; Mon, 17 Jun 2024 12:10:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 151CE6B020C; Mon, 17 Jun 2024 12:10:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 019386B020D; Mon, 17 Jun 2024 12:10:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DB6006B020B for ; Mon, 17 Jun 2024 12:10:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6F2331C0ADC for ; Mon, 17 Jun 2024 16:10:27 +0000 (UTC) X-FDA: 82240868094.19.94B7396 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id DCCD520008 for ; Mon, 17 Jun 2024 16:10:23 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fqGn95aP; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718640623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6No9GIcViYA9Qsa5BjFQUlS6BgSash6AcUNuwZCbz/8=; b=JA70EEDa/oS2nVjT6zjJlMFEwQDsCGyYSF/4Ml70hKrZXQ70bzjw16ik4eXrjtPjnobBsb eWqwRN900NjiLLjPmJKzHz0OaVynyMHvh5Bq5BLRIUzLNxwgb575LJ1lQYWdUYNoUErrRa jjPLx0CvLivvONEQ4S+JIXejq2r4AkM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fqGn95aP; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718640623; a=rsa-sha256; cv=none; b=Rw7wB420gcfn0lrQzrYWWNEDLm0oPr+u02tpwa0uuQAT2SxKNvf9q52PbK+3/b4zEtlEDc 4NBxP/TOYK62bCHt2S7vDXKRSj29Se9W55QNPtd9s9NyE/OSFbtaTcHxuiMKNHuLJanqGw lopYrKvJIZLc70+xpe5yBznGEX+tjLg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6No9GIcViYA9Qsa5BjFQUlS6BgSash6AcUNuwZCbz/8=; b=fqGn95aPR/20iH6RT4ae5iOgiY dGLQ2RFf23Rw6fkK/zl6TLzEdL3RQ7i4MyJnUI2dJy+ekYCvoThyKbfvqpgn/xBS9TDuwTwHGcOA4 VudWMrwKmev/AjluV//LxLMe6+1FKcvCu8ZAhSzw/JWrKRDmGohDhkEouuoh7/uSu6pj+5TCc07be t/vQhogaI+Pls2cjL+5cuCYOyRVLbCOC7ZxrNavFHfU6cnUMSHm0htceXSz+Dg8920KPnQRR6B0rO JeG82MFfZhxMjN0uQ4NNcp2TFVST+i5KY4XQcvYK4JhFaRPFK4D9SYuzzqndMamvLb3T8PiH6Rc+3 rco86QdQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJEvv-00000002Gj8-45VH; Mon, 17 Jun 2024 16:10:16 +0000 Date: Mon, 17 Jun 2024 17:10:15 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 04/11] readahead: allocate folios with mapping_min_order in readahead Message-ID: References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-5-kernel@pankajraghav.com> <20240614092602.jc5qeoxy24xj6kl7@quentin> <20240617160420.ifwlqsm5yth4g7eo@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240617160420.ifwlqsm5yth4g7eo@quentin> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: DCCD520008 X-Stat-Signature: dz818nmpcyehugzo5hyn5hiseg9oritn X-HE-Tag: 1718640623-669115 X-HE-Meta: U2FsdGVkX19K9wFPXTGCMMGhWD2K+nSX+VRoWX7+jNlZcWjFlHUz3eH7R76z/5PA1YdOa5DQk7JJubVj9Lx+HYckP8PnE+8eNir93YaA3oFejHS6xXYk+b/hUG2haq59iVTaUYl3qSb4F+V+bpyMeD60Nr3oF2z2tnstdb8nlqL4LiZYyUZ4i/bYUMovDBEVRp/gpq4Yks3TrTfu/mMd36ErMx3rIsymWaybimXGQeea9OE7XerLsGHwhke66m495MU/P2Ktzc+shPepxS9NA8I6Y8NEUOhpjzQhINuMpB0fzEzokiaGP+40ZB3tx45e5g7jB6D3yl8uMkp3g+9dp2mw3yc3h9R2ReYphw8y8IB7X2wbptyiDZKd9EarmYkqR8Tu/0+JDi5NZkK9AGsZyeI0l/oXZxad05g7PPYORtT7zu3jR1EvA7g6xnLEWkDg8MPATISObMFR9GoPxFXZV7vSBomPDzguGJIlYLdFmw105gSMEp8L8QMhKDusMe0AeLW/+yB4jz/8dcT0uCy/PK/coT+uPY221JSN2lZfhM8alvSc0vFmJ4rtG86cknj3B6MCLE2Xg7iua9IQeWA5gTP4MPMS54wDu4LgmPfRW1rVKu+HtWkQxrWAu7EFz5ux6jVEijIxHo76N+GHhdBHOlVHkW/pn1e0VVBrBBFQR1l2rr9xrYKNOuBvQDN3ZZHtzM/BTsXLuvg3BmnFQh3n439bT2AvpMu7bkGt/6/1Qw1+jQynHVEqV3a40t7fzHRmkn0EiMEGXJHdr4V/JN8r0qiq4zJLSN7CFGwDiG5ERe9AE6B5fPUDjRcJ7/BqSAR1VpYIluEzYOli9s/gpyPCdLqU9onvmoKYm/jeQAS/q6uWj0fp6cGgzhmPG875Aw28jqATJNeO80yh6PoUED/xpncUUCEIXEEfOwklbb0bLc7UiJUT5WWGvQOo11dIrwaMG9wTbdbc824pT3xUzIV 9S84jhvo SyTVrEFZZODjcq1agF8ePrwjC7fZRHitV4+hTG/uHcas5vRcPDZlGFYGbmbKvSee5rklqrzWNUidtlyXcKwPb+wqLJJ6abxkXZqVzQcH2jHkPw//vD29bU4soOKuv9CIyFxZm4REAE2FczhOBte497nMrxyzAlJC+eR6IEZ9DuZQIV9Tz6Juf7wzUHXlqA3/eAOd898ZDmBVcnx/eU2K8LHJww5ELaROMoyQkoiteFy+g0SZ+EytjeRlin5+3LHSd9xqT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 17, 2024 at 04:04:20PM +0000, Pankaj Raghav (Samsung) wrote: > On Mon, Jun 17, 2024 at 01:32:42PM +0100, Matthew Wilcox wrote: > So the following can still be there from Hannes patch as we have a > stable reference: > > ractl->_workingset |= folio_test_workingset(folio); > - ractl->_nr_pages++; > + ractl->_nr_pages += folio_nr_pages(folio); > + i += folio_nr_pages(folio); > } We _can_, but we just allocated it, so we know what size it is already. I'm starting to feel that Hannes' patch should be combined with this one.