From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE450C27C79 for ; Mon, 17 Jun 2024 12:34:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C7556B018A; Mon, 17 Jun 2024 08:34:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 678216B018C; Mon, 17 Jun 2024 08:34:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53FC26B018D; Mon, 17 Jun 2024 08:34:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3670E6B018A for ; Mon, 17 Jun 2024 08:34:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D100C1A087A for ; Mon, 17 Jun 2024 12:34:09 +0000 (UTC) X-FDA: 82240323018.04.F26E2EF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 2D71310001F for ; Mon, 17 Jun 2024 12:34:07 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=U+KFuh8i; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718627640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QIdj58YSbWlowQQfpDW0/F1qubf3+B8kLfjRnCazjV0=; b=kxmwcjiwCHprEB5vZFl6PfuPErhHo8B0qg0cQgaWtDPphfdNUg+md7//Fh0VU5UJqbl2Gv 6hiBIY1hx3xDmY85Be/uCHxGUgxifY11x881W4GWr3ubx/w3bzzhinQ8Qox+363DoUVgY4 8X4aWhqmvhCz/iT4cgxkuFOQKDK+Nts= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=U+KFuh8i; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718627640; a=rsa-sha256; cv=none; b=c5LS73jjlCHlSaGHoBX042SC2fQO8B3Tv8jJCZlxaTl7GH08Flxd/LNrFqwQ/aPfOA+owr 64judkud2A4COrm9hTwp4Z91Q989v8lNFZ4XurFdPPwa5VwrUADaSc2DC3SaWLfALUEHpE t9fBrC7Nevc5t06EnDjJ25bwlq//igA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QIdj58YSbWlowQQfpDW0/F1qubf3+B8kLfjRnCazjV0=; b=U+KFuh8iTbywqqqr8zcYxkkzUA cq2/xOyvPt7oLgZDoUA8wSYNhDzfu9Dqt8a2fjxh6HEEvB5DEcn4e2dqn63CI/lBpdbmT2BML40Pf Lid8P5UOTwcjrOaPy2yeBVQBY6zWhdDUZyn4U7SNWfOY34g0hwul097oRi92D/DOgUqNVLU1Q7THl idJOFJb2Cw4bH5zZQe0fsxXADMiMMZ1DFmH5JSnbX4cfCeXsHwcuQ08bteO7HF8l+YIFrUO8Bbez0 TbMzsNUhq8Bdvf861gjNQ3AuWAQPXSad79gQB1FuhEAUyxWL9FbkZCwgiF/R3gMZMOklT0mLZYOP3 2qTN844Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJBYg-000000027Pj-0WKA; Mon, 17 Jun 2024 12:34:02 +0000 Date: Mon, 17 Jun 2024 13:34:02 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: Christoph Hellwig , david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 03/11] filemap: allocate mapping_min_order folios in the page cache Message-ID: References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-4-kernel@pankajraghav.com> <20240613084409.GA23371@lst.de> <20240617095837.bzf4xiv2jxv6j7vt@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240617095837.bzf4xiv2jxv6j7vt@quentin> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2D71310001F X-Stat-Signature: fusezdp8r9d3yt86e595b54jg9oz6kxj X-Rspam-User: X-HE-Tag: 1718627647-59830 X-HE-Meta: U2FsdGVkX18TveD4kTtqCH0M1Yfr8oRqXHdYeCY/E8sU61GMpA97uvGlSs4A+F6i1ngZ3mrQuiLaIJSArywFM9Nu0iLnNgTOoRd1CMT/tZK8BHSlSmDPQSYIrGDzaP7Gmb+RC2Ac/eHuoap5RKNeGuyD2HQBFq78WBuIeP3Er0vt6L34dH1eupsbhnNkUzR1guy5sDZZ2NeJ6NqOQVp4fRUr4LgMd5dkj07lxXUIhqrp9AJbHPeQlJJlskNEZtAoUDXC/c85RMM647vu63Lk3pZeGaDEqQq14hBqS6JwUwflMsBiI1yjLRYMDDbbpy+WRRgili+aE/W3RQ2xZJGdgjru5TD25HfEX88oZdbx9qBVjXnNftrkDI7ytv7BlIOdq/sYqh1EYCw4NDxH4a4NE7vcWWqW75TT8AHYqJ55/+EWGVlmSdPdjwLFSrARhYNqGTdzZ0rTSupc6IX3mdGNjIi8tyVCTLVVkz3p0WoJe9GC8yltZG9nZNUNZsSTU/+H+Gi4QdW46hGib3MKbM0DeXopoR+0jFqZmlPZQZMxbRm00t7rucKn0/WKgCKAcsFPwNKwDUQnPSI1PNCDfl8Qh3Wa0xPpuG24IhGj2ucCkeiNBuBtv/iMPdD8ZBY8QMMcq3Rs5OErm4gUFooKn6gNl0hTmrdsMtyXEyNhLuMc21mwJ9lgbSGSpYJ3N4MF9Uj3mXwWSIJf4+yv02B3lAz/jaMV/uzWddtDb51tut9VWVXa/1aHwfgjzviBPILzG6MA4l0skgqwO4OHaa/2+4rY6zFQkn+ICo1MUJjzDeOe/ZNBXKzpL6J0/ujIQA3GEoX6DTCep+3ai91hbnLaplhXfnQk8U04H8VNO7ttFJjOmC1+CqeHEhDvmMomGNJONNpHwp5yaKmgq1tGs0ekp4LNF81Hb67a818tSq+B5L1lhMQpKnDUrw80LPREcjyFqyBH+FZy6OqJL8hixCvsPvL tUXKzBzF R0tsB8FreBUE+vpaXLlitGYlzLqjPRHqXgZnAI3cqNS5YghIitls7guXEOuECjEylGrStTmuXLTutu2cn63PuM7x8XBNRjGthmFYMEtWKiaSGCNHNm+B8uYTpHNQgXM9wdlTVtSS3UKHjMYo1/0CRuwQzlwyEZxhyQ/4oVZ+7QoMT4e+gK0+ihJHz9xvfVzjnknXWdpAxkm8uTdCwdP2kftmM6r37SfRt1aLpWZjI1/Hmpx28zZzmwSbRmRtbBdsxRnlK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 17, 2024 at 09:58:37AM +0000, Pankaj Raghav (Samsung) wrote: > > > @@ -2471,6 +2478,8 @@ static int filemap_create_folio(struct file *file, > > > * well to keep locking rules simple. > > > */ > > > filemap_invalidate_lock_shared(mapping); > > > + /* index in PAGE units but aligned to min_order number of pages. */ > > > > in PAGE_SIZE units? Maybe also make this a complete sentence? > Yes, will do. I'd delete the comment entirely. Anyone working on this code should already know that folio indices are in units of PAGE_SIZE and must be aligned, so I'm not sure what value this comment adds.