From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C08E7C27C4F for ; Sat, 29 Jun 2024 03:22:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F4776B007B; Fri, 28 Jun 2024 23:22:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A4496B0085; Fri, 28 Jun 2024 23:22:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 244AF6B0088; Fri, 28 Jun 2024 23:22:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 058916B0085 for ; Fri, 28 Jun 2024 23:22:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 72E59140A6E for ; Sat, 29 Jun 2024 03:22:05 +0000 (UTC) X-FDA: 82282477410.21.5DD06DC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id B209040006 for ; Sat, 29 Jun 2024 03:22:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=i9CMhJ9s; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719631302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZFibnoMfvDegoXut4PoFg50sWjnO8hO5O3FinA4Znsc=; b=qopPSk8Hbg5SGbbJAC06J0teFy9IGb/pbnOc5M0EWe7kEBXLz2aDpnGN5d3WfKwoQ2gZgC Gkoi8bgy53lmB97vDRExCstJX7lwVtcmreSRVTWoCmO9Ebig6QHsSqwkxy5PHGSEov8v48 D/8NbFBYddKm+LCYZ0xGmpmqfT8/D58= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719631302; a=rsa-sha256; cv=none; b=Y4jWSVRTadEtVWKHGmpykfOFpSiK57Ilg4gooNnInaFyLOTcq+MZD4pGsbs6HYi2+xpF3r vv0vDOv3O6f/8mgCkfhEF7OmL8TqfjORftSBjEHDPVGX05PHZmkwyoozZMLVpscFiQXNnm MIbUdeS6GhKnJDH2K7nttkDGHspDsro= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=i9CMhJ9s; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZFibnoMfvDegoXut4PoFg50sWjnO8hO5O3FinA4Znsc=; b=i9CMhJ9so0Ybxk9xM+0uu5C7ND sE6gwMl7M+nJezKdSQy00BQGrdXFZUw8z0By7hjYVmHt3WxUQETnjioar3Z08PP0KI9hKGfJe1Khf YQ3Yyj7iz4pn+h9DPwxGgihDjOWCoRzJwzqGne0p4SQlkZhmySC7G0y0mK1d9JxFzafSMEd0e1P2H mdiWrLOpccX11+lZQi1LXl+ZpNxEj5anGjOEpwj7wCRFURVvuYnMvtEDeBdHrWR+UkF7p+C1wKBjR 6ji8HhNYkcpTXAQGQvTmt+cCW7YIIrCIFSR0WKeMTYLBTvRbPW9H6dd4n2/L0Q3L1McjEaxsUHf+k egLYj5yQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNOf1-0000000FH2L-28Jg; Sat, 29 Jun 2024 03:21:59 +0000 Date: Sat, 29 Jun 2024 04:21:59 +0100 From: Matthew Wilcox To: Wei Yang Cc: akpm@linux-foundation.org, rppt@kernel.org, linux-mm@kvack.org, David Hildenbrand Subject: Re: [PATCH 4/4] mm/page_alloc: no need to ClearPageReserved on giving page to buddy system Message-ID: References: <20240629013322.12364-1-richard.weiyang@gmail.com> <20240629013322.12364-4-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240629013322.12364-4-richard.weiyang@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B209040006 X-Stat-Signature: 6n9fecjcinrdp95nbaufunzricnft9ih X-Rspam-User: X-HE-Tag: 1719631322-807736 X-HE-Meta: U2FsdGVkX19GtEqEVgUWAbx+PM2KOnrxGHXgRNb4QDDxkkjIFr8yaTnjgV1zePj8Pwnc2SJppEIeYUgg1wrsqvPE8X0nEzluvK+NSlc/hvl6fNANXevh30zRxpJpyoZx958EOV81OvyJPtWqZWi+Yh6+OJmUxRhCXvhNKEH7+6EbBPtFHKM3RWTT3cQOF9SBTp2mUAkD3ttkK2OJYbOV9ctI9PT7xppB/vm8ipmF0wnAVR2ugW5JbPG6PcSj6bQo9lJ+tfgeoQWfJxoIclaK+5MRHUMiBaTRBBb2VfBCVcHUJnkNzP3iDKzSIhFgyEAjr7sxlHvhC/7t8SZ92+52/JPdbAV9nw6+UA7SKQTf+yG5HvE8cjLdih0ixSkCrFJlUM11Z/8WnU6bpZw+fOjWPX/rkm+wC9osryP/H98lQapcWzCGUHV8YAZTj9DS/IqkfnVINV3JLzy/9sp56DkpvTS2kk8dpqP2m/CIGED7BqsdrvIkbPChyLLogo0WrSYsF2p3oCdfD3/21cgw3mjy4aLDJulXoWLhru7Iu1h7qsNd8sf/2iXWpB8M5Ml7pFzUpmJQaTeRMb9TdOqaF2T1/fhAqfMkfNyk5Ypbib/gJPgPaT4zfTbjLqVdMrhNkYWs+AFfDhyWXJuy/CFJsgJmHLdQz13Ncx/kV1uB+gi/Qe3LJgMZT61i7Cgh8B3vWEmGOTzvBFr6ZGOAZOArcg6gHL+DVM5SlIhlQHN1hIcgez+63yv4J70Q6yZBsixCoa46IO1sTHniSjdtvU2e4iNUrIPbwZajgIsNb2LFi7g7tBLsikasn8o7Lw/x8UyLMsrCoAggSVd0o2UBv6Tb431j02UiOMfsxz0WZwPYoQ+hMC4IL9VNGX4fzVKA9/4nZYe69DLN+84niNBV3TDAzFkf/RD9QgJuzHV1cWfJ0wWQBy+QJbcCPRKonqpBhVVZAP2GGvSyPMz8HyPipoPoK6G UuJXpu/g b0SjcZ7f2gZ6L07S41g1K00Rrux9ZFDC7HmOI9Yv1tOjABEILsZkJdh/pUtS4iFgRVXFEdInn5ashpehIFe7tc+BIYGmgWNQkbETuItw9c+VRjYW+jfSXhgsskv38rkecb5QbqwFsUFU2ooPwQxQJukd71tAFfOiAC9ygw53FovkU1Jr94tJ7LTliEgnNhpwgUuS5yOXu1V6COzIFFfEnNySaA7zyPeTSFujOpz4ddcFpWUW3W3xcS+1nMJWKne7HxQcUr53BieZFuRcnvBrhKkJM7v/w4WCh8qq9CJGaTQ3ta+MeN/j2rcy7WmI0gjaRCqxdGOXvvrOSs+xrbf6lJX+yoVUI2HzOYigXeFfS6asPrjztF5ezxh3PpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 01:33:22AM +0000, Wei Yang wrote: > +++ b/mm/page_alloc.c > @@ -1232,10 +1232,8 @@ void __meminit __free_pages_core(struct page *page, unsigned int order) > prefetchw(p); > for (loop = 0; loop < (nr_pages - 1); loop++, p++) { > prefetchw(p + 1); > - __ClearPageReserved(p); > set_page_count(p, 0); > } > - __ClearPageReserved(p); > set_page_count(p, 0); Is the prefetchw() still useful? Any remotely competent CPU should be able to figure out this loop ...