From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72193C2BD09 for ; Fri, 28 Jun 2024 22:33:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB2566B0085; Fri, 28 Jun 2024 18:33:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3B156B0089; Fri, 28 Jun 2024 18:33:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE7D96B008A; Fri, 28 Jun 2024 18:33:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9220D6B0085 for ; Fri, 28 Jun 2024 18:33:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A53FA21C1 for ; Fri, 28 Jun 2024 22:33:11 +0000 (UTC) X-FDA: 82281749382.22.BCE4BEF Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf02.hostedemail.com (Postfix) with ESMTP id 3C47C80024 for ; Fri, 28 Jun 2024 22:33:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SRBhbpXt; spf=none (imf02.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=ak@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719613980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QmOZBwoUefIRNSu8ruD7ba8B0XM++aWuabqZVa1sLIY=; b=ySf3Ol1L02Wfd3vfPqAgV2xMhdq4+GmkjUBD3nhnLjU5yRc+u3Al9JAmbbYutraUxDEBGS ZKPbQXce/b0kamXvE+jWc+wbpe0G3Gxy8i/eQDXCk97iD/gx0Tzq2qvPjfk//gptR1fJNQ KFTs9YEvkftmjsv+5zI8MnP6XVVbjFM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SRBhbpXt; spf=none (imf02.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=ak@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719613980; a=rsa-sha256; cv=none; b=SezUQV/uHVdWHv7DxI9Nl4+501ytUoPftMjBvSqKfWF/RyQHkqiLFvUYyXPI0mmDuZthfS 8SzPlyW700eIHYa5+ofSUvYRs4ftfLzFOTezviN3QsPy1PZrGi2RCGe7yAM6+ICGfU+LUQ En3SB8565JoK6c1Ubv4Yb/Kv/dB3joA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719613989; x=1751149989; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dSDpJSnmr/5Y1+i+gv+DoKJW8Sy9VI1KqiHOcb1J1HI=; b=SRBhbpXt3vjZ1dea5gWOKv36uLqQWB7zPet+PdYdpSSMMIDRWzwx4VfZ r6aaIt6SpInGM75FzN2NtlMGcvbLT6bI5u2UOwyBAWVxUEZQNYHY9KeLy BkO1waPGx619cMO5x9pb4JzLSOh3N2UgsdW0vPtZimMIa3jzl6WCwe6IP KHtyDNXC59YYhf0RBf/nsFh713K9OvZ+4/3Mu/dtMcdqqgsOv/JIq5ljK gJ52cDHjfsAg2u+RSPd0xM5l+w/fWhdJCSdRmMHM4uMIHpK2Zd+l8eYVd JTRY/ISdMWqVsAZcYWdgGL0sKlKsyD8P7g9Y80uPe39vftUDcD8f/8IZ9 w==; X-CSE-ConnectionGUID: d3wrZgvIR82cjd5mpY+2jg== X-CSE-MsgGUID: QzETYDPjSVCf/B1/anfeCQ== X-IronPort-AV: E=McAfee;i="6700,10204,11117"; a="28204289" X-IronPort-AV: E=Sophos;i="6.09,170,1716274800"; d="scan'208";a="28204289" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 15:33:07 -0700 X-CSE-ConnectionGUID: n3dHSv0eTzSgfmlQ1Bb9Wg== X-CSE-MsgGUID: rAs7JF7mTLOVUJxCpcwtSw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,170,1716274800"; d="scan'208";a="82419419" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 15:33:06 -0700 Date: Fri, 28 Jun 2024 15:33:05 -0700 From: Andi Kleen To: Andrii Nakryiko Cc: Andrii Nakryiko , linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, liam.howlett@oracle.com, surenb@google.com, rppt@kernel.org, adobriyan@gmail.com Subject: Re: [PATCH v6 3/6] fs/procfs: add build ID fetching to PROCMAP_QUERY API Message-ID: References: <20240627170900.1672542-1-andrii@kernel.org> <20240627170900.1672542-4-andrii@kernel.org> <878qyqyorq.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3C47C80024 X-Stat-Signature: sf8b7hy4s9ccd8w67x8jhudrosc466qz X-HE-Tag: 1719613988-170744 X-HE-Meta: U2FsdGVkX19eSeF4s0bV99K/5kL8kXl0Ccq7ILjHlLmKQBP+Cb/hqzoadHh7CFrZvv6+0DAqphgbe9zfBhnUpr6a/1MqH4Qr14XjhG8r5zLGYHP1DrheMMgzoEdtDF8unO9ewH6qi8NuRN/UmylzH4wji9tsbMYWCyZmKxD1fcyN0WdoXwRsJyPwGaPJwUMraFfsa/KixqUL9anHju6uGpliQv+mXUCZp6AiWaOHx8Lf52KzhRtbU2Yy8JdZmWEJcmzycbCsz0dfTO2y1Ft+Y3nstw3nYAu/fMg4auvHoSXmiKBtrQORoMV6s6mhaPV7x5m/KwyV63xV2Ska7k9frpgpT+/SrnreAFmUUazF0zJre7xOiuUZbFWa9vCttd2P6LPRkteUpBxUoKdD3DcAGMLH8GV94JruQSc7qwWz0i3UK447A0jZiWPss9d6WBjMo2D560WWe77vuuoyVFWqAGuAZG4LRGydnECRGpOr5bc2cAOU6kIhXG/J85RTqUVlmF5+7FCqK/LHU5/TaAR9mbHgsm0Xeh00jn23QOZ2PTTnHMwyG3OrpBf/MYd7PSYW9Vvf1zHHA4aFZ8kr7Sp25RdkJi2h7yeFGqvPhnUdc/R1dgTW9tmAhirzli3g1s41dJvjaqVjdbO15P+9hRHRow1ccS98kRU+08Rb5Ji2A5X/u3dmXloF9spkvkF8MTDnJUfh8pe66ri0IbzwnRfZcwAN8Pf182F2LTSHQwIozQxWRmo06Qwr0y0k6uM0AafHAdh6BR5kj/SUmiZSkKF8N878k0kQqwum6D+8d/b7SrHLc+cNR0Fh/JaBR7awgjvnmuNRttAUVUZkNvQvgiUOxUJbvdaW5ff9Io+rgBt8/Xullaplj8J8Zx07WemklZEWwKr9ICg7swoT5CHsyqP2ITlbOj3zle8yggmCHerFCDn/h//G8DGmCFSW30cpamWVStSE2OieunDslZv0145 SSYC+2M/ 5jN4u5nuwCubwrlFEdZGTSupPUdvtcT8VAdz/vi0a0ko8tmg3lZJzDHviPbvYPTCN0CBwwaKozC9qAhfKecbBKA7F1fko7l+dxQRzEiD7dPRa8YKvepX7yLGBMByzBI5i/6JzN2Av/NFgkCuuwCMFuwZFETvpcZhmt0ZehYa7azvGcGu1LeNIX2eseo4CJ4MeeZkZ6aZOxmiD6HdE43ewCGh4w85f/okVAfx2iuPU5h46lKlOpo+AlyMbWjCCicNyQ7va+8Nuq5ufYWvQ71tBjxKGgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Yep, makes sense. I'm currently reworking this whole lib/buildid.c > implementation to remove all the restrictions on data being in the > first page only, and making it work in a faultable context more > reliably. I can audit the code for TOCTOU issues and incorporate your > feedback. I'll probably post the patch set next week, will cc you as > well. Please also add checks that the mapping is executable, to close the obscure "can check the first 4 bytes of every mapped file is ELF\0" hole. But it will still need the hardening because mappings from ld.so are not EBUSY for writes. -Andi