From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5230C2BBCA for ; Fri, 28 Jun 2024 06:11:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 793EA6B009B; Fri, 28 Jun 2024 02:11:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 742B96B009C; Fri, 28 Jun 2024 02:11:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60A966B009D; Fri, 28 Jun 2024 02:11:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 426566B009B for ; Fri, 28 Jun 2024 02:11:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 808CB161655 for ; Fri, 28 Jun 2024 06:11:24 +0000 (UTC) X-FDA: 82279275288.23.44B066E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id BC17B40015 for ; Fri, 28 Jun 2024 06:11:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=b3ZIr8qt; spf=none (imf07.hostedemail.com: domain of BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719555066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rKTNBJBJKDz518tdZXOqKQN7DnihTTlAfqvYX8RQNoA=; b=rLWrt0Dj3N1yVMRZn3iyfROIROHeo29QASoKrirgbdpY+8lCGfIswayLtkyzM/jn5W2X0g Sq78SrXUdMM5fGxyJejRlNJs5z5kiVktLHyu73S1sL42E4Ir6ew4BGs+WdQJsN5u7/TF27 OFWm53N6IhVUNvRF0nB/99zn3aQRVZ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719555066; a=rsa-sha256; cv=none; b=UMM+o0zFiwuyTKNj4ORfIYbCxBWUANk70ZRSStpqCAU7SEQWZ6JlDEc89XSoOMkiGHd/YQ Gwrw2HTse+9PxcMTGa5hu8V5N1ulI01ZD72rcvdYrXZqzct3+xTUs7GXivEGwTamgGsmY8 zkR1zfKkjkJ9OJ/78RBEeBtVKk0wFy4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=b3ZIr8qt; spf=none (imf07.hostedemail.com: domain of BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rKTNBJBJKDz518tdZXOqKQN7DnihTTlAfqvYX8RQNoA=; b=b3ZIr8qtndMhPGRTQuFkOe5mym oyGQt5Dl2XtwkJmnvecBhJupUImbVwDK4/hlAknxekMORhPEoi6lvCWXlHB3Ap4o1iGtDF6jnY3tC F4YyCOV4cB2K7OotMrabvvC78ZMPTxhSGa2QX6wgpVn/JepeswgQJvzeuhjj0mNpYqNCIW+6OguFc akJ3BkVIbwGAWdpBhV18N56xK+xnTv8SUptGD3kHuOK511FKJdtaWUrOlVMfcJH7ttSIEaEPnVrA6 1Au3X1zqYh7qGd5Kn3BmhcG3ki8ZAaIRI8FJgfyazKySOov1oAkbkEwxFmz9vpOC/ZYIxCpeaWukU yXxKxjpA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN4pI-0000000CiPr-1wX3; Fri, 28 Jun 2024 06:11:16 +0000 Date: Thu, 27 Jun 2024 23:11:16 -0700 From: Christoph Hellwig To: yangge1116@126.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, peterx@redhat.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn Subject: Re: [PATCH] mm/gup: Use try_grab_page() instead of try_grab_folio() in gup slow path Message-ID: References: <1719478388-31917-1-git-send-email-yangge1116@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1719478388-31917-1-git-send-email-yangge1116@126.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: BC17B40015 X-Stat-Signature: kzgp4y1gzifpzti7rkn1bt7go8ihsnfp X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719555081-854083 X-HE-Meta: U2FsdGVkX18WRngeMcdy8f8/vRJidzym0C4CZuENO91f5D0gafzMcTbwPf/E6YIeF6f9rtDu0iUaJrTiwFCJZSEd/eQAkO72Dq4GZW3OFjLntoiDGYdH89HDxEvLoQQJjWv9jAhYX63Ga1sG8hZT8JCMoj/cWXeyz6pJ7mrhitUQ3Vzw9oVOK6sJ498laFeCGgPVg/Q/quMynTrBQq7HEBWDBbFvv8iukhQlWm7zQYu8eXYBkb4BOUGJlrRPFPriUlfoUaqU82JrOL/16IyPCu73mHPxbFR4TMY9bzdUdfUBvlALlvdh45Y2/XN53m1FDbOOp0GXnuId7JShlvgOxTBoGRWXY3vQbgf1JhqwgSLY7wYXEmFPEhnnTs1UtMDGZMMefTDlhW4ZrR/DZ3SSLVt6K8Yxv0TzsXdjv5KoIvUro6zVj52iOdeIDljc9c0chq0rPFTXY+81bbvdfMrn2WiqsV4n9EA2L0jmGznQCjgTfXy1WizyHsDj/uGsIneHm+8y0liADbR1GFeY5tZVjUtL1mrmaQDia0Y+BT1SJCEd9GLfinu6CWAHVFHUQhiAi7w7rpPw0ZapOzOvsRwXXzNI9wIuKAGVCCPVy2wAwbs0OWNLpazSY38VH3Qqb4t13NOea+N9E0izygqUGsLO2kVOCVnJB/7uzb6wL4g4Y6WOGzwBAWb1MU0Ln7JUdlrj9HfaVOMEQ954zi5g7dA2UWBCWi9GAVorZ0bdkR9UWZwlea0X9MZAFNDeEYcI7yBIbwZriik1z5CLjQ3uqac0ha7uuV5XikvP1r256XGQ8TZmIJfw5e4bGvjnS3RO5B7eWoLaN7dwbMvfmWQ+PIeLqfDm2kL32OKqIiLQjZRZNkM/azj4dsuyor5dhpB4bFbAxrwrYBpfJmwRmESFGxJChvbOUsHnvTMvci5NZiCK0M1DqlUvqG6ExJkqUNd3WBtPgInKgdKyLGaCr2/j3j6 7iHpe/sn DP96+qjpVtWAa0CfJnW+v0+6dzSLc1IJk1ftyxdv0Rz9gXFpYtQofGw9uLvz3uFlO43KgRa+AE/u0AfQ0Utv1J1+8Rf5toFlQfDhrH7nUD+VIpS0y8dCixul0rPMGidhRuGMu5RL1HoRn40mXYP7gOdpkwptScyiL46JOw96Zj6vW0ObivtVnfqVjkdj1T4dWDZHF81QXcE4coDaRAKmQEGUD2Ns0J8HYrTlsuOcMO9zLDziOxka8hv3zxbxXQW7pPWYItlkN/bxpOjdGmPoU2m7K82svD6SBT5qxvLPa2L2H8zVr8H85wQAh7yeFoANjjlCY4PloEsZB/mltx65UYilV6j1e4pSidFyjznT6ua3ooA2KJL6WVtEB/7kac/6VL4VX+amJ5L5eFepxbnRuPigdXTN22rSPGCwS3+I4ekuUQrqlMDxBulMVLRYqg/pdoQqO5gVCU7OgH4nZkRG7eJ4nvlhPADVgj42y+te6Ici8tQKMsrKrjedxh8uPZ2fkk1AfMyN3LoBho09d/yJyhRaCaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I was complaining that switching from a folio to a page interface is a retro-step. But try_grab_page and try_grab_folio actually both take a strut page argument and do similar but different things. Yikes! > -int __must_check try_grab_page(struct page *page, unsigned int flags) > +int __must_check try_grab_page(struct page *page, int refs, unsigned int flags) This would now make it a try_grab_pages. Also please try to avoid the overly lone lines here and in the external declaration.