From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A99C2BD09 for ; Thu, 27 Jun 2024 21:47:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4224F6B008A; Thu, 27 Jun 2024 17:47:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D1006B008C; Thu, 27 Jun 2024 17:47:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BF696B0092; Thu, 27 Jun 2024 17:47:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 125536B008A for ; Thu, 27 Jun 2024 17:47:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B5343A4136 for ; Thu, 27 Jun 2024 21:47:58 +0000 (UTC) X-FDA: 82278006636.16.1485A1C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 7785480025 for ; Thu, 27 Jun 2024 21:47:56 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uWA9M1v4; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719524857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zapy7S8WwWK6NPvn1vDjIz6RL8CxEPi5KJd6spZHc5g=; b=2zSnjLhRf5H/fRbdZ5nTZkz/O2OrKXUfoX/5jd3Bw43i8BtrCik3UDdOO3WelRqvggi3Cb PwT5j3CQgEuWWLC+YAQMIUWrJVJQ2lgaamc+P2M40glFf1XM9WN/R1j5m0tDOBrCB5Mk+s koYODMYeQsG8CarBk5teA6AAzrgnY8Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719524857; a=rsa-sha256; cv=none; b=TNPC1D0/Sbl2SwV598oiTbUiIWTbIzOF7fqlASeoiKDLJKbdmU0CGbAoF1HL0HoxkN58uk TOhtFB3e8I3WdRvsRu+4vQOLQ0aqBTroHsaFkRx2C6A2F1Yr8Tqv1THZNhSs90MAw4mCWm Sv1y2LSjbiKieLlfaihbqBXxgXymaDE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uWA9M1v4; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zapy7S8WwWK6NPvn1vDjIz6RL8CxEPi5KJd6spZHc5g=; b=uWA9M1v4YvQeaqND4hpfL7i1SZ NQjZHl9R+7oafpJ33Ks49Fs7UskCOhK7bYN9pEZ3f0alQqcYWFSzAYRGePVNZqWKX1JmfEs4dBN1k vJ3ADYqcYpVCCDlDMesDmEc0fH8tL++jbT0gh7h+e7MLHWdrrWpWcql86wjBG+QDng7uWNoomUJ45 fcpJeGkhdRbmflp7pA1eQcB1YfVm9fRUqE4ML2FfaD8gLhgoeBrokdc0jlZzD0G2wzo9WyRluou0X qRcw2PeCJAlZ1MpD0vB62In+xVKEx7cQWfjJkJeGzX+4uyqXCQ4GH6UkgclqKvh8mPuttJSsLJyC6 1eXX9cWw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMwy5-0000000DygY-1c52; Thu, 27 Jun 2024 21:47:49 +0000 Date: Thu, 27 Jun 2024 22:47:49 +0100 From: Matthew Wilcox To: Tvrtko Ursulin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Tvrtko Ursulin , Huang Ying , Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode Message-ID: References: <20240625132605.38428-1-tursulin@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625132605.38428-1-tursulin@igalia.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7785480025 X-Stat-Signature: bzxanxskdpo6jhop1qokzaa9ibbkb8c9 X-Rspam-User: X-HE-Tag: 1719524876-138074 X-HE-Meta: U2FsdGVkX19igOyEcBAGM7PgPhT9BgM0JyIWYDH/+wgrIkuWCB9YDUN8Qhwnc7EpzLE0kyu719wEEqBlMkIYpz/9j/r8gX80dxla1FsBCdQadOM040CZp12yNJXag1iMR4U3DXIXNTH2tY4JWJR/Xk/TlvGcI7+oHsJvKL3wpbPFd4UIYe3onn/Jm+6bpt2/FG/FkiWoo/30szkah3Z9JBIlMVMi9pepUVYd5wkh69cJBhby0194UBdpi5SC3H6vJk6LzZeGaqUKK1SIv2UiJAxNVkfggzeyykHUfly5Cj8cRA3YESZTC68eqmuearfoefrEs/vczHwG/FrX6uBBhdkcTCbVVJChF9sjO/yA+x1YlWr+sS7p2t7M7zNLM+LBx4GdG1vTt3CTtiwauCgygh/3OpEGKKc44xOY+xtLZaBN/BCcy9ANB+yt5CVTMqvOZrloOIjR6Q6ClwM+WQzK9wxyIcQDTrA7oGORAQzSg+DRcKHlpUPMbRGfRKLKConN9xmqJaJxu3YFcR7S0vx1P924ooGe7MOKw/Uk5Ht6U32JPh8x+CktfS+CMGbt5qmIr0yhtao0BRf7X+P3bJ4987Cv7n2pzB+jebRMB923UbeaKdeIQi8NVPmEE4Zm8ASJm4O9fq7nSTr4BtvrlD8Plo+l4EObCjA8Cth63u59Qs4dqZR+6lsCt2x/09o2pEYBsqypxH8Kfz476YeNJU+hARkXwm8274DNC+FYBLcziRm3z1gBG8yxY4OFcqz05c7x1zG+oZdeZQAao8Acp9LcqJqqWebsvPQY0RMUkb7K2QJMpvweHOEzRpeON4kwI/0DiXY3FeBUsHJa/bpv8pge+NDUBGgEXm/l0d34JRDTfMLN5LYm2bXnUNoDqnyfQ8iWehWHiuLlCqGs54a/R8rwIdyh/fkv8JE1Ee15HcT+p/6C9zvgxttlZFfdJowQK5jFnyK5bzyTkNigS35prJw qVfoE8Wm CIqJLTVxe5RL60PsDLbVyk2lh6suWJ3StuSdumY7ckSqzby1fw8RchrYaiVlL8BA3hkegpnWKYa/xhJ2l+AicPUo4AfiUFyrTdivfv7KEvoraM6s8geMgmP7YD0I9wGyT+KNhymUaq5ztNBkzLy6nOC8OewzqzIqEoKBbT+W5p/To8V6dWEnClDMVpIMZ+wuKK8N4FAGFfslDAIq2JSElIRP8ABogxDJ2Te5kjG1KfmX5Z2sbja7EPkWB88um8TQxrQ6v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 02:26:05PM +0100, Tvrtko Ursulin wrote: > /* > - * Currently, the only defined flags are mutually exclusive > + * The below two flags are mutually exclusive: > */ > if (flags & MPOL_F_STATIC_NODES) > p += snprintf(p, buffer + maxlen - p, "static"); > else if (flags & MPOL_F_RELATIVE_NODES) > p += snprintf(p, buffer + maxlen - p, "relative"); > + > + if (flags & MPOL_F_NUMA_BALANCING) > + p += snprintf(p, buffer + maxlen - p, "balancing"); > } So if MPOL_F_STATIC_NODES and MPOL_F_NUMA_BALANCING are set, then we get a string "staticbalancing"? Is that intended? Or are these three all mutually exclusive and that should have been as "else if"?