From: Matthew Wilcox <willy@infradead.org>
To: Tvrtko Ursulin <tursulin@igalia.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com, Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
Huang Ying <ying.huang@intel.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@surriel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode
Date: Thu, 27 Jun 2024 22:47:49 +0100 [thread overview]
Message-ID: <Zn3eBbJ377VeZGcc@casper.infradead.org> (raw)
In-Reply-To: <20240625132605.38428-1-tursulin@igalia.com>
On Tue, Jun 25, 2024 at 02:26:05PM +0100, Tvrtko Ursulin wrote:
> /*
> - * Currently, the only defined flags are mutually exclusive
> + * The below two flags are mutually exclusive:
> */
> if (flags & MPOL_F_STATIC_NODES)
> p += snprintf(p, buffer + maxlen - p, "static");
> else if (flags & MPOL_F_RELATIVE_NODES)
> p += snprintf(p, buffer + maxlen - p, "relative");
> +
> + if (flags & MPOL_F_NUMA_BALANCING)
> + p += snprintf(p, buffer + maxlen - p, "balancing");
> }
So if MPOL_F_STATIC_NODES and MPOL_F_NUMA_BALANCING are set, then we
get a string "staticbalancing"? Is that intended?
Or are these three all mutually exclusive and that should have been
as "else if"?
next prev parent reply other threads:[~2024-06-27 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 13:26 Tvrtko Ursulin
2024-06-26 8:48 ` Huang, Ying
2024-06-26 11:51 ` Tvrtko Ursulin
2024-06-27 3:04 ` Huang, Ying
2024-06-27 21:37 ` Andrew Morton
2024-06-28 9:03 ` Tvrtko Ursulin
2024-06-27 21:47 ` Matthew Wilcox [this message]
2024-06-28 3:12 ` Huang, Ying
2024-06-28 8:56 ` Tvrtko Ursulin
2024-06-28 9:32 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn3eBbJ377VeZGcc@casper.infradead.org \
--to=willy@infradead.org \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=tursulin@igalia.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox