From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E7DC27C4F for ; Sat, 29 Jun 2024 06:25:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D4906B0088; Sat, 29 Jun 2024 02:25:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65D7E6B0089; Sat, 29 Jun 2024 02:25:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FF0C6B008A; Sat, 29 Jun 2024 02:25:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 324416B0088 for ; Sat, 29 Jun 2024 02:25:46 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AC8CC160BF7 for ; Sat, 29 Jun 2024 06:25:45 +0000 (UTC) X-FDA: 82282940250.09.E2928ED Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 878C61C0008 for ; Sat, 29 Jun 2024 06:25:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=cbPxcAT3; spf=none (imf21.hostedemail.com: domain of BATV+ad4e5e2bca3ce0efa708+7615+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ad4e5e2bca3ce0efa708+7615+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719642329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jF9YptaNEcUba9vHIIDGNCL4tXi5jsBItIWsaKNJPwg=; b=OpfqKHYPOPTOqBSTNcBbgxuCHx3uq8Sk3BwkTVtWeSFWHDM8kz9GyYO2GQN81ijMUDawYX 0Zf886Z/q2FDJ1Ew1pvNCr3sNO8dBYZ7GwGnzj4ET6ePwZqATlRqOaNnToDeSZ2xtqVd3p 6krcI4Bqu0VZhN18AK31QOmHF5LMs64= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=cbPxcAT3; spf=none (imf21.hostedemail.com: domain of BATV+ad4e5e2bca3ce0efa708+7615+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ad4e5e2bca3ce0efa708+7615+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719642329; a=rsa-sha256; cv=none; b=p1SBxDcacrBobmidVxRfFgg2qTHo2m4kryuKMZq5fyY2v329iQQ4ilRAAh8PHo+qQLkcMz tC1BGrGhOI/JoNpCbV/s5SctfKOS6+d84OTxtHHvvI/ig0aRATV42N/ccR60KY02njTk6i MvwL0KvvaPxCTzrABbPIxqJfV/7hGNc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jF9YptaNEcUba9vHIIDGNCL4tXi5jsBItIWsaKNJPwg=; b=cbPxcAT3Gh3u2Oz3d7cmQVA67k 347sgcuute+AWlp4+E7nY+LkVucOZZalnmncbVo28Ij1pWEBh87fgItCyKJUbmUKDuFXSmSGxjnag JtrpNd5T6b57FdFYWoeycdTF+hQwU20E6FjE9hu1qIQUzTktVbPkhd+vQIP7Akg431skZZhkHev1j 23nQWUdYuEKMBFWH6FeezVP08ObPx8gl4GxgxAITn6pkvvkGd4lN49Dxiw0mavc1MOagQjwlyb87+ hLmTLtV25YjxKuD5ihXB8J92uBMslXNFAV9dEk9XqoZIdYZXmlNrhV6spFSu0xi2CfZ9QHQtmWUjL Z8VBY0Jw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNRWg-0000000G0B4-2Z6g; Sat, 29 Jun 2024 06:25:34 +0000 Date: Fri, 28 Jun 2024 23:25:34 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: p.raghav@samsung.com, hare@suse.de, kbusch@kernel.org, david@fromorbit.com, neilb@suse.de, gost.dev@samsung.com, linux-block@vger.kernel.org, linux-mm@kvack.org, patches@lists.linux.dev Subject: Re: [RFC] bdev: use bdev_io_min() for statx DIO min IO Message-ID: References: <20240628212350.3577766-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628212350.3577766-1-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: ima4yj9u16hs49kqw7t8s5tkrqenc94c X-Rspam-User: X-Rspamd-Queue-Id: 878C61C0008 X-Rspamd-Server: rspam02 X-HE-Tag: 1719642342-138815 X-HE-Meta: U2FsdGVkX18U4OaouvOh7zHtEPT0yPI+Qyj1Eee4e9NAvvnx5JKSPsTA6sWgDuXiK5dSg4SWqz6L9g111hcmu6URxKznDPGPwN/VtUvRbIlNiYXbEU/H464wk4OxghX8p3j0EcWPTUPKOGGgwPAdqzDy6tg3SDurNt4mnDOH69MsYCgR+nEEHK43nX3fr8mrTvNCbQLd3KdMtFnpGMjtJtGwkx7n9nk9aLf2ocoO+JIJHLo6/E/oOjvWMJHtWuB7KDujDrAxM2yu8jHymMO8Wj4oHh43e72wipK54+vuM/3mODvpZBALP1MUV3Zr+o90HBIWpeuEeBVKv87zbnrFBS8t3RD9LethIC/fmPLXbHegpLr4iEsROHBIxzyqpKmXmPebEPOTYqn0G5pCYFPF2kZbFRI/Lz49X3LTyhzqQBQzy7OXAlpkPLl+8qdspw8K8ilVRDkWxOkZmdCwn6q8nVNLXDXie5VS9YDYVU0qvjkbmKXmis3pvtFEqUh2YNDLGCcbWIgqQKKT9UOU1nUK2m9q6e/6V31K2cv2ygIOAga5ouM/MpGI7PLduqxxn9a3MYl355l8V7nA0Feea7ck36rqgGkqVv5EhWOPMms8j9qC8019vTGzkmZSy3lyllFAhUmL/4nDapyZx70zgHV93Nw0cIcaWfITWQOEfrMvp6v9J7utBIMzp0X25/mkbiBVRPgOFzp9Ct9IIeL2cpGuyAQv2JEOKUa7j6NrhfLoQDlz839j7+SoQDPY0Q62+Zw1YJiusPtI13I0MxoY//hFB/g1ZB+tQX1XAP+a7Pv22IgWcEO4c4j+az8ATRh39dRRvQ6IOeipfCuXnwFr75IM84afPpp1xunuCsZhL/71uPLxwnSzm4zPaCGtRw2dMYUHxw1UqSQxHzpeNJ5mrVl3/zmejzarvVukrlDyf6S10LCrP/o8hmKlflbJNetX3NN1JICYDl3x6agbT2fRSwr 5QlVT78J EoXKsKNmJEtTgWyDoS3QKJRSsePxgltNhWOwZkOLWKKUyd/rBO6mdTDxvs7MUOjv3iEDpPbS3hvxespojgzQQDu3QZJxKvFMOOEYZMLT7quep0vzZuxuY4s9P9WNRrTQMeo8t5SwaHUDpu0OyVK44aCvzPdsC5sfR/qCa5YYOslWZ5MQV7TqiM4DZjVIpvovsFzzWz1Iq2QtQIsZzi7++C5MsndCe/dS5GKCce/F3EDRiBhWP/4pR2A8fxMlwwh9UOnqovKo1zpws9NUE6a211fzaxkzT6hzcdjpzDOGsLkksX0lYd9ADi5ahbC7IjBj9oNoQav5pTb7S7OzFp2fDKr63Vd+rbTYp2OHiYFQDJraD4GFTEokhtOImOoCa7lCC8MYE3tljBzyuQYNmsUj8EG9Y9Dq9DKVR6INfbq2lzSEaYs4dLMgSUW32a7zZMfyY0oKc7gzo3oXGLyggakfyRijr19hCpSxF+1eWeTAOq2tFdJ81Y+19Oe++s68/u1kmpUM6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 28, 2024 at 02:23:50PM -0700, Luis Chamberlain wrote: > We currently rely on the block device logical block size for the > offset alignment. While this *works* it doesn't work with performance > in mind. That's exactly what the minimum_io_size attribute is for. > > This would for example enhance performance for DIO on 4k IU drives which > have for example an LBA format of 512 bytes for both HDDs and NVMe. > Another use case is to ensure that DIO will be used with 16k IOs on > existing market 16k IU drives with an LBA format of 4k or 512 bytes. The minimum_io_size clearly is the minimum I/O size, not the minimal nice to have one. Changing this will break existing setups.