From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087EAC27C6E for ; Fri, 14 Jun 2024 13:43:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06E096B00B7; Fri, 14 Jun 2024 09:43:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A1526B00BA; Fri, 14 Jun 2024 09:43:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4C546B0166; Fri, 14 Jun 2024 09:43:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5DBFE6B00FD for ; Fri, 14 Jun 2024 09:42:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BC1901403C0 for ; Fri, 14 Jun 2024 13:42:29 +0000 (UTC) X-FDA: 82229608818.10.42B6936 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 8023FA0012 for ; Fri, 14 Jun 2024 13:42:26 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aJOro4ox; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718372545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FOEDNVsvnyrjERCR6kvUw9fLHGQTorC8TxMyHmBMNMk=; b=lyCOCppFJHJma3oNbt37A9AD4tOzLNP2wzV+s2LafAxT3HIPoEmpkW2+mVdSIV5Gyfc2hj 3qI+aPbwEYrdCRbvok4sqGbJk1doA1vaTwo4LjCviugmPNfktNo/9WNj3gST5ydYmW2miA HNgWcjF0aFmFmbGoAqPbXP6rEPBH/Nk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718372545; a=rsa-sha256; cv=none; b=yAHnIw14gLFdzXgR0NwP8GEVXKLeJ+P3TTIqlfhSuUmwG3dX42xnWcbHNJOEj8CaO1VTAk wHJcWXMTmh/VMzRrxV+eDzn/cs3sTkoeXxCaQxxS90XNpIR5LrOMQw79oJ/sAUi70QNyom AyMnv41GFmVY+7+msLeJBtc5c40Ahuc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aJOro4ox; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FOEDNVsvnyrjERCR6kvUw9fLHGQTorC8TxMyHmBMNMk=; b=aJOro4oxeGoIKSfgHm+gSn3UCP 20XioKN1lO12GHRSUaf8O4SgNjuxK8vKU3J7edTOFIOAGiiqeynHV7nR6/to4xfky6NkWvyg3Iib6 UI3+s/eBycdgp4QWJ+/bTOs7VMRTZCkMlNjGpZa8tATcw+XNUG4Cgv6mMyCMTMuHB3i3cOFTVTHQ1 NXAcyLZocOMZTZK2/oSZyf7QIG00hJGdKdcFN8xAj2ALBLjP2HI//I+GnXWdkIETlcj4m9l+q5TIs 4wmuazHJ10FMgDRIhx+5qQobgMpw5Zrqn4GLuJaiZJdLsLErDOJRBA97tb60yoodwetWPCwTmOBC8 grvqdFBQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI7C9-0000000H0o7-0Gwf; Fri, 14 Jun 2024 13:42:21 +0000 Date: Fri, 14 Jun 2024 14:42:20 +0100 From: Matthew Wilcox To: Hillf Danton Cc: linux-mm@kvack.org, Hugh Dickins , Johannes Weiner , Jan Kara , Andrew Morton , linux-kernel@vger.kernel.org, syzbot+d79afb004be235636ee8@syzkaller.appspotmail.com Subject: Re: [RFC PATCH] mm: truncate: flush lru cache for evicted inode Message-ID: References: <20240614131856.754-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240614131856.754-1-hdanton@sina.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8023FA0012 X-Stat-Signature: jkspwkccrw5k7ydr8hdukibj51j1aefu X-HE-Tag: 1718372546-784864 X-HE-Meta: U2FsdGVkX1/RPeEy0/0vIlfXBFsXXlkt/NRCKRoYMHZr05+o/FTa2l9vOyxe4xyPV1JkwlL3/GUDQ3ch1SXZO3x/dTkm/SDjNHH0x6I35SNnn4bZzr4d/OJ9sIurCPKVtIJNBmpoZncJurh277nps+LvH4BX5Lj2JMEVwsrLP3yMAhmTIdZP5lydVYnO6dPPkiSDdchvmnms8IC9kvaMjquYIoi4uktbQD2J0xSQp5L5MdKiaZH8dCNJtruvQ0hJRQwfLw2zRlPBq+vU5OmqXotyhHVkLHgvPZwMtRZ4eeFY8yeRg14WfdebPGuLz6uATFm5PONUTCIaVWnrwf2IDTrXsZQ4pe873ina2y126RTu1IeaokN9yRQOIxs58i8Say2wtdwTMJD7+lsXyXFmN+dL46xfm4D1l9v/Q+slvuHiQf9cfiymSmmxJImcPX2w+O7XPVD8hPVdLKIJxI3ThFTuO2I3kVVFe5LDzm0f+kkjaXGFnnAfJh+WCuUq/zDzopsrygE+u0/7GU2G7sF/JvBMdlJN4T+oeQ6yVNuK5/hknxARzM7hz5FUECtjdt8LwDo7nxEaDee4yg4XbZPRu2gLp6BH80Zu8WtyYWCpr8MKVUoENZIVWm6XLGsKZRYDgZKz2iCx8fTyoIzczbDuWrRWfwdnF0pB3EVRxy7G5lZ93CxIol7XMTqqr98d91f2MVd2QZpe6CWDiKKghay6Cr6j3c7JfBK8eIZ5HWQCq73/Y5ZCNYmT2AMhrs2DArUwO+2LRjmSsIS+12Jkasbpj2CkmOmJwU77AGyDwb6sEUn/zTiTC5cdK7A791+aMB8AkOvMtPLzKPG6LwFhXYuk+C0C4L3ikP+I5rChEgDD9WMthTZlLYxQ5I9RbJTdquJlo9rYOnqQnq6HwzLG2QuBMAuCYf9bjKGkXCX3U5GLcM/Zbk6iR09M6qdbmijnwT2YgLQp5aeyVcoFe1hjs6l 7HzGX2nm Zf5//E8Zh2qqR/+3p2pr+DsuN66YIhY/vnTzMZ3FRE/59mQyx8f+IN8j0rKkLlF7SyfrtvVBVoDUKHd9EjCOrleAKKdiDYio6FnvrlceDPcqPVBSCT96BZI6y+f8ACFKlnKsmJTO5qEpVsx/mj71pmnO9fjPx2aQHdeGmx8mTuMpFBrRCIcoAP2X5GqogIWAXOlWbiilow0Fr1fO73A1cwxcidTGTtarwROBdNYGPQa7P11wRUiLH7sRSVlX0f5tRoj9LHOuwAvGIpc926I+3W/KmF84l7tUXXYZL6oTid/RPldV0VSewLlbQtkupZxQIi/MaEOONmLVJDH2mquexajqIXw2HraYJw3NI8yhsKjdBQ4T1mwIut758UlQe9VxTUe52LkAEvYbaGi3ldwj1ODqEv6+IoCOaLF9Mirbk2ljCMA0mCfUoSIQS3bRmRZk0CkHI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 09:18:56PM +0800, Hillf Danton wrote: > Flush lru cache to avoid folio->mapping uaf in case of inode teardown. What? inodes are supposed to have all their folios removed before being freed. Part of removing a folio sets the folio->mapping to NULL. Where is the report? > Reported-and-tested-by: syzbot+d79afb004be235636ee8@syzkaller.appspotmail.com > Signed-off-by: Hillf Danton > --- > Post for comments because lru_add_drain_all() is too haevy a hammer. > > --- x/mm/truncate.c > +++ y/mm/truncate.c > @@ -419,6 +419,9 @@ void truncate_inode_pages_range(struct a > truncate_folio_batch_exceptionals(mapping, &fbatch, indices); > folio_batch_release(&fbatch); > } > + > + if (mapping_exiting(mapping)) > + lru_add_drain_all(); > } > EXPORT_SYMBOL(truncate_inode_pages_range); > > --