From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B05C27C6E for ; Fri, 14 Jun 2024 07:36:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 139A96B010D; Fri, 14 Jun 2024 03:34:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0567F6B0111; Fri, 14 Jun 2024 03:34:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D05EC6B010F; Fri, 14 Jun 2024 03:34:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1A66A6B0117 for ; Fri, 14 Jun 2024 03:33:37 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 78A9EC0566 for ; Fri, 14 Jun 2024 07:33:36 +0000 (UTC) X-FDA: 82228679232.11.7C4D50B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id CA1861A0006 for ; Fri, 14 Jun 2024 07:33:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DI5xFhOd; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718350412; a=rsa-sha256; cv=none; b=ztmTJpWGpedaWpQ3aZkbJ5XAlRSbWZiUrqyQMS7abAFHkMiOofDYSJmuZrG9ECj/TynimU ns2TIZLSXlo3SkfjY9quiYOxXDB5+nUGnYBBJE6WjFF82Y9kvZxVa1uLbqMAkzjy6JUyvQ iFeBCU9GEoOsgxcQBy2VRuHbLKSTAnA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DI5xFhOd; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718350412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5zGw/kxW4Ag5E+n9C3Osx0KVYBe88VfUDToQvQxL5n4=; b=d/pJV8K7qiCP+XWlWQb+rFCS7AiRTRYcRCDPBlbU3LWjEVhoZwtccqP3a4IJPfRvxFsxDx CXqgJ+0LzebwSKDAz6qgDxy3hf7brzcZ7lEYW8OM+JEq4tg7Y2csQz2ODDbON3w+HJbKc/ LDzDO3ybdq3b9wKxZJe50xcX2T5ELgE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8DF9861E34; Fri, 14 Jun 2024 07:33:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F89CC2BD10; Fri, 14 Jun 2024 07:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718350412; bh=NnkmAXOOWVZBMmSqgujLFcgmwxn48aka8vwCP+88UZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DI5xFhOdjQNg736myA0URAZZXPnU4nkPBwlDT5j11/xqDepPKNTSeUJOZL0VzP78z Gija8ZvzsBIvSQvQZgN2CKyBYONNbneV97Xw46m0pZ6iejHSj3QVukJgOHaw6n5vEJ oPmNs7XQyKSovf9ZEFJM6K15LIm3xk4zeLcrYGHwDqPjUCQ1snvszipq3ByAXJg8iQ bH22iOboDVQpyv1c0zS0BOBES5DnTQZ8taQOTO4VL6P5MvVJabccgtOreaS1mIayMf Qki3z/jPfNl6nl++W+rT3j9EzUHaYd6pMBIRMyAoApsEr1aQyraU56QXk5+aQujBGv Eojfa4GEc9Isg== Date: Fri, 14 Jun 2024 10:31:21 +0300 From: Mike Rapoport To: Jan Beulich Cc: Linus Torvalds , Borislav Petkov , Narasimhan V , "Paul E. McKenney" , stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] memblock:fix validation of NUMA coverage Message-ID: References: <663e80fc-6785-4ac5-ae74-e5f26d938f49@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <663e80fc-6785-4ac5-ae74-e5f26d938f49@suse.com> X-Stat-Signature: gnwj1egu6ecidpm1mtgsqwgzf44ms5ja X-Rspamd-Queue-Id: CA1861A0006 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718350413-628815 X-HE-Meta: U2FsdGVkX194lwBwNQgt5JYMFJfruK/Ym13NFZc59fNtyk69b0hVUu3YmHmg9qeX6zFkzxQDwIa76baMEeR+bsBeE9MAkHaE29XHu21SfF5EjUgN78kGdCBxBtBp61KLGyZfca7wlJRRiYeECtVMHgJN5FWXPpYOJNHqZZKk8fzInGAfe6rb7BDYWD+sU8+/e7FnQV5XVOw1pUdKL0Ibd3IrK+oNyivO8piAgC6x/t3ebuFYgdzzGixRvYueCJifQPCKHA+boF4efJ6ueUFqJhaAZv7cxSnhrUTjNWkoNKv6TK8dQntDMB0AfNuBBY/V760Rebd1rY9Ago1LOnTkZvINFXVvhLp1v5h7lxjfR6KON+7ogB5D0tPlTqjkIEBln+Ks+oByKnctXAlUFNf9l3G3pdFaJlb10md/cPzt+G0x74zncGf5WvGVqFS01BwS7QQBKR6CvxmVveTEGU5NYWGOiPcZjvgxIbSY+Ppm3q2mdzuQAY8MUASXluHDedU9OF5uwSAfxj5n9wNOFxuQCDy6gToOgXZvgBBRgN3WKnQSB5ZhIf4iPxcPJBMfkBQRCI3ej0/e7CTLmQKUO8fKPNHPSNC55/OSh26p8N71rX6iXV+D02OAwieRseQ+00goQcSX+R93yi513LLhdGyy5Zdwj9HKpwTxhPCJKMmwJkOXlwQeLWY2TMK6pJXJBZL7+wwvbJoxqea8c+ihcM8DgYnkmfStNe1bF+ish7xf/CX9ToCT7YGTIdzwOB+4ZzfzqWZozRpeVE0u5iSySnHUICiA3YJSXCvr3Jy2BWdms5pr/0wDDX40XqmBJxioJQ4x9CYDgWN9YoiQqu1UJKg9quDjelw6Xj7qV6iAbBU6G/E3VQdyTWVOH4EwT0EDqijX71I4OcRmlq9BJSwdo/KdVZw00viqbYm/V27OVY8NSMIvSj64gIMflEmTa8cJpr3M7PMiw4sFMTwHA9O8VXd D8yyy4Dt nY8i5YlDEYl2BglrOw9DEYb7emJ9XJi+dUp98DMufgnbDhgI1RTHCZ8/AiXoMnX+UcZS8IykUq3ahQ2W4ok2SXbbQ8p8lWW5BGTDs4+NlYYc+b4qA8eJd+VCey4Ba1FMXrJHJc/fW/peL/HvVpDO6OyIc4gDUZkSuooIpAxljR36PbFDOkN3zoW4E3GEvYua8ESN7O/HYG2/eKx5uW4ObrxwVfR9YD1w3Y75YkD01rtA4AIA3qenpfyhIxXiig2v7M4zY5p8r1KKViOXMnbZ/FO5hJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 08:01:33AM +0200, Jan Beulich wrote: > On 13.06.2024 19:38, Linus Torvalds wrote: > > On Thu, 13 Jun 2024 at 10:09, Linus Torvalds > > wrote: > >> > >> Is there some broken scripting that people have started using (or have > >> been using for a while and was recently broken)? > > > > ... and then when I actually pull the code, I note that the problem > > where it checked _one_ bogus value has just been replaced with > > checking _another_ bogus value. > > > > Christ. > > > > What if people use a node ID that is simply outside the range > > entirely, instead of one of those special node IDs? > > > > And now for memblock_set_node() you should apparently use NUMA_NO_NODE > > to not get a warning, but for memblock_set_region_node() apparently > > the right random constant to use is MAX_NUMNODES. > > > > Does *any* of this make sense? No. > > > > How about instead of having two random constants - and not having any > > range checking that I see - just have *one* random constant for "I > > have no range", call that NUMA_NO_NODE, > > Just to mention it - my understanding is that this is an ongoing process > heading in this very direction. I'm not an mm person at all, so I can't > tell why the conversion wasn't done / can't be done all in one go. Nah, it's an historical mess and my oversight. > Jan -- Sincerely yours, Mike.