From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A3DC27C6E for ; Fri, 14 Jun 2024 04:57:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 253586B00FB; Fri, 14 Jun 2024 00:55:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2024E6B00FC; Fri, 14 Jun 2024 00:55:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A3186B00FD; Fri, 14 Jun 2024 00:55:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF12C6B00FB for ; Fri, 14 Jun 2024 00:55:21 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E5881C0AA0 for ; Fri, 14 Jun 2024 04:55:21 +0000 (UTC) X-FDA: 82228280442.07.155849A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id 1EFB22000A for ; Fri, 14 Jun 2024 04:55:17 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2F0cFcuJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QszfpGgo; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZnuaXjoX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KrX2++MZ; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718340916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O2Fib6epQ+O7wESFoNkMErJuX8tawNTH6TPqfoJ87DA=; b=y3KhQs/6MrPwAMc+Db+m70OiDDMhh2QETwLN9HI8rfy7gjbWciXbT/FDeOEvzaCG1fSrMH CyBXzGmeQYWomVc+JZOtfXi/GWiMn0iqX91Q5KswNT9wn6FTZmDvRUN4Wizzp4Pr+UULyF k9VKjUtYkOAQ0ZY2bqUS98qre82+hZs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718340916; a=rsa-sha256; cv=none; b=KfIW0eX63mG2Mhrjr7x5iMMZgjZceKeWiH1Z8uIbMSeIo87WB/m5SYxJDNGXkkp94gFeZh yyKkmc+cdyrv96esaFk1+38woDBA+Ug8eLPS1kpQ/UO/R63PcewOqw4fPIt9vOn5SGSHZ0 RhBWp+bw+Aysw6HdQe4u5e21y/rkYV0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2F0cFcuJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QszfpGgo; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZnuaXjoX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KrX2++MZ; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E611722897; Fri, 14 Jun 2024 04:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718340916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O2Fib6epQ+O7wESFoNkMErJuX8tawNTH6TPqfoJ87DA=; b=2F0cFcuJbtmwRRIpL3eDTQGbe3X+3sEnUIoWhM3Mo3X/eqiHJ836tkiF3NNkdn0+0/DFoM Fff//cGwTk3gJ/zSf4BxDdF9DMcF4wyjibf18EYl8bng+3eBpb01CXJKEh3v7zmV230yZD kGaZkwd7OVGOkyo5Kf6I6Hw20RrhBts= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718340916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O2Fib6epQ+O7wESFoNkMErJuX8tawNTH6TPqfoJ87DA=; b=QszfpGgo6F7vfEgctwraQJ4jhtdSGsxmVxG1Z6W6qvvy1jzrs2dSa9seyKJZQOsbSqmV+j CD36/MfN1m2rLJAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718340915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O2Fib6epQ+O7wESFoNkMErJuX8tawNTH6TPqfoJ87DA=; b=ZnuaXjoXT/vakk0Uf4Kw1B/qV3raFRHGRs90nYCroKbmwq0SzvJN0bZ2MsJOGXUEAcvP22 3NSew2QlQGPs5R1SljRmyxbESUnPYvokWiZ5Adh79zJWQY65UauK1AxjhAJuxdXyBas5f0 PZv1R7hYIuzIdGOKbIDV/p7WeeIo37o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718340915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O2Fib6epQ+O7wESFoNkMErJuX8tawNTH6TPqfoJ87DA=; b=KrX2++MZzJLZR29tbZDPQIZOkwPGsW3NZCv9nZIxDmBzT8cuGfA2ixbBwEpg7sqNnPUhXa VFDbdMWSJb+Z7iAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2B9EA13AAF; Fri, 14 Jun 2024 04:55:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kuAHCDPNa2YsLAAAD6G6ig (envelope-from ); Fri, 14 Jun 2024 04:55:15 +0000 Date: Fri, 14 Jun 2024 06:55:09 +0200 From: Oscar Salvador To: Vivek Kasireddy Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Daniel Vetter , Hugh Dickins , Peter Xu , Gerd Hoffmann , Dongwon Kim , Junxiao Chang , Jason Gunthorpe , Christoph Hellwig , Dave Airlie Subject: Re: [PATCH v15 3/9] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios Message-ID: References: <20240613214741.1029446-1-vivek.kasireddy@intel.com> <20240613214741.1029446-4-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613214741.1029446-4-vivek.kasireddy@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1EFB22000A X-Stat-Signature: moinwdnszmqi4x74gau5uhkie4yh4xhu X-Rspam-User: X-HE-Tag: 1718340917-360798 X-HE-Meta: U2FsdGVkX1+9EqlweYif+eVbOjih807wH5Djz7M2MRCOiLtvEXeBi4Map6dWw69pHTSNocKIOOr8bjpGQ2Bx7bo9V2JZY0v+YcXYHlXFPi9EtGIvfnIRxnQbFiD6zYYIkBQGvwdizuGtYDKIRm3fdNAEtkBUX6ReImB6qj8bE3V182XgCJHs2qZpAOrVUSVeu+bQrStmq5qxK4ROKoPq5xDyGftKadVanmKXiubaG+9RR4Av16a2hy9p1myXIdsWt5TWk0fsnR5LeFoBqle6rUQfG5Zg8oJm/1QaB/L9pgsF1Ak9pTH19s07+/dKoHThHjxkP3d4U5QftT4yHlLqkn1/basqaAmtjSRw59ZGbyt+0s/y38N6BUj69PGsZMRhDfgqrr6PxArXP23rDHqMRFoOCfh43AlfRD9YGC5uVI2yHc412zeK69n4KEz5DBk/PK66CwUoRba0qPhP/XhFeyRRXliXmYdS63OtNqhGtp/T2Br2kTtLUklndaJ4BzEU0bbfra8syt7pIwN0smBnOBtQWSsia1RmtU6TKPBALxm2bs55UY0M2GzeC21wCL6eueJwte8nQtM9VnjUp9w62N3hul6uQWVLttJuJYoaOfWtjVnLSusXw+xyjuexzR099XryJ24mSkx8Cee/VRKLI4Z8IrA1N0TEGEBD8xPY7nFVddoiAbiGilF15eWznhrXwNwFmHInA5GiFMqgPquXiHBoY9Cq8pfsFdrnPAed9GuvAXUMreXmuwutB1CN4ou2O39W0PB07gJHuFI2ZLFhhZbtb0K6GtfXYwqaEiv0oqTcwLmJ/dvMVu1aamMH3+YakZFJY+gYpDh6bfxpCzij+tEEU/TAo5ZMOKZiyuElsFUDJLgT9B0KqZ6u509ozA95STkoW5XThHVMLXhRVKj7uq/TZunHXDGFVXeb9GGaZwHMGB6Vt/nkXs++LspHjJ4HkT4HfAE8c5Wx3tFmoeq 8WcMO2dJ BInQ+sIt5Jdes7tdAEn2flvcQNdfkF04XZ2A21a8Q3u7N01UsLv1slnDwuq2Dsoo8DmUF3kT/sooO3TlUImdee4xPOwijmttZbuoCOBXRArxO2bndv/q2b7qUPd1nVR4YbLuCklFt7M0IMU1x/wL7ughPcoujODfddkhDjRjLRyeMOiynH2c5jbn8x2J7yECbNWFjKBbM7Mj/alOSItAHg1UUnXzCZ0FemracSks8sTIy9bXdmFW0cNtgET5rSjU3L28ZHKMg7Kbnh2eZSjzhiFWrcdjUKDE7d9FbihPDFdIjAqYy3Xhc9mJAEUgWP485AIaKCc7bS5wiRO1WbJWrGDN3hDTF5ASa4iQEch0V8wEh+83WdtawEOGWQqtvP8D4PZfr+JALSK9bcqcuzDR9AGXJsk8FY+o6e01KqeGBSszLiIZS/Vj6Jj+8qQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 02:42:05PM -0700, Vivek Kasireddy wrote: > For drivers that would like to longterm-pin the folios associated > with a memfd, the memfd_pin_folios() API provides an option to > not only pin the folios via FOLL_PIN but also to check and migrate > them if they reside in movable zone or CMA block. This API > currently works with memfds but it should work with any files > that belong to either shmemfs or hugetlbfs. Files belonging to > other filesystems are rejected for now. > > The folios need to be located first before pinning them via FOLL_PIN. > If they are found in the page cache, they can be immediately pinned. > Otherwise, they need to be allocated using the filesystem specific > APIs and then pinned. > > Cc: David Hildenbrand > Cc: Matthew Wilcox (Oracle) > Cc: Christoph Hellwig > Cc: Daniel Vetter > Cc: Hugh Dickins > Cc: Peter Xu > Cc: Gerd Hoffmann > Cc: Dongwon Kim > Cc: Junxiao Chang > Suggested-by: Jason Gunthorpe > Reviewed-by: Jason Gunthorpe (v2) > Reviewed-by: David Hildenbrand (v3) > Reviewed-by: Christoph Hellwig (v6) > Acked-by: Dave Airlie > Acked-by: Gerd Hoffmann > Signed-off-by: Vivek Kasireddy > --- ... > +struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx) > +{ > +#ifdef CONFIG_HUGETLB_PAGE > + struct folio *folio; > + int err; > + > + if (is_file_hugepages(memfd)) { > + folio = alloc_hugetlb_folio_nodemask(hstate_file(memfd), > + NUMA_NO_NODE, > + NULL, > + GFP_USER, > + false); I dislike the direct use of GFP_USER there, because it opens the door for new users to start passing their own GFP_ flags directly into hugetlb code, which is not optimal, and something I would really like to prevent. Hugetlb pages, until now, they have been mapped only to userspace and only used in there, and they can or cannot be migrated based on its size, and that is why we have 'htlb_alloc_mask'. Now, you need something special because 1) these pages might need to be accessible by some DMA driver, so you have HIGHMEM contraints and 2) cannot be migrated away. Ok, but I see this as an exception, and it should really be called out here. gfp_t = htlb_alloc_mask; /* * These pages will be accessible by a DMA driver, so we have zone memory * constraints where we can alloc from. * Also, these pages will be pinned for an undefinied amount of time, so do * not expect them to be able to be migrated away. */ gfp &= ~(__GFP_HIGHMEM | __GFP_MOVABLE) So it is clear what is going on here. -- Oscar Salvador SUSE Labs