From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EFDC27C6E for ; Fri, 14 Jun 2024 03:24:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B67D6B00F2; Thu, 13 Jun 2024 23:24:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3657E6B00F8; Thu, 13 Jun 2024 23:24:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23B6F6B00F9; Thu, 13 Jun 2024 23:24:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 244F26B00F2 for ; Thu, 13 Jun 2024 23:22:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8C5ACC0475 for ; Fri, 14 Jun 2024 03:22:24 +0000 (UTC) X-FDA: 82228046208.28.3C83735 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 3D0901A0006 for ; Fri, 14 Jun 2024 03:22:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QJ9FO89Q; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718335341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WC+OS8tP73IzC9fklby77PSdBXo2i/N8oh9tXyRadYk=; b=CMmHQQYsb3KawB9Q5+bWnS3aDXcu1djycRjX9PUKT1CsUAIUlXM8onmWDxLNB8g0LsIWhw D0m6lWcEEYrr8QctQhdXIcnqqK5odlEOuCCSwY6LP7GQmfAKyDpqvHkrPOp75K6MsluC+d FKgSplUlMYEUAHcJF1rCRFKVK6eaNDw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718335341; a=rsa-sha256; cv=none; b=iqqHmgRsyNDnRZYOr0CN0TWnNtIP7kn96G5DaphvJBZm80JlCwp/aCw5vXV9lsdPziduZN WqmhL8g9o1Ogpa8N1USuaOE0OSL9xQ0mH5eD/ZP1MH27t2mIxuRDH0KZ/0FoCWQrh3CRLi Xc3venGq+HhsnJF/zhPwDHpUcBekG8I= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QJ9FO89Q; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WC+OS8tP73IzC9fklby77PSdBXo2i/N8oh9tXyRadYk=; b=QJ9FO89QDAgII0sbVpbQTVCGAO g5Mshs6nS0CQ3O1tfNPcooP17fejBeSapIRJr8ELGdpjJyi3WAdiENCOtulbG6nwLO2YnI+ncOCOF C3bMAS7a5AwLZ1xW9+maUlu91qoac1tc2MtgrImMSfJU1cHc810foyuJSF3uqXHc0irkCY16BW9GE MD2PWCMv9V2V+aU4cPB4RSG/PYEXFnQZUmgzLivgO5Aj07Os1TRt1iz9xfeXGhmQ4wK05rZ9WfOen XF1v22kHhlhnLyQHYF5b6jQdBcgrWU2uiBw3R7LDy1yV8xxdQvnMnIukD+ANjeor7BmeBRMhPiXbU kGg2dj/Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHxVx-0000000GWuH-1daT; Fri, 14 Jun 2024 03:22:09 +0000 Date: Fri, 14 Jun 2024 04:22:09 +0100 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, hannes@cmpxchg.org, nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio Message-ID: References: <5ab860d8ee987955e917748f9d6da525d3b52690.1718326003.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ab860d8ee987955e917748f9d6da525d3b52690.1718326003.git.baolin.wang@linux.alibaba.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3D0901A0006 X-Stat-Signature: tqk3aqw3rhi1wdiph9zciyd1fc6ees3h X-Rspam-User: X-HE-Tag: 1718335342-189644 X-HE-Meta: U2FsdGVkX1/hKRe8ax4ZxaxNnp0kEMfpgHqIWv7i8NNsEMKadyXln4zgKX0dYB0vRZYegvWkisd3d79LM9LbmhXUjIrssVP7rjF3goJaZ5uSzCCsSdPBiE/4GHhp7vz7jPMaDyo/7ouDTjUM4eMX+xvJRPoqZEW+//b54ZARSulZV+5dyaN6cyhk0JrhOqhzBFasgHdsPzw/0FH7fwkQnpH+zQws0rZKwif5FEl24hKPrhTEFq5AHbMgYIckXOitGzXgcwiQwmXQtwop4zWy6wH1kw9rC5EhIfkJuWEc2XSHzbbjIZeVQAIukQl4gq+9EPOG3hvkCP0ZYT9p06EvnLsJmyAIvE6iueXdU7ehy+u3G5YjQyDbIH+4ICDk7wgPdp1NpRYtccKph9N2xdsDS1uKEYbdXcOhuBOuQfXC3JklT3dx0ck6PKCFa12Sp9M1wX3qHil+5Rt2JY3Oioun15HosxVHG+wadObEaIiF1huPIQZfhjS3bBmRF+w4N84lQNJlq3ySTxX3FJBY6U+aCP5HCK8Gzgesntigezx3iTWYN/kbivfETSogbjkxcnF429NoVzpkdMBLkdRgy2CsFMAPzLUJLkYDDGU5wuurp0JPDLvcycu0hSknu1C/4/68KVLIT735Cme4juxZ3rwFy/khHKf92Ldf/ILRTl57CgEfhGVSDvLN07rmCbkBPx5QcQdTfdyghwFz/SJ0+N3FBlNjl3KsT4ye1GXAMAhcMyaJhvU6tSAi6h9nIs243CPLNfKRosDkHogEn73oAEA0fkotczTqel834OMzjmJbCUtNU1jl+Vw4J78xTZfyWAUMJcfr55NHhwfkh1O26XTegyfpzDjCXg7L0cUt5U2xDSPrB7S+iojl1hYvVa1sIu88W1OpJ2PQk92E73FNvRrrTBKJfnPyAi07cFw35BilpEqdC98/8lZGn/STL7G/zZpkORUl0nDRLPWmWykOLLP xPuMxKwi W1VyC5mScnI6GChRL4TTu96dUpW+Qp89blyz+2xBRIPxlAzCJ5PMurV3QY41k99oC5e9ovaptp72qcCTGVFw+orhcggCQa50J8YnSsufMQjdR59LaEOAGMi9pJWn0eS9HMrkvGnb9UIBYRGyk2UDGUJYRqp9MKonqH6hgnoH0heZw/fVL3eD8iEwsM7HOUVnzuoqucQXxjUjruO8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000066, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 08:49:13AM +0800, Baolin Wang wrote: > * Charge @new as a replacement folio for @old. @old will > - * be uncharged upon free. This is only used by the page cache > - * (in replace_page_cache_folio()). > + * be uncharged upon free. This is used by the page cache > + * and shmem (in replace_page_cache_folio() and > + * shmem_replace_folio()). Please just delete this sentence. Functions do not keep track of who their callers are.