From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C84BC27C4F for ; Thu, 13 Jun 2024 21:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E70646B008C; Thu, 13 Jun 2024 17:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E20576B0092; Thu, 13 Jun 2024 17:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE8006B0093; Thu, 13 Jun 2024 17:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B33A56B008C for ; Thu, 13 Jun 2024 17:05:32 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 61159A04BC for ; Thu, 13 Jun 2024 21:05:32 +0000 (UTC) X-FDA: 82227096504.19.E3AF599 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 433E01C001F for ; Thu, 13 Jun 2024 21:05:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="LQIM/zso"; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718312730; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cCxKgbEydPpXzyxcW3sCZ69Cxc/JRcYSvSPx79sKwvM=; b=c/7rL2SZ25UmKcONSM2wD14ENHds8Xi6lhIK4vlJhd1ZLZgYb9LHGtGzlBLOQyen9RaVRd 2mLr0eL/OlvhSJfJJ+b7Zl/WoY9+7IaRhik/9Ir9JDqY/yWOQR5fLhqQBC++cvcrA/TWkg 0RluM0d8jKF4D0nMXb+kVyZLu2BF3BE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="LQIM/zso"; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718312730; a=rsa-sha256; cv=none; b=6E6BV3rgSgVu7sVTPSyR8Y+YiIDQ3Azt78y1OmSi+5jTmOrhU00Q8Y+3TG88SX9vIgStWK xOWojSrDimNrsatyCGx7TMSwSIvATgE4B/GcvFpKxqAvs/9NgWcJCMrTw0h03+uvMtuaKQ vqq20BbJ7qnrL9aaAA1HMZjkcp1eicM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cCxKgbEydPpXzyxcW3sCZ69Cxc/JRcYSvSPx79sKwvM=; b=LQIM/zsoXYsGe9XG0lG6bmjxwV lVa+IKYA5odiuQ/7Uj+g36bmh8qnQ08MfBqUBRzsC4IhdhDKanekA4d1BZ2K2+Mg0mKXxDRbJ+ukF Xqh/TWqP1vRyJlN9hPzzKtdmyS0cqSxKApEdbf6QZdJi3/0XABdX9V7Obmjga7Aiks9tApomKVLCj 5cjBNm7TDh17+HUuo3HODLohiIgSHTtVIZ1aMRTAwjjQFJDdfsQPht0Hr58wxDO0vswGPuHBIgxIQ 6i2cFpyp0Ou8vixr3thoU60R6L8T0cBMCHi2d75FxMxu4AKbyiE/AsGC3RcXicJiFtbOrrxXjDWao KxyKcwdg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHrdP-00000000UOI-0cZb; Thu, 13 Jun 2024 21:05:27 +0000 Date: Thu, 13 Jun 2024 14:05:27 -0700 From: Luis Chamberlain To: Zorro Lang Cc: patches@lists.linux.dev, fstests@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, ziy@nvidia.com, vbabka@suse.cz, seanjc@google.com, willy@infradead.org, david@redhat.com, hughd@google.com, linmiaohe@huawei.com, muchun.song@linux.dev, osalvador@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, hare@suse.de, john.g.garry@oracle.com Subject: Re: [PATCH 2/5] fstests: add mmap page boundary tests Message-ID: References: <20240611030203.1719072-1-mcgrof@kernel.org> <20240611030203.1719072-3-mcgrof@kernel.org> <20240612080634.xmh45gdblvx3lgrc@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240612080634.xmh45gdblvx3lgrc@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 433E01C001F X-Stat-Signature: hfakbeendmj9zq8a3gd6cfok1xtg6jfn X-HE-Tag: 1718312730-834749 X-HE-Meta: U2FsdGVkX19uar3SZTJmVs+mZ3P5nVEsDlEK6vVk3CRloOo4PpaeIjgKCJVG5KZz8tr2mr6IYMFfELKKbHMerKQV2ZTXH2AkL/DCSkxg6nYDSBMnJFR1vKI/M7GsjZkyILS7hNg1reE1TGykOpPHz+C/iRKzC+Bw2QJmgJ+bj1KpEDz679IKpDNrIyttnLma+Pz6+doNOLoN62x6mECv3meH+DMZoVUIPRjuiWi2VulBPxlQJHfd35ubg/nXryubiZOUYyv9AjD7geAvrd2osgjIIWHGc8nxmdL0osEjBMxksq4wd9jqjoglWg61GFUcQmvMassrA1NmiZbHqekG5u2Hg/D6cDZQNEbkb6QaffVnrVt+0fn79pHUypWvD+fIcYINsuW2cxjeR9VWnAzGPARS44s56EO3+mPQUBg1Z3dzudxwV6C8/AXdIUsGvif4dm74xH7+ZL3jhwts4WTyNMiN0wjcFYwqUxzcU2Cph4mbnfyaNao9EcEJnFk8t95jBuUYh/ZzTRYPuTHgxQmcMaK5eRfre/oUb75VLSMXBDkXdRYhJli4N3YKT4jpUTfpejij59V3dDezoiREGX/Gtxg+AHHPa6ZuscP6DWP4+GF4ojF3WAvBk0vIu6KsK7OuzF9tOyEqXD8TpFS4o9yf3ZBdYyeGDWpxkwUlWr+SNh9VOZW5pm+55a6zikOrSntaby3F+Gwql2EJVPaVb+bXnKvycHOyp0+XEeJFEvipSc49/43S0C9uGFDzo4Vm/dpANDdwRFpp/3dIEG6/fbNxCeLV4UPx54pnaUC/QPvxyGh7kdnqI5a3vn34LbQgjEy2D8UyfVdu+5TNTJOgrTIzEuccARNMeGWog0CjCZ96Ss4IWvJyeLZBvz+En5W2o1X3mBejJMNDpbfcAnV2ZpWEZqhm69kwxmzecqDC9GYZ+RZdVwoMxQERjF6e24EALlRNqOC4JV/5aXNOOkPnB1f E3BeDNMf eME+od5s5DrKs9SQyONQ6At1HSbhXcL021t5kmrSiwi3Os4qIztNLbld/3BpibZhGKzkbq9oxD4lbqL15dqMyySoaWWubjNHabc/llFCZYiJpO7hqgWFedZiJ4nun5OWffk2tlDgerA4h3CaVQuE3bjX3q7o0tbrSx8kxHbF8AwzYaDPpNmRrKd8+vGi2XPFc7xCzgSvaN5voNyqaqNSj/EvZuQSsAggifLV1rLIDGfboutuAm3ANlAgT70g4cLWJbJkJavsxVVhx/utcSXfYczCNBLKmOkgbz0OYsAXabIesq502omnZTlZcSv4v9vz1k/0nXjGgWyus18Ca55E3IXquKlR02h+Vj0pD5CHybkovUTDOyl8IW8tFtSxjgWHeqqa5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000047, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 04:06:34PM +0800, Zorro Lang wrote: > On Mon, Jun 10, 2024 at 08:01:59PM -0700, Luis Chamberlain wrote: > > +mwrite() > > +{ > > + local file=$1 > > + local offset=$2 > > + local length=$3 > > + local map_len=${4:-$(_round_up_to_page_boundary $(_get_filesize $file)) } > > + > > + # Some callers expect xfs_io to crash with SIGBUS due to the mread, > > + # causing the shell to print "Bus error" to stderr. To allow this > > + # message to be redirected, execute xfs_io in a new shell instance. > > + # However, for this to work reliably, we also need to prevent the new > > + # shell instance from optimizing out the fork and directly exec'ing > > + # xfs_io. The easiest way to do that is to append 'true' to the > > + # commands, so that xfs_io is no longer the last command the shell sees. > > + bash -c "trap '' SIGBUS; ulimit -c 0; \ > > + $XFS_IO_PROG $file \ > > + -c 'mmap -w 0 $map_len' \ > > + -c 'mwrite $offset $length'; \ > > + true" > > +} > > As you've moved the _mread to common/rc, why not do the same for this mwrite? I didn't move it as this mwrite() is only used by one test. Let me know if you want me to move it. Luis