From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52A8C27C6E for ; Thu, 13 Jun 2024 15:41:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12B6D6B00D0; Thu, 13 Jun 2024 11:40:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5BE86B00CF; Thu, 13 Jun 2024 11:40:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB0C06B00D0; Thu, 13 Jun 2024 11:40:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9A4026B00CD for ; Thu, 13 Jun 2024 11:40:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 576691201F5 for ; Thu, 13 Jun 2024 15:40:43 +0000 (UTC) X-FDA: 82226277966.16.0243090 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 918B9C0010 for ; Thu, 13 Jun 2024 15:40:41 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ERvfPeDP; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718293240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yzkTNbdD0a2c3NKP5uSb0sKP6o4WHMSdtJob2Y7Lf9Y=; b=3CvXyO1iIQdGHbRlHqTM9gpK40i83OaU6l0WXe/Bx5VEYrDNe5aoABOJx8Uvel1tn1zBER lCHRAIJ0RIm1TtGZ23UBQih8J6Yiywhtp/k9qNx6xetOzTFRnAYxe8z8XEWrZy56IpbCSp wX3fllaD439WV8agWI7ozR1/YtiIZSs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718293240; a=rsa-sha256; cv=none; b=Jafmv+xbOlJ0LWPoHtA/cE1pSpeG54kqz4DLO7fkyM8XOgv+1X/sm7FThdpJ3TFesL+w5X P9hoNiI2NJsoaY/QrOvZk4ncujjcCJpNigXDku4L99LqAVeX/bZ8l/rXS41NiRKPfq2PBS X6WAH7CfHfvFAP4GJkfG38D9BVlC/zM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ERvfPeDP; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yzkTNbdD0a2c3NKP5uSb0sKP6o4WHMSdtJob2Y7Lf9Y=; b=ERvfPeDPd5l14AF4yJ+ldt9Nxz 7bS1JZiLy38Xf8wDo1A0V82qM67Vcpl4Hd18YEIdOpUE2l68glcOxjLeR/M86injkZp45uVvSyGwB 7Ag/sfbWYK4LDA+e6kncbnlWIOp5gMidKClL5x4raeJIt40QGuz0wb8qQx/slJbGswml3lq/zlmQX B13i8h5Xj460i6GnPDJUEGQ8RtYJVZP5fPBsBjxRS0nQ5SkIRy8Pi/WcHqAn9a5oXDNjfmapzJ/Lt C/i9zs92LoKtssDB0DvCPnBXCIbOZKLAHY2YqGxy9Gwk4NKmxB+PiaqN6Rqo1yofXq7sFl8G/2p0e +8LPn/RA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHmYu-0000000Furm-1Tae; Thu, 13 Jun 2024 15:40:28 +0000 Date: Thu, 13 Jun 2024 16:40:28 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: David Hildenbrand , Hugh Dickins , yang@os.amperecomputing.com, linmiaohe@huawei.com, muchun.song@linux.dev, osalvador@suse.de, "Pankaj Raghav (Samsung)" , david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 06/11] filemap: cap PTE range to be created to allowed zero fill in folio_map_range() Message-ID: References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-7-kernel@pankajraghav.com> <818f69fa-9dc7-4ca0-b3ab-a667cd1fb16d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 918B9C0010 X-Stat-Signature: fnife6op555kg3bw7zn6i71cmwaeietf X-Rspam-User: X-HE-Tag: 1718293241-351781 X-HE-Meta: U2FsdGVkX1+ZhKfZWU1tt79gqf2xc7cAMe8fE6HSUTMvJ288e2Xt8EaQhwOtTGT8SOcpB9NQVGCEGvgEdM411Or9BRsvl6avtvNhXYZsi8JJlJSbbPRUzgRQsopnQGhlNItH8F63qybBdb6/Ed3+8BKEDejdF2IjA8/Tz46aDGsboveDKMz565IOMP/PT5pvA0INFoObtM0tPdNJp08G7TpWwE9fxZvOxJ5ju3g2o0q74lV8DGyDdK4jKL2t604QyiKuuJ+py1xjSRJoI3h4ZdUcB31Uu7OPcUO4ue4HA9AEmJ0VezWGkVz9Qpk8VbIUWepCcRwkDOGAC9DTRYAz2jcqPAC+6/e8QWkgKrO2Gmnm29C4+gpcJfPMPADagIMLwHFfkOo572QlO+9qqB31DM7+clrphf9qXbW9LeC0dLRg/M4+CMOMbGE20mg66vmGehT1DRnz5fx9JHP/gqgm7TYLMNWSO0sFZ8aDeTaHtYcXtNPJFuOKNGT9z5h1D6vcBccuSnCNtWl2UQjeB19N7mygpoy4N6H7dppN+/4nbU7oWWq1wHe5HSF1zIrxtTGAA0YeZKW5HdVOROXyPHI6yS3LO8JR/qg6LhJWpX9ZtjkJ8ZqY5XgeEoXyDP57J+GqK8phsT4pR0B8GVUYa1BzV0P2PJp0btI0Y3Nzw9BgAwAhHlCpQJxgOl58hk2hF+6cFFQWM7ICB20kCoeLhRVuxDM2aFDjTno+qeRKiSrx8tlPeSI6NBzH9NsnUtMe8Hy+qPmYBbXjs7dIcD792vT2/XFzqDYcHCqY2HYWXllrJIf2GpTqVXYhCNGO+ZzmkpJM3f2EFeWSousOxzRGV3esHY8L1kztZ6iQkEsdamkTDxERYRj9o2IRaDVdz7ya0DmMMSbETt9yRboTs4RoW8I4x8ubN5YEsv5JCSEON2BdkK+FTX1XXpT0LxmK5wAd5zf4Axuz8w8NkALOFHX7YHy PICTe6hS PgscPbqufcmHeN4x/E3TgYgfYHMi0oKxO8YrdJMANeocsF9RIFuctPJuvekOgyIBuUtaaY3d9Aui7ecTlwTFudy7vrBY+fk3nitvpnHHcmBFlgD2LO+sUVy+1z7+Ujg6nwKHtFhX9yblWn4AhlhXOOHbJa/KJSmcAt7Zxb2VwtP5DEVPVFrAwGUWhfQa/JCjOqPLJUjZZszbqIhyR8u5I7LFX6m6RTAg8IxUslFTk7bHQQo8a07xiwbZeLBsRxtkl/Ymo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 08:38:15AM -0700, Luis Chamberlain wrote: > On Thu, Jun 13, 2024 at 04:32:27PM +0100, Matthew Wilcox wrote: > > On Thu, Jun 13, 2024 at 08:27:27AM -0700, Luis Chamberlain wrote: > > > The case I tested that failed the test was tmpfs with huge pages (not > > > large folios). So should we then have this: > > > > No. > > OK so this does have a change for tmpfs with huge pages enabled, do we > take the position then this is a fix for that? You literally said it was a fix just a few messages up thread? Besides, the behaviour changes (currently) depending on whether you specify "within_size" or "always". This patch makes it consistent.